Mailing List Archive: Lucene: Java-Dev

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery

Index | Next | Previous | View Threaded

jira at apache

Jun 30, 2009, 1:12 AM

Post #1 of 6 (260 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725521#action_12725521 ]

Uwe Schindler commented on LUCENE-1713:
---------------------------------------

Should I prepare a patch later?

I would simply rename the files in core and then change the tests and rest to find any references to the old RangeQuery/Filter (compile failures). After that I create a deprecated subclass of TermRange* with the old name and all ctors from the old class. The new class will only supply the new ctors (no deprecated ones using Term, mapping is done in the subclass).

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Fix For: 2.9
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

jira at apache

Jun 30, 2009, 2:28 AM

Post #2 of 6 (234 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725539#action_12725539 ]

Simon Willnauer commented on LUCENE-1713:
-----------------------------------------

For an issue like this we should go for "commit without patch" to keep the history of the classes. If you create a patch and apply it without useing svn copy && svn commit you will loose history which is not worth it in this case. Just a hint.

simon

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Fix For: 2.9
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

jira at apache

Jun 30, 2009, 2:31 AM

Post #3 of 6 (234 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725541#action_12725541 ]

Michael McCandless commented on LUCENE-1713:
--------------------------------------------

Yes feel free to take this one Uwe, thanks! That approach (and using svn move/copy) sounds good.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Fix For: 2.9
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

jira at apache

Jun 30, 2009, 2:31 AM

Post #4 of 6 (234 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725542#action_12725542 ]

Uwe Schindler commented on LUCENE-1713:
---------------------------------------

I know! :-) We had this problem a lot of times.

The patch will be only as reference. When I do it, I would assign and also commit with svn copy/move and so on.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Fix For: 2.9
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

jira at apache

Jul 2, 2009, 10:09 AM

Post #5 of 6 (208 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726559#action_12726559 ]

Uwe Schindler commented on LUCENE-1713:
---------------------------------------

After comparing the old 2.4.1 javadocs with the new ones, I found out, that RangeQueries in 2.4.1 only had Term ctors and no (field,String,String) ctors. As the new classes are separated (deprecated one and new one), I will change it to not have this strange getLowerTermText methods in the new class.

So I will prepare a new patch and do all tests again, no commits for now. The current patch had also some minor problems with BW compatibility and a missing collator.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713.patch, RangeFilter.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

jira at apache

Jul 2, 2009, 3:51 PM

Post #6 of 6 (206 views)
Permalink

[jira] Commented: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726721#action_12726721 ]

Uwe Schindler commented on LUCENE-1713:
---------------------------------------

After committing this, I will open an issue for Solr, to change the references to the not yet released RangeQuery/Filter ctors taking String args to the new classes.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713-backwards-branch.patch, LUCENE-1713.patch, LUCENE-1713.patch, RangeFilter.java, RangeFilter.java, RangeQuery.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com