
wolfgang.hoschek at mac
Oct 3, 2006, 11:08 PM
Post #4 of 5
(1036 views)
Permalink
|
|
Re: Is it save to remove the throw from FastCharStream.refill() ?
[In reply to]
|
|
A related prior discussion is at http://issues.apache.org/bugzilla/ show_bug.cgi?id=34930 Wolfgang. On Oct 3, 2006, at 7:08 PM, Yonik Seeley wrote: > Yeah, I don't think it's easy to get rid of the exception because the > client of FastStreamChar is JavaCC generated code, which AFAIK uses > the exception in lieu of explicit EOF checking. > > -Yonik > http://incubator.apache.org/solr Solr, the open-source Lucene > search server > > > On 10/3/06, Paul Smith <psmith [at] aconex> wrote: >> The throwing of an exception by this class is still being done on the >> Java side at this stage IIRC, and is also extremely bad for >> performance in Java. However I think the client of the class (one of >> the Filters I think) is expecting the EOF exception as a signal that >> it has received the end of the stream for tokenization point of view. >> >> I would love to get rid of it, but I think it will break a lot of >> behaviour. >> >> cheers, >> >> Paul Smith >> >> On 04/10/2006, at 11:48 AM, George Aroush wrote: >> >> > Hi folks, >> > >> > Over at Lucene.Net, we are trying to determine if it's safe to >> do the >> > following change: http://issues.apache.org/jira/browse/LUCENENET-8 >> > >> > Can you tell us, if this change is done on the Java Lucene code, >> > how it will >> > effect Lucene? Do you expect the it to run faster but more >> > importantly, is >> > it safe? >> > >> > Thanks. >> > >> > -- George Aroush > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene > For additional commands, e-mail: java-dev-help [at] lucene > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene For additional commands, e-mail: java-dev-help [at] lucene
|