Mailing List Archive: Lucene: Java-Dev

VOTE: Change Token to public

Index | Next | Previous | View Threaded

erik at ehatchersolutions

Jul 20, 2004, 11:22 AM

Post #1 of 3 (741 views)
Permalink

VOTE: Change Token to public

I'm voting, based on discussions on lucene-user, to make Token public.
+1

Any objections? Discussion?

Erik

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe [at] jakarta
For additional commands, e-mail: lucene-dev-help [at] jakarta

cutting at apache

Jul 20, 2004, 12:47 PM

Post #2 of 3 (687 views)
Permalink

Re: VOTE: Change Token to public [In reply to]

Erik Hatcher wrote:
> I'm voting, based on discussions on lucene-user, to make Token public. +1

I think you mean to make Token non-final, in which case I'm +1 too.

Probably we should also make the accessors non-final, make the fields
private and add setters for some (or all) of the fields. This will also
require a few changes to other classes in the analysis package which
access the currently package private fields, making them instead use
accessors. In short, we need a diff, complete with javadoc comments.

John, would you like to submit such a patch?

In general, things are expedited by high-quality patches accompanied by
a description of the problems solved by the patch. A simple request to
make more stuff non-final is too vague to be acted on.

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe [at] jakarta
For additional commands, e-mail: lucene-dev-help [at] jakarta

erik at ehatchersolutions

Jul 20, 2004, 1:55 PM

Post #3 of 3 (692 views)
Permalink

Re: VOTE: Change Token to public [In reply to]

On Jul 20, 2004, at 3:47 PM, Doug Cutting wrote:
> Erik Hatcher wrote:
>> I'm voting, based on discussions on lucene-user, to make Token
>> public. +1
>
> I think you mean to make Token non-final, in which case I'm +1 too.

Oops, yes, I mean non-final.

> Probably we should also make the accessors non-final, make the fields
> private and add setters for some (or all) of the fields. This will
> also require a few changes to other classes in the analysis package
> which access the currently package private fields, making them instead
> use accessors. In short, we need a diff, complete with javadoc
> comments.

Also, I implicitly intended for the changes you mention to take place
for changes to the fields of Token. Sorry, I should have specified
that.

Erik

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe [at] jakarta
For additional commands, e-mail: lucene-dev-help [at] jakarta

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads