Mailing List Archive: Lucene: Java-Dev

[jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo

Index | Next | Previous | View Threaded

jira at apache

Jul 3, 2012, 2:52 PM

Post #1 of 4 (75 views)
Permalink

[jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo

[ https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406089#comment-13406089 ]

Ryan McKinley commented on LUCENE-4099:
---------------------------------------

This looks fine, it looks like the one impact is that the Strategy would be instanciated once for each field rather then once for each fieldType (in solr terms)

> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
> Key: LUCENE-4099
> URL: https://issues.apache.org/jira/browse/LUCENE-4099
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to declare what information they needed per request. This meant that a Strategy could be used across multiple requests. However it doesn't really need to be that way any more, Strategies are light to instantiate and the generics are just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

jira at apache

Jul 3, 2012, 8:06 PM

Post #2 of 4 (66 views)
Permalink

[jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406250#comment-13406250 ]

David Smiley commented on LUCENE-4099:
--------------------------------------

It occurred to me that if Strategy is going to contain the field name, then it might as well contain isStored() & isIndexed() as well.

On the Solr side, I imagine the field type would do a lookup in a small HashMap of fieldName->Strategy. I'm not sure what the concurrency model is but I figure it needs to be thread-safe.

> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
> Key: LUCENE-4099
> URL: https://issues.apache.org/jira/browse/LUCENE-4099
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to declare what information they needed per request. This meant that a Strategy could be used across multiple requests. However it doesn't really need to be that way any more, Strategies are light to instantiate and the generics are just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

jira at apache

Jul 3, 2012, 8:16 PM

Post #3 of 4 (65 views)
Permalink

[jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406251#comment-13406251 ]

Chris Male commented on LUCENE-4099:
------------------------------------

I think we need to reconsider storing as part of the Strategys, the logic doesn't really make sense. I'll open an issue.

> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
> Key: LUCENE-4099
> URL: https://issues.apache.org/jira/browse/LUCENE-4099
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to declare what information they needed per request. This meant that a Strategy could be used across multiple requests. However it doesn't really need to be that way any more, Strategies are light to instantiate and the generics are just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

jira at apache

Jul 3, 2012, 8:25 PM

Post #4 of 4 (66 views)
Permalink

[jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406253#comment-13406253 ]

Chris Male commented on LUCENE-4099:
------------------------------------

LUCENE-4188

> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
> Key: LUCENE-4099
> URL: https://issues.apache.org/jira/browse/LUCENE-4099
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to declare what information they needed per request. This meant that a Strategy could be used across multiple requests. However it doesn't really need to be that way any more, Strategies are light to instantiate and the generics are just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads