Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Lucene: Java-Dev

[jira] [Updated] (SOLR-1258) health check file: relative path evaluated against CWD (directory were app was started)

 

 

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded


jira at apache

Apr 27, 2012, 3:52 PM

Post #1 of 4 (206 views)
Permalink
[jira] [Updated] (SOLR-1258) health check file: relative path evaluated against CWD (directory were app was started)

[ https://issues.apache.org/jira/browse/SOLR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1258:
---------------------------

Component/s: (was: clients - java)
Description:
The following element gives admin the ability to enable/disable a solr instance without taking it down

{noformat}
<admin>
<defaultQuery>solr</defaultQuery>

<!-- configure a healthcheck file for servers behind a loadbalancer
-->
<healthcheck type="file">server-enabled</healthcheck>
</admin>
{noformat}

There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.



was:
The following element gives admin the ability to enable/disable a solr instance without taking it down

<admin>
<defaultQuery>solr</defaultQuery>

<!-- configure a healthcheck file for servers behind a loadbalancer
-->
<healthcheck type="file">server-enabled</healthcheck>
</admin>

There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.



Fix Version/s: 4.0

This issue popped up on the #solr IRC channel today, and looking over the issue and the code i think that for Solr 4.0 we should bite the bullet and...

* move the configuration of the filename to an init param on the PingRequestHandler itself
** ie: {{<str name="healthcheckFile">server-enabled</str>}}
** default would be no file (as today) which would mean healthchecking doesn't apply (just the query)
* change the way the path is resolve to be relative to the dataDir
** much less kludgy and confusing
** something solr should deinitely be able to write to
** way more freindly to multi-core setups
* add a new example where "/admin/ping" is configured in solrconfig.xml
** completely remove the example healthcheck from the {{<admin>}} block
* don't bother trying to be backcompatible with the old configuration
** anyone using that syntax successfully is likely already using an absolute path, and will notice very quickly that it isn't working, and will be able to quickly see from CHANGES.txt that if they move that absolute path to the PingREquestHandler config everything works fine


Any objections?

> health check file: relative path evaluated against CWD (directory were app was started)
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-1258
> URL: https://issues.apache.org/jira/browse/SOLR-1258
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.4
> Environment: Mac
> Reporter: Jay
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> The following element gives admin the ability to enable/disable a solr instance without taking it down
> {noformat}
> <admin>
> <defaultQuery>solr</defaultQuery>
> <!-- configure a healthcheck file for servers behind a loadbalancer
> -->
> <healthcheck type="file">server-enabled</healthcheck>
> </admin>
> {noformat}
> There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 27, 2012, 4:58 PM

Post #2 of 4 (149 views)
Permalink
[jira] [Updated] (SOLR-1258) health check file: relative path evaluated against CWD (directory were app was started) [In reply to]

[ https://issues.apache.org/jira/browse/SOLR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1258:
---------------------------

Attachment: SOLR-1258.patch

quick stab at what i had in mind.

a few nocommits relating to docs and better error messages when dirs aren't readable/writable.

TestPingRequestHandler also still needs fixed (and needs some better tests around how this now works)

any objections to the general idea?

> health check file: relative path evaluated against CWD (directory were app was started)
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-1258
> URL: https://issues.apache.org/jira/browse/SOLR-1258
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.4
> Environment: Mac
> Reporter: Jay
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-1258.patch
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> The following element gives admin the ability to enable/disable a solr instance without taking it down
> {noformat}
> <admin>
> <defaultQuery>solr</defaultQuery>
> <!-- configure a healthcheck file for servers behind a loadbalancer
> -->
> <healthcheck type="file">server-enabled</healthcheck>
> </admin>
> {noformat}
> There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

May 2, 2012, 9:04 PM

Post #3 of 4 (147 views)
Permalink
[jira] [Updated] (SOLR-1258) health check file: relative path evaluated against CWD (directory were app was started) [In reply to]

[ https://issues.apache.org/jira/browse/SOLR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1258:
---------------------------

Attachment: SOLR-1258.patch

Fixed & improved the test, improved the error checking involving directory permisions, and added docs.


> health check file: relative path evaluated against CWD (directory were app was started)
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-1258
> URL: https://issues.apache.org/jira/browse/SOLR-1258
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.4
> Environment: Mac
> Reporter: Jay
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-1258.patch, SOLR-1258.patch
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> The following element gives admin the ability to enable/disable a solr instance without taking it down
> {noformat}
> <admin>
> <defaultQuery>solr</defaultQuery>
> <!-- configure a healthcheck file for servers behind a loadbalancer
> -->
> <healthcheck type="file">server-enabled</healthcheck>
> </admin>
> {noformat}
> There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

May 3, 2012, 12:58 PM

Post #4 of 4 (170 views)
Permalink
[jira] [Updated] (SOLR-1258) health check file: relative path evaluated against CWD (directory were app was started) [In reply to]

[ https://issues.apache.org/jira/browse/SOLR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1258:
---------------------------

Attachment: SOLR-1258.patch

patch just commited, includes cleanup of all the legacy syntax in examples & test configs, as well as the CHANGES.txt note for people upgrading.

Committed revision 1333598.


> health check file: relative path evaluated against CWD (directory were app was started)
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-1258
> URL: https://issues.apache.org/jira/browse/SOLR-1258
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.4
> Environment: Mac
> Reporter: Jay
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-1258.patch, SOLR-1258.patch, SOLR-1258.patch
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> The following element gives admin the ability to enable/disable a solr instance without taking it down
> {noformat}
> <admin>
> <defaultQuery>solr</defaultQuery>
> <!-- configure a healthcheck file for servers behind a loadbalancer
> -->
> <healthcheck type="file">server-enabled</healthcheck>
> </admin>
> {noformat}
> There is a problem with where the file 'server-enabled' is placed. Currently it appears that file is relative to the place where the server is stared. This causes trouble to deployment since theoretically the server could be started anywhere. My suggestion is to have the file relative to solr home so that it does not dependent on where the server is started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.