
jira at apache
Apr 22, 2012, 2:51 AM
Post #2 of 2
(34 views)
Permalink
|
|
[jira] [Commented] (LUCENE-4009) Implement toString() method in TermsFilter
[In reply to]
|
|
[ https://issues.apache.org/jira/browse/LUCENE-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259063#comment-13259063 ] Tim Costermans commented on LUCENE-4009: ---------------------------------------- Hey Chris, Basically all the subclasses of org.apache.lucene.search.Filter should implement their own toString() method. Maybe this can be enforced by adding this to the Filter class. {code} @Override public abstract String toString(); {code} I was going to investigate this, but this will be something for next week. > Implement toString() method in TermsFilter > ------------------------------------------ > > Key: LUCENE-4009 > URL: https://issues.apache.org/jira/browse/LUCENE-4009 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/other > Affects Versions: 3.5, 3.6 > Reporter: Tim Costermans > Priority: Trivial > Attachments: LUCENE-4009__Improved_previous_implementation_of__toString()_method_in_TermsFilter_+_added.patch, LUCENE-4009__implemented_toString()_method_in_TermsFilter_.patch > > > LUCENE-1049 introduced a enhanced implementation of the toString() method in the BooleanFilter clause. > This was an improvement, however I'm still seeing a lot Lucene filter classes not overriding the toString method resulting in a toString returning the classname and the hashcode of the object. > This can be useful sometimes, but it's totally not useful in my case. > I want to see the properties set in the filters so I know which Lucene query was created. > Now: > BooleanFilter(+BooleanFilter(BooleanFilter(+org.apache.lucene.search.TermsFilter [at] ea81ba6 +org.apache.lucene.search.TermsFilter [at] 26ea3cb) BooleanFilter(+org.apache.lucene.search.TermsFilter [at] df621f0 +org.apache.lucene.search.TermsFilter [at] 2f71244))) > Wanted behavior: > BooleanFilter(+BooleanFilter(BooleanFilter(+inStock:Y +barCode:12345678) BooleanFilter(+isHeavy:N +isDamaged:Y))) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe [at] lucene For additional commands, e-mail: dev-help [at] lucene
|