Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Lucene: Java-Dev

[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0

 

 

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded


jira at apache

Apr 6, 2012, 1:57 PM

Post #1 of 7 (155 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Summary: consolidate all api modules in one place and un!@$# packaging for 4.0 (was: Move lucene/core to modules/core, same with test-framework, etc)

editing title to be more general...

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 14, 2012, 12:21 PM

Post #2 of 7 (139 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965_module_build.patch

here's the patch.

first you must 'svn move lucene/contrib/contrib-build.xml lucene/module-build.xml'

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965_module_build.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 15, 2012, 6:21 AM

Post #3 of 7 (135 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965_module_build_pname.patch

just to clean up: this renames the project name to 'module-build' to match and fixes references.

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965_module_build.patch, LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 15, 2012, 8:39 AM

Post #4 of 7 (133 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965.patch

first take at a patch (works with r1326364).

don't fear the size of the patch, its mostly noise from svn moves (even though i used --no-diff-deleted, it still lists every file that was moved)

first you run this:
{noformat}
svn move lucene/contrib/demo lucene/demo
svn move lucene/contrib/highlighter lucene/highlighter
svn move lucene/contrib/memory lucene/memory
svn move lucene/contrib/misc lucene/misc
svn move lucene/contrib/sandbox lucene/sandbox
svn move modules/analysis lucene/analysis
svn move modules/benchmark lucene/benchmark
svn move modules/facet lucene/facet
svn move modules/grouping lucene/grouping
svn move modules/join lucene/join
svn move modules/queries lucene/queries
svn move modules/queryparser lucene/queryparser
svn move modules/spatial lucene/spatial
svn move modules/suggest lucene/suggest
svn delete modules
{noformat}

'ant test' and 'ant javadocs' and such works, but prepare-release etc need some help. Though: they didnt work before either :)

There are also some nocommits.

Still I'd like to get us in releasable shape with this issue... so I'm going to keep iterating. but its a fairly easy change...

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965.patch, LUCENE-3965_module_build.patch, LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 15, 2012, 10:07 AM

Post #5 of 7 (142 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965.patch

updated patch for r1326380 cleaning up the javadocs-all task (the package assigning stuff), and removing some nocommits: nuking contrib-uptodate and using module-uptodate everywhere.

next up: nuke the custom build directories so everything is organized under lucene/build/<XYZ>



> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965_module_build.patch, LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 15, 2012, 4:57 PM

Post #6 of 7 (141 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965.patch

updated patch for r1326433:

* fixed build directories and other general cleanup: all the lucene modules build under lucene/build/XXX
* package-all-binary makes binary releases that actually make sense!!!! (NOTE: still havent tackled any maven yet)
* lots of cleanups and simplifications.

Another TODO:
* src/site needs to be updated for all javadocs modules to link to their names (in general the name 'contrib' is removed here and many are missing). But i would do this after committing I think because it would make the patch harder to manage.

There is now a new script, since its important to nuke the svn:ignores for the previous bogus build directories:
{noformat}
# svn moves
svn move lucene/contrib/demo lucene/demo
svn move lucene/contrib/highlighter lucene/highlighter
svn move lucene/contrib/memory lucene/memory
svn move lucene/contrib/misc lucene/misc
svn move lucene/contrib/sandbox lucene/sandbox
svn move modules/analysis lucene/analysis
svn move modules/benchmark lucene/benchmark
svn move modules/facet lucene/facet
svn move modules/grouping lucene/grouping
svn move modules/join lucene/join
svn move modules/queries lucene/queries
svn move modules/queryparser lucene/queryparser
svn move modules/spatial lucene/spatial
svn move modules/suggest lucene/suggest
# nuke modules dir
svn delete modules
# clean up svn:ignore's, all modules should be consistent
# under lucene/build now... so nuke this
svn pset svn:ignore pom.xml lucene/analysis
svn pset svn:ignore -F - \
lucene/facet \
lucene/grouping \
lucene/join \
lucene/queries \
lucene/queryparser \
lucene/spatial \
lucene/suggest << EOF
*.iml
pom.xml
EOF
svn pset svn:ignore -F - lucene/benchmark << EOF
temp
work
*.iml
pom.xml
EOF
# now apply patch
patch -p0 < LUCENE-3965.patch
{noformat}

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965_module_build.patch, LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene


jira at apache

Apr 15, 2012, 5:41 PM

Post #7 of 7 (136 views)
Permalink
[jira] [Updated] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0 [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3965:
--------------------------------

Attachment: LUCENE-3965.patch

attached patch fixing maven too (still r1326433)

I can now do a full 'ant -Dversion=4.0.0 -Dgpg.key=322D7ECA prepare-release' which produces reasonable artifacts.

I think this is ready to commit, it makes our trunk theoretically releasable where it wasn't before.

I would keep the issue open to address more of the TODOs:
* merging all CHANGES/LICENSE/NOTICE
* fixing src/site and regenerating so the documentation links work
* fixing README's etc (e.g. notes about the demo).

Here is the script you need:
{noformat}
# svn moves
svn move lucene/contrib/demo lucene/demo
svn move lucene/contrib/highlighter lucene/highlighter
svn move lucene/contrib/memory lucene/memory
svn move lucene/contrib/misc lucene/misc
svn move lucene/contrib/sandbox lucene/sandbox
svn move modules/analysis lucene/analysis
svn move modules/benchmark lucene/benchmark
svn move modules/facet lucene/facet
svn move modules/grouping lucene/grouping
svn move modules/join lucene/join
svn move modules/queries lucene/queries
svn move modules/queryparser lucene/queryparser
svn move modules/spatial lucene/spatial
svn move modules/suggest lucene/suggest
# nuke modules dir
svn delete modules
# clean up svn:ignore's, all modules should be consistent
# under lucene/build now... so nuke this
svn pset svn:ignore pom.xml lucene/analysis
svn pset svn:ignore -F - \
lucene/facet \
lucene/grouping \
lucene/join \
lucene/queries \
lucene/queryparser \
lucene/spatial \
lucene/suggest << EOF
*.iml
pom.xml
EOF
svn pset svn:ignore -F - lucene/benchmark << EOF
temp
work
*.iml
pom.xml
EOF
# maven configurations
svn move dev-tools/maven/modules/analysis dev-tools/maven/lucene
svn move dev-tools/maven/modules/benchmark dev-tools/maven/lucene
svn move dev-tools/maven/modules/facet dev-tools/maven/lucene
svn move dev-tools/maven/modules/grouping dev-tools/maven/lucene
svn move dev-tools/maven/modules/join dev-tools/maven/lucene
svn move dev-tools/maven/modules/queries dev-tools/maven/lucene
svn move dev-tools/maven/modules/queryparser dev-tools/maven/lucene
svn move dev-tools/maven/modules/spatial dev-tools/maven/lucene
svn move dev-tools/maven/modules/suggest dev-tools/maven/lucene
svn delete dev-tools/maven/modules
svn move dev-tools/maven/lucene/contrib/demo dev-tools/maven/lucene
svn move dev-tools/maven/lucene/contrib/highlighter dev-tools/maven/lucene
svn move dev-tools/maven/lucene/contrib/memory dev-tools/maven/lucene
svn move dev-tools/maven/lucene/contrib/misc dev-tools/maven/lucene
svn move dev-tools/maven/lucene/contrib/sandbox dev-tools/maven/lucene
svn delete dev-tools/maven/lucene/contrib

# now apply patch
patch -p0 < LUCENE-3965.patch
{noformat}

> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
> Key: LUCENE-3965
> URL: https://issues.apache.org/jira/browse/LUCENE-3965
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965_module_build.patch, LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] lucene
For additional commands, e-mail: dev-help [at] lucene

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.