Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: HA-WG-Technical

[nakahira.kazutomo@oss.ntt.co.jp: [Linux-ha-dev] [PATCH] fix regexp for NUMCOMMITS in the Makefile of the resource-agents-3.9.1]

 

 

Linux-HA ha-wg-technical RSS feed   Index | Next | Previous | View Threaded


dejan at suse

Jun 22, 2011, 2:37 AM

Post #1 of 2 (329 views)
Permalink
[nakahira.kazutomo@oss.ntt.co.jp: [Linux-ha-dev] [PATCH] fix regexp for NUMCOMMITS in the Makefile of the resource-agents-3.9.1]

Hi Fabio,

This looks like one for you.

Cheers,

Dejan

----- Forwarded message from NAKAHIRA Kazutomo <nakahira.kazutomo [at] oss> -----

Date: Wed, 22 Jun 2011 18:04:18 +0900
From: NAKAHIRA Kazutomo <nakahira.kazutomo [at] oss>
To: High-Availability Linux Development List <linux-ha-dev [at] lists>
Reply-To: High-Availability Linux Development List
<linux-ha-dev [at] lists>
Subject: [Linux-ha-dev] [PATCH] fix regexp for NUMCOMMITS in the Makefile of
the resource-agents-3.9.1

Hi, all

I get the latest resource-agents source code and building RPM file,
then following error occurred in my test environment.

# ./autogen.sh; ./configure
# make rpm
(snip)
error: File
/tmp/build/resource-agents/resource-agents-3.1.9.9-20b27.tar.bz2: No
such file or directory
make: *** [rpm] Error 1

It seems that version number of the resource-agents
is wrong(3.9.1.9-20b27 is correct).

It is thought to be due to version number generation
procedure for spec file has problem.
(Version 3.9.1.9 must be eliminated trailing "9",
but second "9" eliminated.)

Please see attached patch.

Best Regards,

--
NAKAHIRA Kazutomo
Infrastructure Software Technology Unit
NTT Open Source Software Center

diff --git Makefile.am Makefile.am
index bd8dbeb..28634c0 100644
--- Makefile.am
+++ Makefile.am
@@ -113,7 +113,7 @@ $(SPEC): $(SPEC).in
if [ -n "$$alphatag" ]; then \
echo VERSION HAS NUMCOMMITS && \
numcomm=`echo $$ver | sed -e 's/.*\.//'` && \
- ver=`echo $$ver | sed -e 's/.'$$numcomm$$'//'`; \
+ ver=`echo $$ver | sed -e 's/.'$$numcomm'$$//'`; \
fi && \
if echo $$ver | grep -q "\.[[:digit:]]rc[[:digit:]]"; then \
rpmver=`echo $$ver | sed -e "s/rc[[:digit:]].*//g"` && \

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


----- End forwarded message -----
Attachments: Makafile.patch (0.48 KB)


fdinitto at redhat

Jun 22, 2011, 2:46 AM

Post #2 of 2 (314 views)
Permalink
Re: [nakahira.kazutomo@oss.ntt.co.jp: [Linux-ha-dev] [PATCH] fix regexp for NUMCOMMITS in the Makefile of the resource-agents-3.9.1] [In reply to]

Ahh good catch!

thanks for the fix!

Fabio

On 6/22/2011 11:37 AM, Dejan Muhamedagic wrote:
> Hi Fabio,
>
> This looks like one for you.
>
> Cheers,
>
> Dejan
>
> ----- Forwarded message from NAKAHIRA Kazutomo <nakahira.kazutomo [at] oss> -----
>
> Date: Wed, 22 Jun 2011 18:04:18 +0900
> From: NAKAHIRA Kazutomo <nakahira.kazutomo [at] oss>
> To: High-Availability Linux Development List <linux-ha-dev [at] lists>
> Reply-To: High-Availability Linux Development List
> <linux-ha-dev [at] lists>
> Subject: [Linux-ha-dev] [PATCH] fix regexp for NUMCOMMITS in the Makefile of
> the resource-agents-3.9.1
>
> Hi, all
>
> I get the latest resource-agents source code and building RPM file,
> then following error occurred in my test environment.
>
> # ./autogen.sh; ./configure
> # make rpm
> (snip)
> error: File
> /tmp/build/resource-agents/resource-agents-3.1.9.9-20b27.tar.bz2: No
> such file or directory
> make: *** [rpm] Error 1
>
> It seems that version number of the resource-agents
> is wrong(3.9.1.9-20b27 is correct).
>
> It is thought to be due to version number generation
> procedure for spec file has problem.
> (Version 3.9.1.9 must be eliminated trailing "9",
> but second "9" eliminated.)
>
> Please see attached patch.
>
> Best Regards,
>
>
>
>
> _______________________________________________
> ha-wg-technical mailing list
> ha-wg-technical [at] lists
> https://lists.linux-foundation.org/mailman/listinfo/ha-wg-technical

_______________________________________________
ha-wg-technical mailing list
ha-wg-technical [at] lists
https://lists.linux-foundation.org/mailman/listinfo/ha-wg-technical

Linux-HA ha-wg-technical RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.