Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

[PATCH] Fix chkconfig heartbeat on flag missing in ha_propagate

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


philippe at alcoy

Jun 20, 2012, 8:07 PM

Post #1 of 3 (462 views)
Permalink
[PATCH] Fix chkconfig heartbeat on flag missing in ha_propagate

# HG changeset patch
# User Philippe Alcoy <philippe [at] alcoy>
# Date 1340192740 -25200
# Node ID 8cf404c39c7e0c63ec4a86b967d8a3e5de60977b
# Parent f6ce2daddba6234643f715c46b28d5562940eb1f
Fix chkconfig heartbeat on flag missing in ha_propagate

diff -r f6ce2daddba6 -r 8cf404c39c7e heartbeat/lib/ha_propagate.in
--- a/heartbeat/lib/ha_propagate.in Wed Jun 20 17:42:24 2012 +0700
+++ b/heartbeat/lib/ha_propagate.in Wed Jun 20 18:45:40 2012 +0700
@@ -39,5 +39,5 @@
print "Propagating HA configuration files to node " + v + "."
res = os.system("scp " + cfgfile + " " + authfile + " root@" + v + ":" + cfgdir)
print "Setting HA startup configuration on node " + v + "."
- res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat`")
+ res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat on`")

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


lars.ellenberg at linbit

Jun 22, 2012, 3:34 AM

Post #2 of 3 (436 views)
Permalink
Re: [PATCH] Fix chkconfig heartbeat on flag missing in ha_propagate [In reply to]

On Thu, Jun 21, 2012 at 10:07:11AM +0700, Philippe Alcoy wrote:
> # HG changeset patch
> # User Philippe Alcoy <philippe [at] alcoy>
> # Date 1340192740 -25200
> # Node ID 8cf404c39c7e0c63ec4a86b967d8a3e5de60977b
> # Parent f6ce2daddba6234643f715c46b28d5562940eb1f
> Fix chkconfig heartbeat on flag missing in ha_propagate
>
> diff -r f6ce2daddba6 -r 8cf404c39c7e heartbeat/lib/ha_propagate.in
> --- a/heartbeat/lib/ha_propagate.in Wed Jun 20 17:42:24 2012 +0700
> +++ b/heartbeat/lib/ha_propagate.in Wed Jun 20 18:45:40 2012 +0700
> @@ -39,5 +39,5 @@
> print "Propagating HA configuration files to node " + v + "."
> res = os.system("scp " + cfgfile + " " + authfile + " root@" + v + ":" + cfgdir)
> print "Setting HA startup configuration on node " + v + "."
> - res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat`")
> + res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat on`")

Well, No.

Is is supposed to propagate the setting of the current node
to all nodes.

There are valid use cases for having heartbeat *off* on system boot.

Note the double chkconfig and the backticks.

When it was implemented, "chkconfig single-service-name" apparently
returned the current setting as "on" or "off" to stdout,
at least on the distribution this was implemented on.

I guess this is no longer true, or diverges between distributions.
It is not even available on all distributions.

If anything, I'm tempted to drop that ha_propagate thing altogether.
People should be able to scp config files and runlevel settings
themselves, really...

--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


philippe at alcoy

Jun 26, 2012, 3:51 AM

Post #3 of 3 (421 views)
Permalink
Re: [PATCH] Fix chkconfig heartbeat on flag missing in ha_propagate [In reply to]

On 22 June 2012 17:34, Lars Ellenberg <lars.ellenberg [at] linbit> wrote:
> On Thu, Jun 21, 2012 at 10:07:11AM +0700, Philippe Alcoy wrote:
>> # HG changeset patch
>> # User Philippe Alcoy <philippe [at] alcoy>
>> # Date 1340192740 -25200
>> # Node ID 8cf404c39c7e0c63ec4a86b967d8a3e5de60977b
>> # Parent  f6ce2daddba6234643f715c46b28d5562940eb1f
>> Fix chkconfig heartbeat on flag missing in ha_propagate
>>
>> diff -r f6ce2daddba6 -r 8cf404c39c7e heartbeat/lib/ha_propagate.in
>> --- a/heartbeat/lib/ha_propagate.in   Wed Jun 20 17:42:24 2012 +0700
>> +++ b/heartbeat/lib/ha_propagate.in   Wed Jun 20 18:45:40 2012 +0700
>> @@ -39,5 +39,5 @@
>>      print "Propagating HA configuration files to node " + v + "."
>>      res = os.system("scp " + cfgfile + " " + authfile + " root@" + v + ":" + cfgdir)
>>      print "Setting HA startup configuration on node " + v + "."
>> -    res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat`")
>> +    res = os.system("ssh " + " root@" + v + " chkconfig `chkconfig heartbeat on`")
>
> Well, No.
>
> Is is supposed to propagate the setting of the current node
> to all nodes.
>
> There are valid use cases for having heartbeat *off* on system boot.
>
> Note the double chkconfig and the backticks.

Ooops. I overlooked this. Apologies.

> When it was implemented, "chkconfig single-service-name" apparently
> returned the current setting as "on" or "off" to stdout,
> at least on the distribution this was implemented on.
>
> I guess this is no longer true, or diverges between distributions.
> It is not even available on all distributions.
>
> If anything, I'm tempted to drop that ha_propagate thing altogether.
> People should be able to scp config files and runlevel settings
> themselves, really...

If you choose to keep ha_propagate, I would suggest a quick update of
the following page:
http://www.linux-ha.org/doc/users-guide/_propagating_the_cluster_configuration_to_cluster_nodes.html

]] It will afterwards also connect to the nodes using ssh and issue
]] chkconfig heartbeat on in order to enable Heartbeat services on
]] system startup.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.