Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

[PATCH]Three corrections of slapd

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


nozawat at gmail

Dec 1, 2011, 6:59 PM

Post #1 of 5 (487 views)
Permalink
[PATCH]Three corrections of slapd

Hi

1.slapd-001.patch
When there is not PID file, I add the error log output.
2.slapd-002.patch
Bug correction of the while sentence.
3.slapd-003.patch
Spelling miscorrection of the return code.

Regards,
Tomo
Attachments: slapd-001.patch (0.65 KB)
  slapd-002.patch (0.43 KB)
  slapd-003.patch (0.39 KB)


dejan at suse

Dec 2, 2011, 4:19 AM

Post #2 of 5 (474 views)
Permalink
Re: [PATCH]Three corrections of slapd [In reply to]

Hi,

On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
> Hi
>
> 1.slapd-001.patch
> When there is not PID file, I add the error log output.

It could happen that slapd takes longer to start. I don't think
it would make sense to log error in that case.

> 2.slapd-002.patch
> Bug correction of the while sentence.

Applied.

> 3.slapd-003.patch
> Spelling miscorrection of the return code.

Applied. Good catch.

Cheers,

Dejan

> Regards,
> Tomo




> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


nozawat at gmail

Dec 4, 2011, 5:09 PM

Post #3 of 5 (467 views)
Permalink
Re: [PATCH]Three corrections of slapd [In reply to]

Hi Dejan

>> 1.slapd-001.patch
>> When there is not PID file, I add the error log output.
>
> It could happen that slapd takes longer to start. I don't think
> it would make sense to log error in that case.
This patch is not start processing, It is a patch of the monitor processing.
When PID file did not exist by monitor processing, I thought that it
was proper to output error-log.

Regards,
Tomo

2011/12/2 Dejan Muhamedagic <dejan [at] suse>:
> Hi,
>
> On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
>> Hi
>>
>> 1.slapd-001.patch
>>   When there is not PID file, I add the error log output.
>
> It could happen that slapd takes longer to start. I don't think
> it would make sense to log error in that case.
>
>> 2.slapd-002.patch
>>   Bug correction of the while sentence.
>
> Applied.
>
>> 3.slapd-003.patch
>>   Spelling miscorrection of the return code.
>
> Applied. Good catch.
>
> Cheers,
>
> Dejan
>
>> Regards,
>> Tomo
>
>
>
>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev [at] lists
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


dejan at suse

Dec 5, 2011, 1:34 AM

Post #4 of 5 (462 views)
Permalink
Re: [PATCH]Three corrections of slapd [In reply to]

Hi Tomo,

On Mon, Dec 05, 2011 at 10:09:24AM +0900, nozawat wrote:
> Hi Dejan
>
> >> 1.slapd-001.patch
> >> When there is not PID file, I add the error log output.
> >
> > It could happen that slapd takes longer to start. I don't think
> > it would make sense to log error in that case.
> This patch is not start processing, It is a patch of the monitor processing.
> When PID file did not exist by monitor processing, I thought that it
> was proper to output error-log.

Oops, I misread the code :-) I'll apply this patch too.

Cheers,

Dejan

> Regards,
> Tomo
>
> 2011/12/2 Dejan Muhamedagic <dejan [at] suse>:
> > Hi,
> >
> > On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
> >> Hi
> >>
> >> 1.slapd-001.patch
> >>   When there is not PID file, I add the error log output.
> >
> > It could happen that slapd takes longer to start. I don't think
> > it would make sense to log error in that case.
> >
> >> 2.slapd-002.patch
> >>   Bug correction of the while sentence.
> >
> > Applied.
> >
> >> 3.slapd-003.patch
> >>   Spelling miscorrection of the return code.
> >
> > Applied. Good catch.
> >
> > Cheers,
> >
> > Dejan
> >
> >> Regards,
> >> Tomo
> >
> >
> >
> >
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev [at] lists
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


nozawat at gmail

Dec 5, 2011, 1:42 AM

Post #5 of 5 (459 views)
Permalink
Re: [PATCH]Three corrections of slapd [In reply to]

Hi Dejan

> Oops, I misread the code :-) I'll apply this patch too.
Thanks! I wait to be applied.

Regards,
Tomo

2011/12/5 Dejan Muhamedagic <dejan [at] suse>:
> Hi Tomo,
>
> On Mon, Dec 05, 2011 at 10:09:24AM +0900, nozawat wrote:
>> Hi Dejan
>>
>> >> 1.slapd-001.patch
>> >>   When there is not PID file, I add the error log output.
>> >
>> > It could happen that slapd takes longer to start. I don't think
>> > it would make sense to log error in that case.
>> This patch is not start processing, It is a patch of the monitor processing.
>> When PID file did not exist by monitor processing, I thought that it
>> was proper to output error-log.
>
> Oops, I misread the code :-) I'll apply this patch too.
>
> Cheers,
>
> Dejan
>
>> Regards,
>> Tomo
>>
>> 2011/12/2 Dejan Muhamedagic <dejan [at] suse>:
>> > Hi,
>> >
>> > On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
>> >> Hi
>> >>
>> >> 1.slapd-001.patch
>> >>   When there is not PID file, I add the error log output.
>> >
>> > It could happen that slapd takes longer to start. I don't think
>> > it would make sense to log error in that case.
>> >
>> >> 2.slapd-002.patch
>> >>   Bug correction of the while sentence.
>> >
>> > Applied.
>> >
>> >> 3.slapd-003.patch
>> >>   Spelling miscorrection of the return code.
>> >
>> > Applied. Good catch.
>> >
>> > Cheers,
>> >
>> > Dejan
>> >
>> >> Regards,
>> >> Tomo
>> >
>> >
>> >
>> >
>> >> _______________________________________________________
>> >> Linux-HA-Dev: Linux-HA-Dev [at] lists
>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> Home Page: http://linux-ha.org/
>> >
>> > _______________________________________________________
>> > Linux-HA-Dev: Linux-HA-Dev [at] lists
>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> > Home Page: http://linux-ha.org/
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev [at] lists
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.