renayama19661014 at ybb
Sep 19, 2011, 5:11 PM
Post #4 of 7
(282 views)
Permalink
|
|
Re: [Patch 2]Change of the output level of the log of the resource agent of mysql.
[In reply to]
|
|
Hi Raoul,
Thank you for comment.
The log level of my patch is not decision at suggestion.
We think the log level to be allowed to unify it in WARN or INFO either other than ERROR.
If log in status carried out by start and stop does not come to appear at ERROR level, the system administrator is not confused.
Best Regards,
Hideo Yamauchi.
--- On Tue, 2011/9/20, Raoul Bhatia [IPAX] <r.bhatia [at] ipax> wrote:
> hello hideo-san!
>
> i just got to review your patch and got one or two questions (see below)
>
> On 08/30/2011 10:20 AM, renayama19661014 [at] ybb wrote:
> > mysql.1651-2.patch
> >
> >
> > diff -r a2d0d723bc62 heartbeat/mysql
> > --- a/heartbeat/mysql Wed Aug 31 01:32:38 2011 +0900
> > +++ b/heartbeat/mysql Wed Aug 31 01:38:08 2011 +0900
> > @@ -807,7 +817,7 @@
> > # Let the CRM/LRM time us out if required
> > start_wait=1
> > while [ $start_wait = 1 ]; do
> > - mysql_status
> > + mysql_status warn
> > rc=$?
> > if [ $rc = $OCF_SUCCESS ]; then
> > start_wait=0
> > @@ -908,7 +918,7 @@
> > count=0
> > while [ $count -lt $shutdown_timeout ]
> > do
> > - mysql_status
> > + mysql_status info
> > rc=$?
> > if [ $rc = $OCF_NOT_RUNNING ]; then
> > break
>
> in mysql_start() you use the warn level
> in mysql_stop() you use the info level.
>
> shouldn't these two be the same levels?
> (e.g. both warn?)
>
> > @@ -918,7 +928,7 @@
> > ocf_log debug "MySQL still hasn't stopped yet. Waiting..."
> > done
> >
> > - mysql_status
> > + mysql_status info
> > if [ $? != $OCF_NOT_RUNNING ]; then
> > ocf_log info "MySQL failed to stop after ${shutdown_timeout}s using SIGTERM. Trying SIGKILL..."
> > /bin/kill -KILL $pid> /dev/null
>
> while reviewing the log leves, should we set this last "ocf_log" line
> to "warn"? (sorry for mixing this in here - but maybe you can comment
> on that too :) )
>
> cheers,
> raoul
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
|
mysql.1651-2.patch
