Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

Re: An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


darrent at akurit

May 3, 2011, 12:38 AM

Post #1 of 2 (199 views)
Permalink
Re: An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32

Florian/Team

How do I see any latter commits to the GIT repository???

Is there a way I can confirm that you have committed my latest
version/changes?
(Yes I know this is probably a very embarrassing "newbee question" but I
have no experience with GOT repositories and frankly have no idea how
this all works).

Darren



On Fri, 2011-04-29 at 12:00 -0600,
linux-ha-dev-request [at] lists wrote:

> ate: Fri, 29 Apr 2011 09:57:04 +0200
> From: Florian Haas <florian.haas [at] linbit>
> Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux
> Containers) - Linux-HA-Dev Digest, Vol 89, Issue 30
> To: High-Availability Linux Development List
> <linux-ha-dev [at] lists>
> Message-ID: <4DBA6F50.7090201 [at] linbit>
> Content-Type: text/plain; charset="utf-8"
>
> On 2011-04-29 08:04, Darren Thompson wrote:
> > You posted my "first attempt" and not the latest version, is it
> possible
> > to add that one as it addresses some( most hopefully) of the issues
> you
> > identified.
>
> Already there. Been there since yesterday.
>
> https://github.com/fghaas/resource-agents/commit/07827c42494dbec2c011133d9f82e831bc8b2eb6
>
> > There are still some valid points you have raised however, So I'm
> going
> > to try to incorporate them into a "third version".
>
> See how much easier this would be if you actually did this in your own
> github repo that we could just pull from?
>
> Cheers,
> Florian


florian.haas at linbit

May 3, 2011, 3:00 AM

Post #2 of 2 (186 views)
Permalink
Re: An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32 [In reply to]

On 2011-05-03 09:38, Darren Thompson wrote:
> Florian/Team
>
> How do I see any latter commits to the GIT repository???

See my other message --
https://github.com/fghaas/resource-agents/commits/lxc/heartbeat/lxc

> Is there a way I can confirm that you have committed my latest
> version/changes?

Yes, review the history.

I've added a bunch of small commits to bring the resource agent in line
with accepted precedent. Please test the current version and highlight
any issues that may arise. You will need to tweak your configuration as
I have renamed your parameters, and changed the semantics of some.

One thing you might want to revisit is your use of the
"${TRANS_RES_STATE}" state file. AIUI you're using this in order to tell
a gracefully stopped container from one that has crashed -- are you sure
LXC doesn't provide a built-in way to do that?

Cheers,
Florian
Attachments: signature.asc (0.26 KB)

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.