Mailing List Archive: Linux-HA: Dev

Re: [Openais] An OCF agent for LXC (Linux Containers)

Index | Next | Previous | View Threaded

florian.haas at linbit

Apr 26, 2011, 6:36 AM

Post #1 of 7 (478 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers)

Thanks Darren!

Thanks for the contribution! Can I suggest

- we move this discussion to the linux-ha-dev list (where most OCF RA
related discussions and reviews take place);

- you give the RA a makeover following the OCF RA developer's guide
(http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html);

- you set up your own github fork off of
https://github.com/ClusterLabs/resource-agents, and push your RA to that
so we can eventually pull it into the mainline repo?

Also, can you explain what the advantages of your approach are, versus
using libvirt-managed lxc containers which Pacemaker can tie into via
the existing VirtualDomain agent?

Thanks!
Cheers,
Florian

Attachments:

signature.asc (0.26 KB)

dejan at suse

Apr 26, 2011, 7:03 AM

Post #2 of 7 (468 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

On Tue, Apr 26, 2011 at 03:36:35PM +0200, Florian Haas wrote:
> Thanks Darren!
>
> Thanks for the contribution! Can I suggest
>
> - we move this discussion to the linux-ha-dev list (where most OCF RA
> related discussions and reviews take place);
>
> - you give the RA a makeover following the OCF RA developer's guide
> (http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html);
>
> - you set up your own github fork off of
> https://github.com/ClusterLabs/resource-agents, and push your RA to that
> so we can eventually pull it into the mainline repo?
>
> Also, can you explain what the advantages of your approach are, versus
> using libvirt-managed lxc containers which Pacemaker can tie into via
> the existing VirtualDomain agent?

Yes, this is the first thing I thought about too.

A few remarks:

- the "required" attributes in meta-data need to be reviewed,
a parameter is either required or has a default, cannot be
both

- why use screen(1) in start?

BTW, since lxc seems to be easy to setup, it would be great to
supply an ocft test file along with the RA. It's quite
straightforward, just make a copy of one of the existing test
files from tools/ocft.

Cheers,

Dejan

> Thanks!
> Cheers,
> Florian
>

> _______________________________________________
> Openais mailing list
> Openais [at] lists
> https://lists.linux-foundation.org/mailman/listinfo/openais
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

florian.haas at linbit

Apr 27, 2011, 6:28 AM

Post #3 of 7 (462 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

On 2011-04-27 00:29, Darren Thompson wrote:
> Florian
>
> All good points.
>
> Unfortunately I'm not a "programmer", so have no idea how to setup a
> 'git repo' and currently have no facility to host it even if I knew how.

That's the point of github; they provide all that infrastructure for you.

It all boils down to

- go to https://github.com and set up an account
- go to https://github.com/ClusterLabs/resource-agents and click "Fork"
- open a command line and do "git clone" of the URL that the web page
then shows (likely git [at] github:<yourusername>/resource-agents.git)
- add your resource agent into the heartbeat/ directory
- do "git add heartbeat/lxc"
- do "git commit" with a meaningful commit message
- do "git push" to push the changes to your github repo.

> I will review the developers guide and as much as possible bring the OCF
> in-line with those recommendations

Yes, please do.

> Why I did not use libvirt-manager LXC containers:
> 1. Frankly I could not get the libvirt integration to work and wasted
> weeks worth of testing trying, if someone more experienced would like to
> get that working, more power to them.
> 2. The libvirt works and acts like a competing fork and does not use any
> of the "normal" lxc tools, I'm not sold that it's the best approach.

OK, fair enough. If we get your resource agent into mergeable shape then
the fact that may duplicate some VirtualDomain functionality is not a
show stopper.

One other question: have you considered submitting this resource agent
to the lxc folks?

Cheers,
Florian

Attachments:

signature.asc (0.26 KB)

darrent at akurit

Apr 28, 2011, 1:21 AM

Post #4 of 7 (463 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

Florina/TEAM

Thanks for your input and the link to the guidelines

I have updated my original ocf file in line with the guidlines, it even
gave me a few tips on how to do things "better" so was well worth the
time spent.

Please find the updated ocf file for LXC contianers as a cluster
resource attached.

Since I'm not an actual developer (or even a career coder) I do not have
the facility to host my own github fork so would appreciate "someone"
adopting this and integrating it into their git repository.

I have since added myself the the developer mailing list so I should be
able to contribute to the "refining" of this.

Regards
Darren

On Tue, 2011-04-26 at 15:36 +0200, Florian Haas wrote:

> Thanks Darren!
>
> Thanks for the contribution! Can I suggest
>
> - we move this discussion to the linux-ha-dev list (where most OCF RA
> related discussions and reviews take place);
>
> - you give the RA a makeover following the OCF RA developer's guide
> (http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html);
>
> - you set up your own github fork off of
> https://github.com/ClusterLabs/resource-agents, and push your RA to that
> so we can eventually pull it into the mainline repo?
>
> Also, can you explain what the advantages of your approach are, versus
> using libvirt-managed lxc containers which Pacemaker can tie into via
> the existing VirtualDomain agent?
>
> Thanks!
> Cheers,
> Florian
>

Attachments:

lxc (11.3 KB)

florian.haas at linbit

Apr 28, 2011, 2:56 AM

Post #5 of 7 (463 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

On 2011-04-28 10:21, Darren Thompson wrote:
> Florina/TEAM
>
> Thanks for your input and the link to the guidelines
>
> I have updated my original ocf file in line with the guidlines, it even
> gave me a few tips on how to do things "better" so was well worth the
> time spent.
>
> Please find the updated ocf file for LXC contianers as a cluster
> resource attached.
>
> Since I'm not an actual developer (or even a career coder)

Do you think I am?

> I do not have
> the facility to host my own github fork so would appreciate "someone"
> adopting this and integrating it into their git repository.

OK, I have added this to a separate "lxc" branch in my own github fork.
I'd appreciate if you could at least get yourself an account on github
so you can comment on commit line notes.

I have added my comments to this page:

https://github.com/fghaas/resource-agents/commit/73f80b31f1cee5eff1c2fe2b968f4ea593e8f405

Some of those may have already been addresses in your updated version,
but to keep things simple I've kept my comments to one commit for the
time being.

Florian

PS: We can stop CC'ing the openais list, this is in no way
Corosync/OpenAIS related.

Attachments:

signature.asc (0.26 KB)

lmb at novell

May 1, 2011, 11:49 AM

Post #6 of 7 (453 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

On 2011-04-26T16:03:48, Dejan Muhamedagic <dejan [at] suse> wrote:

> - the "required" attributes in meta-data need to be reviewed,
> a parameter is either required or has a default, cannot be
> both

Why would this be the case?

Regards,
Lars

--
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N�rnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

tserong at novell

May 1, 2011, 7:17 PM

Post #7 of 7 (450 views)
Permalink

Re: [Openais] An OCF agent for LXC (Linux Containers) [In reply to]

On 5/2/2011 at 04:49 AM, Lars Marowsky-Bree <lmb [at] novell> wrote:
> On 2011-04-26T16:03:48, Dejan Muhamedagic <dejan [at] suse> wrote:
>
> > - the "required" attributes in meta-data need to be reviewed,
> > a parameter is either required or has a default, cannot be
> > both
>
> Why would this be the case?

There was some discussion about this last March:

http://www.gossamer-threads.com/lists/linuxha/pacemaker/62163#62163

In summary (from lge):

> If a "mandatory" parameter has a default,
> then I'd think it is no longer mandatory,
> because, if not specified, it has its default
> to fall back to.
>
> [...]
>
> Mandatory paramters in my opinion should be such paramters
> that cannot possibly have a sane default, like the IP for IPaddr2.

Regards,

Tim

--
Tim Serong <tserong [at] novell>
Senior Clustering Engineer, OPS Engineering, Novell Inc.

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads