Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

Regarding to (Patch #2434: Latest addition to external/riloe

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


Holger.Teutsch at web

Aug 29, 2010, 2:51 AM

Post #1 of 2 (234 views)
Permalink
Regarding to (Patch #2434: Latest addition to external/riloe

Jochen,
your method getconfignames returns *all* parameters.

[ 1.62] if cmd == 'getconfignames':
[ 1.63] - for arg in [ "hostlist", "ilo_hostname", "ilo_user", "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method"]:
[ 1.64] + for arg in [ "hostlist", "ilo_hostname", "ilo_user", "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method", "ilo_proxyhost", "ilo_proxyport"]:

I think that "getconfignames" should only return the *required* parameters. Else you get a warning logged by

lib/plugins/stonith/external.c (lines 416 to 420) for each unspecified (e.g. *optional*) parameter.

Regards
Holger
___________________________________________________________
WEB.DE DSL SOMMER-SPECIAL: Surf & Phone Flat 16.000 für
nur 19,99 ¿/mtl.!* http://web.de/DSL-Doppel-Flatrate/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


dejanmm at fastmail

Sep 23, 2010, 3:06 AM

Post #2 of 2 (192 views)
Permalink
Re: Regarding to (Patch #2434: Latest addition to external/riloe [In reply to]

Hi,

On Sun, Aug 29, 2010 at 11:51:54AM +0200, Holger Teutsch wrote:
> Jochen,
> your method getconfignames returns *all* parameters.
>
> [ 1.62] if cmd == 'getconfignames':
> [ 1.63] - for arg in [ "hostlist", "ilo_hostname", "ilo_user", "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method"]:
> [ 1.64] + for arg in [ "hostlist", "ilo_hostname", "ilo_user", "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method", "ilo_proxyhost", "ilo_proxyport"]:
>
> I think that "getconfignames" should only return the *required* parameters. Else you get a warning logged by

There could still be some installations which require all
parameters to be shown.

> lib/plugins/stonith/external.c (lines 416 to 420) for each unspecified (e.g. *optional*) parameter.

Those messages have now reduced severity. Unfortunately, they're
also dumped to stdout which makes the pacemaker v1.1 complain
about not being able to parse the line. The issue is tracked in
https://bugzilla.novell.com/show_bug.cgi?id=639165

Thanks,

Dejan

> Regards
> Holger
> ___________________________________________________________
> WEB.DE DSL SOMMER-SPECIAL: Surf & Phone Flat 16.000 für
> nur 19,99 ¿/mtl.!* http://web.de/DSL-Doppel-Flatrate/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.