Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

[PATCH]Restraint of the noisy log output of the monitor processing.

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


renayama19661014 at ybb

Aug 17, 2010, 10:42 PM

Post #1 of 11 (505 views)
Permalink
[PATCH]Restraint of the noisy log output of the monitor processing.

Hi,

I tested the latest edition of pgsql.

However, log is output at every monitor processing in the latest edition.

This is a practice result of select now().

Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------ 2010-08-17-15:03:35.28827+09
(1 row)
Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
15:03:45.528977+09 (1 row)

I send the patch which I changed it of to form same as former monitor.

With this patch, the log of the monitor processing becomes quiet.


Best Regards,
Hideo Yamauchi.
Attachments: pgsql.patch (1.00 KB)


dejanmm at fastmail

Aug 18, 2010, 12:57 AM

Post #2 of 11 (505 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi,

On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661014 [at] ybb wrote:
> Hi,
>
> I tested the latest edition of pgsql.
>
> However, log is output at every monitor processing in the latest edition.
>
> This is a practice result of select now().
>
> Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------ 2010-08-17-15:03:35.28827+09
> (1 row)
> Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
> 15:03:45.528977+09 (1 row)
>
> I send the patch which I changed it of to form same as former monitor.
>
> With this patch, the log of the monitor processing becomes quiet.

We need a different kind of ocf_run, the existing one makes too
much noise. Or to fix it. Anybody against dropping "ocf_log info"?

What is your opinion?

Thanks,

Dejan

> Best Regards,
> Hideo Yamauchi.


> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Aug 18, 2010, 1:07 AM

Post #3 of 11 (497 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Dejan,

> We need a different kind of ocf_run, the existing one makes too
> much noise. Or to fix it. Anybody against dropping "ocf_log info"?
>
> What is your opinion?

When we use logd, ocf_log functions well.
However, we give considerably annoying log when we do not use logd.

We advance to the direction that does not use logd now.

If a problem is solved by changing it into new ocf_log, I obey the policy.


Best Regards,
Hideo Yamauchi.


--- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:

> Hi,
>
> On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661014 [at] ybb wrote:
> > Hi,
> >
> > I tested the latest edition of pgsql.
> >
> > However, log is output at every monitor processing in the latest edition.
> >
> > This is a practice result of select now().
> >
> > Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------
> 2010-08-17-15:03:35.28827+09
> > (1 row)
> > Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
> > 15:03:45.528977+09 (1 row)
> >
> > I send the patch which I changed it of to form same as former monitor.
> >
> > With this patch, the log of the monitor processing becomes quiet.
>
> We need a different kind of ocf_run, the existing one makes too
> much noise. Or to fix it. Anybody against dropping "ocf_log info"?
>
> What is your opinion?
>
> Thanks,
>
> Dejan
>
> > Best Regards,
> > Hideo Yamauchi.
>
>
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


dejanmm at fastmail

Aug 18, 2010, 1:20 AM

Post #4 of 11 (494 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661014 [at] ybb wrote:
> Hi Dejan,
>
> > We need a different kind of ocf_run, the existing one makes too
> > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> >
> > What is your opinion?
>
> When we use logd, ocf_log functions well.

I don't understand how would logd make a difference?

> However, we give considerably annoying log when we do not use logd.
>
> We advance to the direction that does not use logd now.

Why is that?

> If a problem is solved by changing it into new ocf_log, I obey the policy.

Let's hope we get some input from others too.

Cheers,

Dejan

> Best Regards,
> Hideo Yamauchi.
>
>
> --- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:
>
> > Hi,
> >
> > On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661014 [at] ybb wrote:
> > > Hi,
> > >
> > > I tested the latest edition of pgsql.
> > >
> > > However, log is output at every monitor processing in the latest edition.
> > >
> > > This is a practice result of select now().
> > >
> > > Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------
> > 2010-08-17-15:03:35.28827+09
> > > (1 row)
> > > Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
> > > 15:03:45.528977+09 (1 row)
> > >
> > > I send the patch which I changed it of to form same as former monitor.
> > >
> > > With this patch, the log of the monitor processing becomes quiet.
> >
> > We need a different kind of ocf_run, the existing one makes too
> > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> >
> > What is your opinion?
> >
> > Thanks,
> >
> > Dejan
> >
> > > Best Regards,
> > > Hideo Yamauchi.
> >
> >
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Aug 18, 2010, 1:29 AM

Post #5 of 11 (497 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Dejan,

Thank you for comment.

> > When we use logd, ocf_log functions well.
>
> I don't understand how would logd make a difference?

When we do not use logd, all log is output.
* We use logfacility without using logd.

(snip)
if
[ -n "$HA_LOGFACILITY" ]
then
: logging through syslog
# loglevel is unknown, use 'notice' for now
loglevel=notice
case "${*}" in
*ERROR*) loglevel=err;;
*WARN*) loglevel=warning;;
*INFO*|info) loglevel=info;;
esac
logger -t "$HA_LOGTAG" -p ${HA_LOGFACILITY}.${loglevel} "${*}" ---> this
fi
(snip)

> > We advance to the direction that does not use logd now.
>
> Why is that?

In fact, we always used the script which confirmed survival of logd.
However, we decided to abolish survival monitor of this logd this time.
And it was decided that the log went by way of a syslog.

> Let's hope we get some input from others too.

All right.

Best Regards,
Hideo Yamauchi.


--- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:

> On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661014 [at] ybb wrote:
> > Hi Dejan,
> >
> > > We need a different kind of ocf_run, the existing one makes too
> > > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> > >
> > > What is your opinion?
> >
> > When we use logd, ocf_log functions well.
>
> I don't understand how would logd make a difference?
>
> > However, we give considerably annoying log when we do not use logd.
> >
> > We advance to the direction that does not use logd now.
>
> Why is that?
>
> > If a problem is solved by changing it into new ocf_log, I obey the policy.
>
> Let's hope we get some input from others too.
>
> Cheers,
>
> Dejan
>
> > Best Regards,
> > Hideo Yamauchi.
> >
> >
> > --- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:
> >
> > > Hi,
> > >
> > > On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661014 [at] ybb wrote:
> > > > Hi,
> > > >
> > > > I tested the latest edition of pgsql.
> > > >
> > > > However, log is output at every monitor processing in the latest edition.
> > > >
> > > > This is a practice result of select now().
> > > >
> > > > Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------
> > > 2010-08-17-15:03:35.28827+09
> > > > (1 row)
> > > > Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
> > > > 15:03:45.528977+09 (1 row)
> > > >
> > > > I send the patch which I changed it of to form same as former monitor.
> > > >
> > > > With this patch, the log of the monitor processing becomes quiet.
> > >
> > > We need a different kind of ocf_run, the existing one makes too
> > > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> > >
> > > What is your opinion?
> > >
> > > Thanks,
> > >
> > > Dejan
> > >
> > > > Best Regards,
> > > > Hideo Yamauchi.
> > >
> > >
> > > > _______________________________________________________
> > > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > > Home Page: http://linux-ha.org/
> > >
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> > >
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Aug 18, 2010, 4:05 AM

Post #6 of 11 (497 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Dejan,

Sorrry....I made a mistake in comment.

> When we do not use logd, all log is output.
> * We use logfacility without using logd.
>
> (snip)
> if
> [ -n "$HA_LOGFACILITY" ]
> then
> : logging through syslog
> # loglevel is unknown, use 'notice' for now
> loglevel=notice
> case "${*}" in
> *ERROR*) loglevel=err;;
> *WARN*) loglevel=warning;;
> *INFO*|info) loglevel=info;;
> esac
> logger -t "$HA_LOGTAG" -p ${HA_LOGFACILITY}.${loglevel} "${*}" ---> this
> fi
> (snip)

This is comment of another problem.
Please please forget this comment.

The main point of my change is not to use ocf_run by monitor processing.
When distance of monitor is short, the reason is because very useless log is output.

Best Regards,
Hideo Yamauchi.

--- renayama19661014 [at] ybb wrote:

> Hi Dejan,
>
> Thank you for comment.
>
> > > When we use logd, ocf_log functions well.
> >
> > I don't understand how would logd make a difference?
>
> When we do not use logd, all log is output.
> * We use logfacility without using logd.
>
> (snip)
> if
> [ -n "$HA_LOGFACILITY" ]
> then
> : logging through syslog
> # loglevel is unknown, use 'notice' for now
> loglevel=notice
> case "${*}" in
> *ERROR*) loglevel=err;;
> *WARN*) loglevel=warning;;
> *INFO*|info) loglevel=info;;
> esac
> logger -t "$HA_LOGTAG" -p ${HA_LOGFACILITY}.${loglevel} "${*}" ---> this
> fi
> (snip)
>
> > > We advance to the direction that does not use logd now.
> >
> > Why is that?
>
> In fact, we always used the script which confirmed survival of logd.
> However, we decided to abolish survival monitor of this logd this time.
> And it was decided that the log went by way of a syslog.
>
> > Let's hope we get some input from others too.
>
> All right.
>
> Best Regards,
> Hideo Yamauchi.
>
>
> --- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:
>
> > On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661014 [at] ybb wrote:
> > > Hi Dejan,
> > >
> > > > We need a different kind of ocf_run, the existing one makes too
> > > > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> > > >
> > > > What is your opinion?
> > >
> > > When we use logd, ocf_log functions well.
> >
> > I don't understand how would logd make a difference?
> >
> > > However, we give considerably annoying log when we do not use logd.
> > >
> > > We advance to the direction that does not use logd now.
> >
> > Why is that?
> >
> > > If a problem is solved by changing it into new ocf_log, I obey the policy.
> >
> > Let's hope we get some input from others too.
> >
> > Cheers,
> >
> > Dejan
> >
> > > Best Regards,
> > > Hideo Yamauchi.
> > >
> > >
> > > --- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:
> > >
> > > > Hi,
> > > >
> > > > On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661014 [at] ybb wrote:
> > > > > Hi,
> > > > >
> > > > > I tested the latest edition of pgsql.
> > > > >
> > > > > However, log is output at every monitor processing in the latest edition.
> > > > >
> > > > > This is a practice result of select now().
> > > > >
> > > > > Aug 17 15:03:35 n1 pgsql[16269]: INFO: now ------------------------------
> > > > 2010-08-17-15:03:35.28827+09
> > > > > (1 row)
> > > > > Aug 17 15:03:45 n1 pgsql[16516]: INFO: now ------------------------------- 2010-08-17
> > > > > 15:03:45.528977+09 (1 row)
> > > > >
> > > > > I send the patch which I changed it of to form same as former monitor.
> > > > >
> > > > > With this patch, the log of the monitor processing becomes quiet.
> > > >
> > > > We need a different kind of ocf_run, the existing one makes too
> > > > much noise. Or to fix it. Anybody against dropping "ocf_log info"?
> > > >
> > > > What is your opinion?
> > > >
> > > > Thanks,
> > > >
> > > > Dejan
> > > >
> > > > > Best Regards,
> > > > > Hideo Yamauchi.
> > > >
> > > >
> > > > > _______________________________________________________
> > > > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > > > Home Page: http://linux-ha.org/
> > > >
> > > > _______________________________________________________
> > > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > > Home Page: http://linux-ha.org/
> > > >
> > >
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


lmb at novell

Aug 18, 2010, 4:59 AM

Post #7 of 11 (498 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

On 2010-08-18T14:42:15, renayama19661014 [at] ybb wrote:

> I send the patch which I changed it of to form same as former monitor.
>
> With this patch, the log of the monitor processing becomes quiet.

Yes, but the output goes to stdout still, it is just not captured by the
script - but the lrmd might still catch it.

In my opinion, the best fix would be to introduce a "-q" option to
ocf_run, which would prevent the logging for the success case.


Regards,
Lars

--
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


sergeyfd at gmail

Aug 18, 2010, 7:46 AM

Post #8 of 11 (496 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

I'm in a complete agreement with Lars. Instead of creating new
function runasowner_for_monitor() inside an RA, and pgsql probably not
the only case of "too much logging", I'd rather introduce a new option
for ocf_run.

On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree <lmb [at] novell> wrote:
> On 2010-08-18T14:42:15, renayama19661014 [at] ybb wrote:
>
>> I send the patch which I changed it of to form same as former monitor.
>>
>> With this patch, the log of the monitor processing becomes quiet.
>
> Yes, but the output goes to stdout still, it is just not captured by the
> script - but the lrmd might still catch it.
>
> In my opinion, the best fix would be to introduce a "-q" option to
> ocf_run, which would prevent the logging for the success case.
>
>
> Regards,
>    Lars
>
> --
> Architect Storage/HA, OPS Engineering, Novell, Inc.
> SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
> "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>



--
Serge Dubrouski.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Aug 19, 2010, 7:20 PM

Post #9 of 11 (486 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Serge,
Hi Lars,
Hi Dejan,

Thank you for an opinion.

I think it to be good with an option of ocf_run.
An option will be useful in future.

To Dejan : About this matter, do we wait for the opinion of other people a little more?

Best Regards,
Hideo Yamauchi.


--- Serge Dubrouski <sergeyfd [at] gmail> wrote:

> I'm in a complete agreement with Lars. Instead of creating new
> function runasowner_for_monitor() inside an RA, and pgsql probably not
> the only case of "too much logging", I'd rather introduce a new option
> for ocf_run.
>
> On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree <lmb [at] novell> wrote:
> > On 2010-08-18T14:42:15, renayama19661014 [at] ybb wrote:
> >
> >> I send the patch which I changed it of to form same as former monitor.
> >>
> >> With this patch, the log of the monitor processing becomes quiet.
> >
> > Yes, but the output goes to stdout still, it is just not captured by the
> > script - but the lrmd might still catch it.
> >
> > In my opinion, the best fix would be to introduce a "-q" option to
> > ocf_run, which would prevent the logging for the success case.
> >
> >
> > Regards,
> > &#65533; &#65533;Lars
> >
> > --
> > Architect Storage/HA, OPS Engineering, Novell, Inc.
> > SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N&#65533;rnberg)
> > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
>
>
> --
> Serge Dubrouski.
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


dejanmm at fastmail

Aug 20, 2010, 1:03 AM

Post #10 of 11 (479 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Hideo-san,

On Fri, Aug 20, 2010 at 11:20:03AM +0900, renayama19661014 [at] ybb wrote:
> Hi Serge,
> Hi Lars,
> Hi Dejan,
>
> Thank you for an opinion.
>
> I think it to be good with an option of ocf_run.
> An option will be useful in future.
>
> To Dejan : About this matter, do we wait for the opinion of
> other people a little more?

ocf_run now has option -q to suppress output logging in case the
command ran OK.

Cheers,

Dejan

>
> Best Regards,
> Hideo Yamauchi.
>
>
> --- Serge Dubrouski <sergeyfd [at] gmail> wrote:
>
> > I'm in a complete agreement with Lars. Instead of creating new
> > function runasowner_for_monitor() inside an RA, and pgsql probably not
> > the only case of "too much logging", I'd rather introduce a new option
> > for ocf_run.
> >
> > On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree <lmb [at] novell> wrote:
> > > On 2010-08-18T14:42:15, renayama19661014 [at] ybb wrote:
> > >
> > >> I send the patch which I changed it of to form same as former monitor.
> > >>
> > >> With this patch, the log of the monitor processing becomes quiet.
> > >
> > > Yes, but the output goes to stdout still, it is just not captured by the
> > > script - but the lrmd might still catch it.
> > >
> > > In my opinion, the best fix would be to introduce a "-q" option to
> > > ocf_run, which would prevent the logging for the success case.
> > >
> > >
> > > Regards,
> > > &#65533; &#65533;Lars
> > >
> > > --
> > > Architect Storage/HA, OPS Engineering, Novell, Inc.
> > > SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N&#65533;rnberg)
> > > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
> > >
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> > >
> >
> >
> >
> > --
> > Serge Dubrouski.
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Aug 20, 2010, 1:12 AM

Post #11 of 11 (478 views)
Permalink
Re: [PATCH]Restraint of the noisy log output of the monitor processing. [In reply to]

Hi Dejan,

> ocf_run now has option -q to suppress output logging in case the
> command ran OK.

Thanks!!

I test ocf_run in pgsql.

Had better patch be able to appoint the practice by the option of ocf_run in an OCF parameter of
pgsql-RA, too?

(example)
<parameter name="monitor_silent_log" unique="0" required="0">
................

</parameter>

Or are not necessary?

Best Regards,
Hideo Yamauchi.



--- Dejan Muhamedagic <dejanmm [at] fastmail> wrote:

> Hi Hideo-san,
>
> On Fri, Aug 20, 2010 at 11:20:03AM +0900, renayama19661014 [at] ybb wrote:
> > Hi Serge,
> > Hi Lars,
> > Hi Dejan,
> >
> > Thank you for an opinion.
> >
> > I think it to be good with an option of ocf_run.
> > An option will be useful in future.
> >
> > To Dejan : About this matter, do we wait for the opinion of
> > other people a little more?
>
> ocf_run now has option -q to suppress output logging in case the
> command ran OK.
>
> Cheers,
>
> Dejan
>
> >
> > Best Regards,
> > Hideo Yamauchi.
> >
> >
> > --- Serge Dubrouski <sergeyfd [at] gmail> wrote:
> >
> > > I'm in a complete agreement with Lars. Instead of creating new
> > > function runasowner_for_monitor() inside an RA, and pgsql probably not
> > > the only case of "too much logging", I'd rather introduce a new option
> > > for ocf_run.
> > >
> > > On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree <lmb [at] novell> wrote:
> > > > On 2010-08-18T14:42:15, renayama19661014 [at] ybb wrote:
> > > >
> > > >> I send the patch which I changed it of to form same as former monitor.
> > > >>
> > > >> With this patch, the log of the monitor processing becomes quiet.
> > > >
> > > > Yes, but the output goes to stdout still, it is just not captured by the
> > > > script - but the lrmd might still catch it.
> > > >
> > > > In my opinion, the best fix would be to introduce a "-q" option to
> > > > ocf_run, which would prevent the logging for the success case.
> > > >
> > > >
> > > > Regards,
> > > > &#65533; &#65533;Lars
> > > >
> > > > --
> > > > Architect Storage/HA, OPS Engineering, Novell, Inc.
> > > > SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N&#65533;rnberg)
> > > > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
> > > >
> > > > _______________________________________________________
> > > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > > Home Page: http://linux-ha.org/
> > > >
> > >
> > >
> > >
> > > --
> > > Serge Dubrouski.
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> > >
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.