Mailing List Archive: Linux-HA: Dev

[PATCH]Improvement of the log output of Filesystem.

Index | Next | Previous | View Threaded

renayama19661014 at ybb

Nov 17, 2009, 7:05 PM

Post #1 of 4 (1178 views)
Permalink

[PATCH]Improvement of the log output of Filesystem.

Hi,

We review the output of the error log of RA.

In RA of Filesystem, the error of the modprobe command and rm command is canceled somehow or other.

I made a patch to output it without canceling the failure of the command.

Furthermore, I added the failure of the dd command to the log output.

It is a small patch, but wants you to include it in the latest edition by all means.

Best Regards,
Hideo Yamauchi.

Attachments:

Filesystem.dev.patch (1.17 KB)

r.bhatia at ipax

Nov 18, 2009, 12:19 AM

Post #2 of 4 (1077 views)
Permalink

Re: [PATCH]Improvement of the log output of Filesystem. [In reply to]

dear On 11/18/2009 04:05 AM, renayama19661014 [at] ybb wrote:
> patch, but wants you to include it in the latest edition by all means.

hi,

in your patch, you add a second output line for the dd error:

> @@ -754,6 +754,7 @@
> err_output=`dd if=$DEVICE $dd_opts 2>&1 >/dev/null`
> if [ $? -ne 0 ]; then
> ocf_log err "Failed to read device $DEVICE"
> + ocf_log err "dd said: $err_output"
> return $OCF_ERR_GENERIC
> fi
> return $OCF_SUCCESS

i think it would be better to concat this into one line, something like:
ocf_log err "Failed to read device $DEVICE: $err_output"

cheers,
raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia [at] ipax
Technischer Leiter

IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office [at] ipax
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

renayama19661014 at ybb

Nov 18, 2009, 5:06 PM

Post #3 of 4 (1058 views)
Permalink

Re: [PATCH]Improvement of the log output of Filesystem. [In reply to]

Hi raoul,

> i think it would be better to concat this into one line, something like:
> ocf_log err "Failed to read device $DEVICE: $err_output"

I imitated it for handling of Filesystem_monitor_20 and thought about a revision.
However, I think that a revision of your patch is better.
I think that I had better revise the log output of Filesystem_monitor_20.

I attach a patch again.

Best Regards,
Hideo Yamauchi.

--- "Raoul Bhatia [IPAX]" <r.bhatia [at] ipax> wrote:

> dear On 11/18/2009 04:05 AM, renayama19661014 [at] ybb wrote:
> > patch, but wants you to include it in the latest edition by all means.
>
> hi,
>
> in your patch, you add a second output line for the dd error:
>
> > @@ -754,6 +754,7 @@
> > err_output=`dd if=$DEVICE $dd_opts 2>&1 >/dev/null`
> > if [ $? -ne 0 ]; then
> > ocf_log err "Failed to read device $DEVICE"
> > + ocf_log err "dd said: $err_output"
> > return $OCF_ERR_GENERIC
> > fi
> > return $OCF_SUCCESS
>
> i think it would be better to concat this into one line, something like:
> ocf_log err "Failed to read device $DEVICE: $err_output"
>
> cheers,
> raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc. email. r.bhatia [at] ipax
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at
> Barawitzkagasse 10/2/2/11 email. office [at] ipax
> 1190 Wien tel. +43 1 3670030
> FN 277995t HG Wien fax. +43 1 3670030 15
> ____________________________________________________________________
>

Attachments:

Filesystem.dev.patch (1.59 KB)

renayama19661014 at ybb

Jan 13, 2010, 8:19 PM

Post #4 of 4 (795 views)
Permalink

Re: [PATCH]Improvement of the log output of Filesystem. [In reply to]

Hi Lars,

This is old topic, but how do you think?

If you understand my opinion, I make a patch for Filesystem for development once again.

Please tell your opinion.

Best Regards,
Hideo Yamauchi.

--- renayama19661014 [at] ybb wrote:

> Hi Lars,
>
> We want to consider the pursuit of the cause why there was a problem in RA.
>
> We do not want to cancel the standard error output if possible.
>
> About two commands of Filesystem, I intend to have revised it equally.
>
> Because I do not understand intention of the practice of all commands, I may have a mistake.
>
> Do you think that there is some problem?
>
> Best Regards,
> Hideo Yamauchi.
>
> --- Lars Marowsky-Bree <lmb [at] suse> wrote:
>
> > On 2009-11-19T10:06:37, renayama19661014 [at] ybb wrote:
> >
> > > Hi raoul,
> > >
> > > > i think it would be better to concat this into one line, something like:
> > > > ocf_log err "Failed to read device $DEVICE: $err_output"
> > >
> > > I imitated it for handling of Filesystem_monitor_20 and thought about a revision.
> > > However, I think that a revision of your patch is better.
> > > I think that I had better revise the log output of Filesystem_monitor_20.
> > >
> > > I attach a patch again.
> >
> > Why do you want to clutter the logs with the rm -f or modprobe output?
> >
> >
> > Regards,
> > Lars
> >
> > --
> > Architect Storage/HA, OPS Engineering, Novell, Inc.
> > SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N$B>-gS(Bnberg)
> > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev [at] lists
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads