Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

Re: [PATCH]Improvement of the log output of Filesystem.

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


lmb at suse

Nov 19, 2009, 3:03 AM

Post #1 of 2 (562 views)
Permalink
Re: [PATCH]Improvement of the log output of Filesystem.

On 2009-11-19T10:06:37, renayama19661014 [at] ybb wrote:

> Hi raoul,
>
> > i think it would be better to concat this into one line, something like:
> > ocf_log err "Failed to read device $DEVICE: $err_output"
>
> I imitated it for handling of Filesystem_monitor_20 and thought about a revision.
> However, I think that a revision of your patch is better.
> I think that I had better revise the log output of Filesystem_monitor_20.
>
> I attach a patch again.

Why do you want to clutter the logs with the rm -f or modprobe output?


Regards,
Lars

--
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


renayama19661014 at ybb

Nov 23, 2009, 5:11 PM

Post #2 of 2 (487 views)
Permalink
Re: [PATCH]Improvement of the log output of Filesystem. [In reply to]

Hi Lars,

We want to consider the pursuit of the cause why there was a problem in RA.

We do not want to cancel the standard error output if possible.

About two commands of Filesystem, I intend to have revised it equally.

Because I do not understand intention of the practice of all commands, I may have a mistake.

Do you think that there is some problem?

Best Regards,
Hideo Yamauchi.

--- Lars Marowsky-Bree <lmb [at] suse> wrote:

> On 2009-11-19T10:06:37, renayama19661014 [at] ybb wrote:
>
> > Hi raoul,
> >
> > > i think it would be better to concat this into one line, something like:
> > > ocf_log err "Failed to read device $DEVICE: $err_output"
> >
> > I imitated it for handling of Filesystem_monitor_20 and thought about a revision.
> > However, I think that a revision of your patch is better.
> > I think that I had better revise the log output of Filesystem_monitor_20.
> >
> > I attach a patch again.
>
> Why do you want to clutter the logs with the rm -f or modprobe output?
>
>
> Regards,
> Lars
>
> --
> Architect Storage/HA, OPS Engineering, Novell, Inc.
> SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N$B>-gS(Bnberg)
> "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.