Mailing List Archive: Linux-HA: Dev

crm shell and defaults (was Re: [Patch] RA: nfsserver: Preparing /proc/fs/nfsd first)

Index | Next | Previous | View Threaded

florian.haas at linbit

Aug 12, 2009, 10:55 PM

Post #1 of 2 (672 views)
Permalink

crm shell and defaults (was Re: [Patch] RA: nfsserver: Preparing /proc/fs/nfsd first)

On 08/12/2009 04:45 PM, Dejan Muhamedagic wrote:
> Hi,
>
> On Wed, Jul 29, 2009 at 04:16:35PM +0200, Lars Marowsky-Bree wrote:
>> On 2009-07-28T12:42:38, "Raoul Bhatia [IPAX]" <r.bhatia at ipax.at> wrote:
>>
>>> Q. is this enough to set a default value for
>>> ${OCF_RESKEY_nfs_max_block_size} ? i am asking because in other ra's,
>>> there is a special check like:
>>>
>>> : ${OCF_RESKEY_config_dir=""}
>>>
>>> at the beginning of the script.
>> Good catch, that needs to happen. This is only the default for newly
>> created resources via the GUI; the CRM shell ignores default settings
>> as Dejan wrongly disagrees about their usefulness.
>
> You take something out of context from the discussion which is
> not available to the general public. And then even deliver the
> verdict. IIRC, the discussion was about meta attributes for
> actions (such as timeouts) which is a different matter.
>
> At any rate, the defaults for parameters shouldn't be imposed by
> the clients (GUI or CLI), but by the other side: either the crmd
> or, as it is the case now, resource agents. As Florian Haas
> suggested earlier, it would be preferable to have defaults
> defined by the crmd.

Just to pitch in another possible alternative, would it be possible to
have the crm shell not _impose_ defaults outright, but instead suggest
them via tab completion in interactive mode? As in "params foo=<tab>"
being expanded to "params foo=bar" assuming the RA defines a default of
"bar" for the resource param "foo"?

Cheers,
Florian

Attachments:

signature.asc (0.25 KB)

dejanmm at fastmail

Aug 13, 2009, 1:19 AM

Post #2 of 2 (610 views)
Permalink

Re: crm shell and defaults (was Re: [Patch] RA: nfsserver: Preparing /proc/fs/nfsd first) [In reply to]

Hi,

On Thu, Aug 13, 2009 at 07:55:42AM +0200, Florian Haas wrote:
> On 08/12/2009 04:45 PM, Dejan Muhamedagic wrote:
> > Hi,
> >
> > On Wed, Jul 29, 2009 at 04:16:35PM +0200, Lars Marowsky-Bree wrote:
> >> On 2009-07-28T12:42:38, "Raoul Bhatia [IPAX]" <r.bhatia at ipax.at> wrote:
> >>
> >>> Q. is this enough to set a default value for
> >>> ${OCF_RESKEY_nfs_max_block_size} ? i am asking because in other ra's,
> >>> there is a special check like:
> >>>
> >>> : ${OCF_RESKEY_config_dir=""}
> >>>
> >>> at the beginning of the script.
> >> Good catch, that needs to happen. This is only the default for newly
> >> created resources via the GUI; the CRM shell ignores default settings
> >> as Dejan wrongly disagrees about their usefulness.
> >
> > You take something out of context from the discussion which is
> > not available to the general public. And then even deliver the
> > verdict. IIRC, the discussion was about meta attributes for
> > actions (such as timeouts) which is a different matter.
> >
> > At any rate, the defaults for parameters shouldn't be imposed by
> > the clients (GUI or CLI), but by the other side: either the crmd
> > or, as it is the case now, resource agents. As Florian Haas
> > suggested earlier, it would be preferable to have defaults
> > defined by the crmd.
>
> Just to pitch in another possible alternative, would it be possible to
> have the crm shell not _impose_ defaults outright, but instead suggest
> them via tab completion in interactive mode? As in "params foo=<tab>"
> being expanded to "params foo=bar" assuming the RA defines a default of
> "bar" for the resource param "foo"?

That is already available. Even more, pressing the <tab> key also
shows the explanation for the parameter:

crm(live)configure# primitive p1 ocf:heartbeat:apache params httpd=<tab>
httpd (string, [/usr/sbin/httpd]): httpd binary path
The full pathname of the httpd binary (optional).

Thanks,

Dejan

>
> Cheers,
> Florian
>

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads