heder at google
Jul 28, 2009, 3:58 AM
Post #5 of 5
(961 views)
Permalink
|
On Tue, Jul 28, 2009 at 09:50, Andrew Beekhof<andrew [at] beekhof> wrote:
> On Mon, Jul 27, 2009 at 11:19 AM, Hannes Eder<heder [at] google> wrote:
>> On Wed, Jul 22, 2009 at 17:13, Lars Marowsky-Bree<lmb [at] suse> wrote:
>>> On 2009-07-21T17:24:56, Hannes Eder <heder [at] google> wrote:
>>>
>>>> Hi,
>>>>
>>>> Some parts of the linux-ha code base might benefit from a little code
>>>> cleanup. In this case the question arises which coding style should
>>>> be applied. I did not find any documentation on that in the linux-ha
>>>> source tree. Did I miss something?
>>>>
>>>> What about obeying to Documentation/CodingStyle from the linux-kernel?
>>>> By that means tools like scripts/checkpatch.pl could be used.
>>>>
>>>> Comments?
>>>
>>> I won't mind, but style cleanups for their own sake don't really
>>> convince me. If they come as a pre-requisite for a bugfix sure, but
>>> remember that basically the only bits of heartbeat that are still
>>> actively maintained is the LRM + resource agents.
>>
>> Agree, but other parts of linux-ha are still in use, no? So, I think
>> for maintainability
>
> This isn't much of a concern.
> Apart from clplumbing and the pieces lars mentioned, the rest of code
> is essentially unmaintained.
Unmaintained does not necessarily imply unused, e.g. what about heartbeat?
>> its worthwhile spending some effort tidying up the
>> code. I do not ask you to do it, it's mere the question if one,
>> e.g. me, spends some time cleaning up code, what style should be
>> applied and if it is likely to be merged?
>
> I'd say not likely.
> We very rarely look at that code and, to me, the chance that the
> cleanup would introduce bugs offsets any positive aspect.
We could run 'size' and say 'md5sum' before and after the change, to
ensure the binary remains the same, making it less likely to introduce
a bug, at least for a given configuration.
-Hannes
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
|
