Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

[PATCH] RA iSCSILogicalUnit: use $OCF_RESOURCE_INSTANCE as default SCSI ID

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


florian.haas at linbit

Jul 7, 2009, 2:45 AM

Post #1 of 2 (632 views)
Permalink
[PATCH] RA iSCSILogicalUnit: use $OCF_RESOURCE_INSTANCE as default SCSI ID

# HG changeset patch
# User Florian Haas <florian.haas [at] linbit>
# Date 1246882365 -7200
# Node ID e6bb7b0fe3dd0aa13b41f616d888a309a6c63e29
# Parent e71e3c165be9539e50a3137807952f6bed904e58
RA iSCSILogicalUnit: use $OCF_RESOURCE_INSTANCE as default SCSI ID

Some iSCSI initiators and other application rely on a device's SCSI ID
to be persistent across target failovers. As some target
implementations do not guarantee SCSI ID persistency across failovers,
use $OCF_RESOURCE_INSTANCE as the default SCSI ID.

diff -r e71e3c165be9 -r e6bb7b0fe3dd resources/OCF/iSCSILogicalUnit
--- a/resources/OCF/iSCSILogicalUnit Mon Jul 06 14:12:41 2009 +0200
+++ b/resources/OCF/iSCSILogicalUnit Mon Jul 06 14:12:45 2009 +0200
@@ -40,6 +40,11 @@
OCF_RESKEY_implementation_default="tgt"
fi
: ${OCF_RESKEY_implementation=${OCF_RESKEY_implementation_default}}
+
+# Use a default SCSI ID that is unique across the cluster, and
+# persistent in the event of resource migration
+OCF_RESKEY_scsi_id_default="${OCF_RESOURCE_INSTANCE}"
+: ${OCF_RESKEY_scsi_id=${OCF_RESKEY_scsi_id_default}}
#######################################################################

meta_data() {
@@ -97,7 +102,7 @@
The SCSI ID to be configured for this Logical Unit.
</longdesc>
<shortdesc lang="en">SCSI ID</shortdesc>
-<content type="string" />
+<content type="string" default="${OCF_RESKEY_scsi_id_default}"/>
</parameter>

<parameter name="scsi_sn" required="0" unique="0">
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


dejanmm at fastmail

Jul 7, 2009, 9:42 AM

Post #2 of 2 (571 views)
Permalink
Re: [PATCH] RA iSCSILogicalUnit: use $OCF_RESOURCE_INSTANCE as default SCSI ID [In reply to]

Applied.

Cheers,

Dejan

On Tue, Jul 07, 2009 at 11:45:27AM +0200, Florian Haas wrote:
> # HG changeset patch
> # User Florian Haas <florian.haas [at] linbit>
> # Date 1246882365 -7200
> # Node ID e6bb7b0fe3dd0aa13b41f616d888a309a6c63e29
> # Parent e71e3c165be9539e50a3137807952f6bed904e58
> RA iSCSILogicalUnit: use $OCF_RESOURCE_INSTANCE as default SCSI ID
>
> Some iSCSI initiators and other application rely on a device's SCSI ID
> to be persistent across target failovers. As some target
> implementations do not guarantee SCSI ID persistency across failovers,
> use $OCF_RESOURCE_INSTANCE as the default SCSI ID.
>
> diff -r e71e3c165be9 -r e6bb7b0fe3dd resources/OCF/iSCSILogicalUnit
> --- a/resources/OCF/iSCSILogicalUnit Mon Jul 06 14:12:41 2009 +0200
> +++ b/resources/OCF/iSCSILogicalUnit Mon Jul 06 14:12:45 2009 +0200
> @@ -40,6 +40,11 @@
> OCF_RESKEY_implementation_default="tgt"
> fi
> : ${OCF_RESKEY_implementation=${OCF_RESKEY_implementation_default}}
> +
> +# Use a default SCSI ID that is unique across the cluster, and
> +# persistent in the event of resource migration
> +OCF_RESKEY_scsi_id_default="${OCF_RESOURCE_INSTANCE}"
> +: ${OCF_RESKEY_scsi_id=${OCF_RESKEY_scsi_id_default}}
> #######################################################################
>
> meta_data() {
> @@ -97,7 +102,7 @@
> The SCSI ID to be configured for this Logical Unit.
> </longdesc>
> <shortdesc lang="en">SCSI ID</shortdesc>
> -<content type="string" />
> +<content type="string" default="${OCF_RESKEY_scsi_id_default}"/>
> </parameter>
>
> <parameter name="scsi_sn" required="0" unique="0">
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev [at] lists
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.