Mailing List Archive: Linux-HA: Dev

[patch] Improvement of log of pgsql RA

Index | Next | Previous | View Threaded

nakahira at intellilink

Jun 18, 2009, 10:52 PM

Post #1 of 14 (1271 views)
Permalink

[patch] Improvement of log of pgsql RA

Hello,

The pgsql RA includes the several confusing logs as follows
and I propose 3 patches to solve these problems.

1. When it takes time to start PostgreSQL, the "ERROR" level log
"PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
though the start of pgsql RA has succeeded.
It seems that "WARN" level is more appropriate than "ERROR".

pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.

2. In the start confirmation processing of pgsql RA, An unnecessary
"sleep 1" is executed though the start of PostgreSQL is confirmed
with pgsql_monitor().
3. In the stop processing of pgsql RA, An unnecessary log message
"PostgreSQL still hasn't stopped yet. Waiting..." is output to
the ha-debug though PostgreSQL has been stopped.

pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.

4. When failing in the execution of the psql command and
the pg_ctl command, the execution result of the command is not
recorded in the log file.

pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.

Best regards,
NAKAHIRA Kazutomo

--
----------------------------------------
NAKAHIRA Kazutomo
NTT DATA INTELLILINK CORPORATION
Open Source Business Unit
Software Services Integration Business Division

Attachments:

pgsql-ra-logging-1.patch (1.07 KB)

pgsql-ra-logging-2.patch (1.30 KB)

pgsql-ra-logging-3.patch (3.32 KB)

sergeyfd at gmail

Jun 22, 2009, 11:00 AM

Post #2 of 14 (1190 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

All these patches are OK with one exception. Construction $(command) isn't
supported by native Bourne shell so I'd propose changing it to `command`.
Attached is a patch that combines all 3 patches and fixes that
incompatibility issue.

Thanks for the patches.

2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>

> Hello,
>
> The pgsql RA includes the several confusing logs as follows
> and I propose 3 patches to solve these problems.
>
> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> though the start of pgsql RA has succeeded.
> It seems that "WARN" level is more appropriate than "ERROR".
>
> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>
> 2. In the start confirmation processing of pgsql RA, An unnecessary
> "sleep 1" is executed though the start of PostgreSQL is confirmed
> with pgsql_monitor().
> 3. In the stop processing of pgsql RA, An unnecessary log message
> "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> the ha-debug though PostgreSQL has been stopped.
>
> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>
> 4. When failing in the execution of the psql command and
> the pg_ctl command, the execution result of the command is not
> recorded in the log file.
>
> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>
> Best regards,
> NAKAHIRA Kazutomo
>
> --
> ----------------------------------------
> NAKAHIRA Kazutomo
> NTT DATA INTELLILINK CORPORATION
> Open Source Business Unit
> Software Services Integration Business Division
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
>

--
Serge Dubrouski.

sergeyfd at gmail

Jun 22, 2009, 11:24 AM

Post #3 of 14 (1190 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

And here is the patch.

On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:

> All these patches are OK with one exception. Construction $(command) isn't
> supported by native Bourne shell so I'd propose changing it to `command`.
> Attached is a patch that combines all 3 patches and fixes that
> incompatibility issue.
>
> Thanks for the patches.
>
> 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>
>> Hello,
>>
>> The pgsql RA includes the several confusing logs as follows
>> and I propose 3 patches to solve these problems.
>>
>> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>> "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>> though the start of pgsql RA has succeeded.
>> It seems that "WARN" level is more appropriate than "ERROR".
>>
>> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>>
>> 2. In the start confirmation processing of pgsql RA, An unnecessary
>> "sleep 1" is executed though the start of PostgreSQL is confirmed
>> with pgsql_monitor().
>> 3. In the stop processing of pgsql RA, An unnecessary log message
>> "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>> the ha-debug though PostgreSQL has been stopped.
>>
>> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>>
>> 4. When failing in the execution of the psql command and
>> the pg_ctl command, the execution result of the command is not
>> recorded in the log file.
>>
>> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>>
>> Best regards,
>> NAKAHIRA Kazutomo
>>
>> --
>> ----------------------------------------
>> NAKAHIRA Kazutomo
>> NTT DATA INTELLILINK CORPORATION
>> Open Source Business Unit
>> Software Services Integration Business Division
>>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>>
>>
>
>
> --
> Serge Dubrouski.
>

--
Serge Dubrouski.

Attachments:

pgsql.patch (4.22 KB)

dejanmm at fastmail

Jun 22, 2009, 11:33 AM

Post #4 of 14 (1187 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi Serge,

On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
> And here is the patch.

Looks like you were using a different version than what we have
in the hg repository:

[0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
patching file resources/OCF/pgsql
Hunk #1 FAILED at 194.
Hunk #3 FAILED at 253.
Hunk #4 succeeded at 297 with fuzz 1.
Hunk #5 FAILED at 308.
3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej

Or maybe I missed some patch. What I have as the last changeset
is this:

changeset: 11977:1cbc4c8c571f
user: Serge
date: Thu Jun 26 01:51:05 2008 +0200
summary: Low: pgsql RA: check for the non-supported action

Can you please see what's up.

Thanks,

Dejan

>
> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>
> > All these patches are OK with one exception. Construction $(command) isn't
> > supported by native Bourne shell so I'd propose changing it to `command`.
> > Attached is a patch that combines all 3 patches and fixes that
> > incompatibility issue.
> >
> > Thanks for the patches.
> >
> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
> >
> >> Hello,
> >>
> >> The pgsql RA includes the several confusing logs as follows
> >> and I propose 3 patches to solve these problems.
> >>
> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> >> "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> >> though the start of pgsql RA has succeeded.
> >> It seems that "WARN" level is more appropriate than "ERROR".
> >>
> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
> >>
> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
> >> "sleep 1" is executed though the start of PostgreSQL is confirmed
> >> with pgsql_monitor().
> >> 3. In the stop processing of pgsql RA, An unnecessary log message
> >> "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> >> the ha-debug though PostgreSQL has been stopped.
> >>
> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
> >>
> >> 4. When failing in the execution of the psql command and
> >> the pg_ctl command, the execution result of the command is not
> >> recorded in the log file.
> >>
> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
> >>
> >> Best regards,
> >> NAKAHIRA Kazutomo
> >>
> >> --
> >> ----------------------------------------
> >> NAKAHIRA Kazutomo
> >> NTT DATA INTELLILINK CORPORATION
> >> Open Source Business Unit
> >> Software Services Integration Business Division
> >>
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >>
> >>
> >
> >
> > --
> > Serge Dubrouski.
> >
>
>
>
> --
> Serge Dubrouski.

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

sergeyfd at gmail

Jun 22, 2009, 12:04 PM

Post #5 of 14 (1187 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Dejan -

Something is wrong with your repository. The patch is against the file
that comes with heartbeat-resources package and that file is
absolutely different from what you have in the repository. The file in
repository looks incorrect.

On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> Hi Serge,
>
> On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>> And here is the patch.
>
> Looks like you were using a different version than what we have
> in the hg repository:
>
> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> patching file resources/OCF/pgsql
> Hunk #1 FAILED at 194.
> Hunk #3 FAILED at 253.
> Hunk #4 succeeded at 297 with fuzz 1.
> Hunk #5 FAILED at 308.
> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>
> Or maybe I missed some patch. What I have as the last changeset
> is this:
>
> changeset: � 11977:1cbc4c8c571f
> user: � � � �Serge
> date: � � � �Thu Jun 26 01:51:05 2008 +0200
> summary: � � Low: pgsql RA: check for the non-supported action
>
> Can you please see what's up.
>
> Thanks,
>
> Dejan
>
>>
>> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>>
>> > All these patches are OK with one exception. Construction $(command) isn't
>> > supported by native Bourne shell so I'd propose changing it to `command`.
>> > Attached is a patch that combines all 3 patches and fixes that
>> > incompatibility issue.
>> >
>> > Thanks for the patches.
>> >
>> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>> >
>> >> Hello,
>> >>
>> >> The pgsql RA includes the several confusing logs as follows
>> >> and I propose 3 patches to solve these problems.
>> >>
>> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>> >> � "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>> >> � though the start of pgsql RA has succeeded.
>> >> � It seems that "WARN" level is more appropriate than "ERROR".
>> >>
>> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>> >>
>> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
>> >> � "sleep 1" is executed though the start of PostgreSQL is confirmed
>> >> � with pgsql_monitor().
>> >> 3. In the stop processing of pgsql RA, An unnecessary log message
>> >> � "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>> >> � the ha-debug though PostgreSQL has been stopped.
>> >>
>> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>> >>
>> >> 4. When failing in the execution of the psql command and
>> >> � the pg_ctl command, the execution result of the command is not
>> >> � recorded in the log file.
>> >>
>> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>> >>
>> >> Best regards,
>> >> NAKAHIRA Kazutomo
>> >>
>> >> --
>> >> ----------------------------------------
>> >> NAKAHIRA Kazutomo
>> >> NTT DATA INTELLILINK CORPORATION
>> >> Open Source Business Unit
>> >> Software Services Integration Business Division
>> >>
>> >> _______________________________________________________
>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> Home Page: http://linux-ha.org/
>> >>
>> >>
>> >
>> >
>> > --
>> > Serge Dubrouski.
>> >
>>
>>
>>
>> --
>> Serge Dubrouski.
>
>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

--
Serge Dubrouski.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

dejanmm at fastmail

Jun 22, 2009, 12:36 PM

Post #6 of 14 (1192 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi Serge,

On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
> Dejan -
>
> Something is wrong with your repository. The patch is against the file
> that comes with heartbeat-resources package and that file is
> absolutely different from what you have in the repository. The file in
> repository looks incorrect.

Just checked and what I have in my repository equals this:

http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql

Hmm, odd indeed. Which heartbeat-resources package do you have?

Thanks,

Dejan

> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> > Hi Serge,
> >
> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
> >> And here is the patch.
> >
> > Looks like you were using a different version than what we have
> > in the hg repository:
> >
> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> > patching file resources/OCF/pgsql
> > Hunk #1 FAILED at 194.
> > Hunk #3 FAILED at 253.
> > Hunk #4 succeeded at 297 with fuzz 1.
> > Hunk #5 FAILED at 308.
> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
> >
> > Or maybe I missed some patch. What I have as the last changeset
> > is this:
> >
> > changeset: ? 11977:1cbc4c8c571f
> > user: ? ? ? ?Serge
> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
> > summary: ? ? Low: pgsql RA: check for the non-supported action
> >
> > Can you please see what's up.
> >
> > Thanks,
> >
> > Dejan
> >
> >>
> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
> >>
> >> > All these patches are OK with one exception. Construction $(command) isn't
> >> > supported by native Bourne shell so I'd propose changing it to `command`.
> >> > Attached is a patch that combines all 3 patches and fixes that
> >> > incompatibility issue.
> >> >
> >> > Thanks for the patches.
> >> >
> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
> >> >
> >> >> Hello,
> >> >>
> >> >> The pgsql RA includes the several confusing logs as follows
> >> >> and I propose 3 patches to solve these problems.
> >> >>
> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> >> >> ? though the start of pgsql RA has succeeded.
> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
> >> >>
> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
> >> >>
> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
> >> >> ? with pgsql_monitor().
> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> >> >> ? the ha-debug though PostgreSQL has been stopped.
> >> >>
> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
> >> >>
> >> >> 4. When failing in the execution of the psql command and
> >> >> ? the pg_ctl command, the execution result of the command is not
> >> >> ? recorded in the log file.
> >> >>
> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
> >> >>
> >> >> Best regards,
> >> >> NAKAHIRA Kazutomo
> >> >>
> >> >> --
> >> >> ----------------------------------------
> >> >> NAKAHIRA Kazutomo
> >> >> NTT DATA INTELLILINK CORPORATION
> >> >> Open Source Business Unit
> >> >> Software Services Integration Business Division
> >> >>
> >> >> _______________________________________________________
> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> >> Home Page: http://linux-ha.org/
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > Serge Dubrouski.
> >> >
> >>
> >>
> >>
> >> --
> >> Serge Dubrouski.
> >
> >
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
>
>
> --
> Serge Dubrouski.
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

sergeyfd at gmail

Jun 22, 2009, 12:54 PM

Post #7 of 14 (1190 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

heartbeat-resources-2.99.2-8.1.i386

And this is the right one. I used it to create that patch and just
applied my patch against it without any problems:

[root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
patching file resources/OCF/pgsql
[root[at]fc-node1 pgsql]#

But the one that I see here:
http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
is the wrong one.

On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> Hi Serge,
>
> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
>> Dejan -
>>
>> Something is wrong with your repository. The patch is against the file
>> that comes with heartbeat-resources package and that file is
>> absolutely different from what you have in the repository. The file in
>> repository looks incorrect.
>
> Just checked and what I have in my repository equals this:
>
> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
>
> Hmm, odd indeed. Which heartbeat-resources package do you have?
>
> Thanks,
>
> Dejan
>
>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>> > Hi Serge,
>> >
>> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>> >> And here is the patch.
>> >
>> > Looks like you were using a different version than what we have
>> > in the hg repository:
>> >
>> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>> > patching file resources/OCF/pgsql
>> > Hunk #1 FAILED at 194.
>> > Hunk #3 FAILED at 253.
>> > Hunk #4 succeeded at 297 with fuzz 1.
>> > Hunk #5 FAILED at 308.
>> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>> >
>> > Or maybe I missed some patch. What I have as the last changeset
>> > is this:
>> >
>> > changeset: ? 11977:1cbc4c8c571f
>> > user: ? ? ? ?Serge
>> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
>> > summary: ? ? Low: pgsql RA: check for the non-supported action
>> >
>> > Can you please see what's up.
>> >
>> > Thanks,
>> >
>> > Dejan
>> >
>> >>
>> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>> >>
>> >> > All these patches are OK with one exception. Construction $(command) isn't
>> >> > supported by native Bourne shell so I'd propose changing it to `command`.
>> >> > Attached is a patch that combines all 3 patches and fixes that
>> >> > incompatibility issue.
>> >> >
>> >> > Thanks for the patches.
>> >> >
>> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>> >> >
>> >> >> Hello,
>> >> >>
>> >> >> The pgsql RA includes the several confusing logs as follows
>> >> >> and I propose 3 patches to solve these problems.
>> >> >>
>> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>> >> >> ? though the start of pgsql RA has succeeded.
>> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
>> >> >>
>> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>> >> >>
>> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
>> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
>> >> >> ? with pgsql_monitor().
>> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
>> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>> >> >> ? the ha-debug though PostgreSQL has been stopped.
>> >> >>
>> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>> >> >>
>> >> >> 4. When failing in the execution of the psql command and
>> >> >> ? the pg_ctl command, the execution result of the command is not
>> >> >> ? recorded in the log file.
>> >> >>
>> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>> >> >>
>> >> >> Best regards,
>> >> >> NAKAHIRA Kazutomo
>> >> >>
>> >> >> --
>> >> >> ----------------------------------------
>> >> >> NAKAHIRA Kazutomo
>> >> >> NTT DATA INTELLILINK CORPORATION
>> >> >> Open Source Business Unit
>> >> >> Software Services Integration Business Division
>> >> >>
>> >> >> _______________________________________________________
>> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> >> Home Page: http://linux-ha.org/
>> >> >>
>> >> >>
>> >> >
>> >> >
>> >> > --
>> >> > Serge Dubrouski.
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Serge Dubrouski.
>> >
>> >
>> >> _______________________________________________________
>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> Home Page: http://linux-ha.org/
>> >
>> > _______________________________________________________
>> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> > Home Page: http://linux-ha.org/
>> >
>>
>>
>>
>> --
>> Serge Dubrouski.
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

--
Serge Dubrouski.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

sergeyfd at gmail

Jun 22, 2009, 1:04 PM

Post #8 of 14 (1189 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Dejan -

Please try this one.

On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com> wrote:
> heartbeat-resources-2.99.2-8.1.i386
>
> And this is the right one. I used it to create that patch and just
> applied my patch against it without any problems:
>
> [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
> patching file resources/OCF/pgsql
> [root[at]fc-node1 pgsql]#
>
> But the one that I see here:
> http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
> is the wrong one.
>
> On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>> Hi Serge,
>>
>> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
>>> Dejan -
>>>
>>> Something is wrong with your repository. The patch is against the file
>>> that comes with heartbeat-resources package and that file is
>>> absolutely different from what you have in the repository. The file in
>>> repository looks incorrect.
>>
>> Just checked and what I have in my repository equals this:
>>
>> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
>>
>> Hmm, odd indeed. Which heartbeat-resources package do you have?
>>
>> Thanks,
>>
>> Dejan
>>
>>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>>> > Hi Serge,
>>> >
>>> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>>> >> And here is the patch.
>>> >
>>> > Looks like you were using a different version than what we have
>>> > in the hg repository:
>>> >
>>> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>>> > patching file resources/OCF/pgsql
>>> > Hunk #1 FAILED at 194.
>>> > Hunk #3 FAILED at 253.
>>> > Hunk #4 succeeded at 297 with fuzz 1.
>>> > Hunk #5 FAILED at 308.
>>> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>>> >
>>> > Or maybe I missed some patch. What I have as the last changeset
>>> > is this:
>>> >
>>> > changeset: ? 11977:1cbc4c8c571f
>>> > user: ? ? ? ?Serge
>>> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
>>> > summary: ? ? Low: pgsql RA: check for the non-supported action
>>> >
>>> > Can you please see what's up.
>>> >
>>> > Thanks,
>>> >
>>> > Dejan
>>> >
>>> >>
>>> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>>> >>
>>> >> > All these patches are OK with one exception. Construction $(command) isn't
>>> >> > supported by native Bourne shell so I'd propose changing it to `command`.
>>> >> > Attached is a patch that combines all 3 patches and fixes that
>>> >> > incompatibility issue.
>>> >> >
>>> >> > Thanks for the patches.
>>> >> >
>>> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>>> >> >
>>> >> >> Hello,
>>> >> >>
>>> >> >> The pgsql RA includes the several confusing logs as follows
>>> >> >> and I propose 3 patches to solve these problems.
>>> >> >>
>>> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>>> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>>> >> >> ? though the start of pgsql RA has succeeded.
>>> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
>>> >> >>
>>> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>>> >> >>
>>> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
>>> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
>>> >> >> ? with pgsql_monitor().
>>> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
>>> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>>> >> >> ? the ha-debug though PostgreSQL has been stopped.
>>> >> >>
>>> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>>> >> >>
>>> >> >> 4. When failing in the execution of the psql command and
>>> >> >> ? the pg_ctl command, the execution result of the command is not
>>> >> >> ? recorded in the log file.
>>> >> >>
>>> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>>> >> >>
>>> >> >> Best regards,
>>> >> >> NAKAHIRA Kazutomo
>>> >> >>
>>> >> >> --
>>> >> >> ----------------------------------------
>>> >> >> NAKAHIRA Kazutomo
>>> >> >> NTT DATA INTELLILINK CORPORATION
>>> >> >> Open Source Business Unit
>>> >> >> Software Services Integration Business Division
>>> >> >>
>>> >> >> _______________________________________________________
>>> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> >> >> Home Page: http://linux-ha.org/
>>> >> >>
>>> >> >>
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Serge Dubrouski.
>>> >> >
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Serge Dubrouski.
>>> >
>>> >
>>> >> _______________________________________________________
>>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> >> Home Page: http://linux-ha.org/
>>> >
>>> > _______________________________________________________
>>> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> > Home Page: http://linux-ha.org/
>>> >
>>>
>>>
>>>
>>> --
>>> Serge Dubrouski.
>>> _______________________________________________________
>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> Home Page: http://linux-ha.org/
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>>
>
>
>
> --
> Serge Dubrouski.
>

--
Serge Dubrouski.

Attachments:

pgsql.patch (4.23 KB)

dejanmm at fastmail

Jun 22, 2009, 2:52 PM

Post #9 of 14 (1178 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi,

On Mon, Jun 22, 2009 at 01:54:44PM -0600, Serge Dubrouski wrote:
> heartbeat-resources-2.99.2-8.1.i386

Just checked this

http://download.opensuse.org/repositories/server:/ha-clustering/openSUSE_11.1/i586/heartbeat-resources-2.99.2-8.1.i586.rpm

and pgsql is exactly the same as the hg tip.

> And this is the right one. I used it to create that patch and just
> applied my patch against it without any problems:
>
> [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
> patching file resources/OCF/pgsql
> [root[at]fc-node1 pgsql]#
>
> But the one that I see here:
> http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
> is the wrong one.

Yes, that one is old:

[0]rondo:work > hg log -r e5c2b1d937ac
changeset: 11361:e5c2b1d937ac
user: Dejan Muhamedagic <dejan[at]hello-penguin.com>
date: Mon Oct 15 10:38:34 2007 +0200
summary: RA mysql, pgsql: use getent(1) instead of /etc/passwd (thanks to Raoul Bhatia)

Thanks,

Dejan

> On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> > Hi Serge,
> >
> > On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
> >> Dejan -
> >>
> >> Something is wrong with your repository. The patch is against the file
> >> that comes with heartbeat-resources package and that file is
> >> absolutely different from what you have in the repository. The file in
> >> repository looks incorrect.
> >
> > Just checked and what I have in my repository equals this:
> >
> > http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
> >
> > Hmm, odd indeed. Which heartbeat-resources package do you have?
> >
> > Thanks,
> >
> > Dejan
> >
> >> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> >> > Hi Serge,
> >> >
> >> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
> >> >> And here is the patch.
> >> >
> >> > Looks like you were using a different version than what we have
> >> > in the hg repository:
> >> >
> >> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> >> > patching file resources/OCF/pgsql
> >> > Hunk #1 FAILED at 194.
> >> > Hunk #3 FAILED at 253.
> >> > Hunk #4 succeeded at 297 with fuzz 1.
> >> > Hunk #5 FAILED at 308.
> >> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
> >> >
> >> > Or maybe I missed some patch. What I have as the last changeset
> >> > is this:
> >> >
> >> > changeset: ? 11977:1cbc4c8c571f
> >> > user: ? ? ? ?Serge
> >> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
> >> > summary: ? ? Low: pgsql RA: check for the non-supported action
> >> >
> >> > Can you please see what's up.
> >> >
> >> > Thanks,
> >> >
> >> > Dejan
> >> >
> >> >>
> >> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
> >> >>
> >> >> > All these patches are OK with one exception. Construction $(command) isn't
> >> >> > supported by native Bourne shell so I'd propose changing it to `command`.
> >> >> > Attached is a patch that combines all 3 patches and fixes that
> >> >> > incompatibility issue.
> >> >> >
> >> >> > Thanks for the patches.
> >> >> >
> >> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
> >> >> >
> >> >> >> Hello,
> >> >> >>
> >> >> >> The pgsql RA includes the several confusing logs as follows
> >> >> >> and I propose 3 patches to solve these problems.
> >> >> >>
> >> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> >> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> >> >> >> ? though the start of pgsql RA has succeeded.
> >> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
> >> >> >>
> >> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
> >> >> >>
> >> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
> >> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
> >> >> >> ? with pgsql_monitor().
> >> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
> >> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> >> >> >> ? the ha-debug though PostgreSQL has been stopped.
> >> >> >>
> >> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
> >> >> >>
> >> >> >> 4. When failing in the execution of the psql command and
> >> >> >> ? the pg_ctl command, the execution result of the command is not
> >> >> >> ? recorded in the log file.
> >> >> >>
> >> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
> >> >> >>
> >> >> >> Best regards,
> >> >> >> NAKAHIRA Kazutomo
> >> >> >>
> >> >> >> --
> >> >> >> ----------------------------------------
> >> >> >> NAKAHIRA Kazutomo
> >> >> >> NTT DATA INTELLILINK CORPORATION
> >> >> >> Open Source Business Unit
> >> >> >> Software Services Integration Business Division
> >> >> >>
> >> >> >> _______________________________________________________
> >> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> >> >> Home Page: http://linux-ha.org/
> >> >> >>
> >> >> >>
> >> >> >
> >> >> >
> >> >> > --
> >> >> > Serge Dubrouski.
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Serge Dubrouski.
> >> >
> >> >
> >> >> _______________________________________________________
> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> >> Home Page: http://linux-ha.org/
> >> >
> >> > _______________________________________________________
> >> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> > Home Page: http://linux-ha.org/
> >> >
> >>
> >>
> >>
> >> --
> >> Serge Dubrouski.
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
>
>
>
> --
> Serge Dubrouski.
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

dejanmm at fastmail

Jun 22, 2009, 2:54 PM

Post #10 of 14 (1180 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi Serge,

On Mon, Jun 22, 2009 at 02:04:30PM -0600, Serge Dubrouski wrote:
> Dejan -
>
> Please try this one.

No luck:

[0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
patching file resources/OCF/pgsql
Hunk #1 FAILED at 194.
Hunk #3 FAILED at 253.
Hunk #4 succeeded at 297 with fuzz 1.
Hunk #5 FAILED at 308.
3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej

If you're absolutely sure that your copy of pgsql is good, post
it and we'll see how does it differ from the current version in
the hg repository.

Thanks,

Dejan

> On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com> wrote:
> > heartbeat-resources-2.99.2-8.1.i386
> >
> > And this is the right one. I used it to create that patch and just
> > applied my patch against it without any problems:
> >
> > [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
> > patching file resources/OCF/pgsql
> > [root[at]fc-node1 pgsql]#
> >
> > But the one that I see here:
> > http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
> > is the wrong one.
> >
> > On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> >> Hi Serge,
> >>
> >> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
> >>> Dejan -
> >>>
> >>> Something is wrong with your repository. The patch is against the file
> >>> that comes with heartbeat-resources package and that file is
> >>> absolutely different from what you have in the repository. The file in
> >>> repository looks incorrect.
> >>
> >> Just checked and what I have in my repository equals this:
> >>
> >> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
> >>
> >> Hmm, odd indeed. Which heartbeat-resources package do you have?
> >>
> >> Thanks,
> >>
> >> Dejan
> >>
> >>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> >>> > Hi Serge,
> >>> >
> >>> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
> >>> >> And here is the patch.
> >>> >
> >>> > Looks like you were using a different version than what we have
> >>> > in the hg repository:
> >>> >
> >>> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> >>> > patching file resources/OCF/pgsql
> >>> > Hunk #1 FAILED at 194.
> >>> > Hunk #3 FAILED at 253.
> >>> > Hunk #4 succeeded at 297 with fuzz 1.
> >>> > Hunk #5 FAILED at 308.
> >>> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
> >>> >
> >>> > Or maybe I missed some patch. What I have as the last changeset
> >>> > is this:
> >>> >
> >>> > changeset: ? 11977:1cbc4c8c571f
> >>> > user: ? ? ? ?Serge
> >>> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
> >>> > summary: ? ? Low: pgsql RA: check for the non-supported action
> >>> >
> >>> > Can you please see what's up.
> >>> >
> >>> > Thanks,
> >>> >
> >>> > Dejan
> >>> >
> >>> >>
> >>> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
> >>> >>
> >>> >> > All these patches are OK with one exception. Construction $(command) isn't
> >>> >> > supported by native Bourne shell so I'd propose changing it to `command`.
> >>> >> > Attached is a patch that combines all 3 patches and fixes that
> >>> >> > incompatibility issue.
> >>> >> >
> >>> >> > Thanks for the patches.
> >>> >> >
> >>> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
> >>> >> >
> >>> >> >> Hello,
> >>> >> >>
> >>> >> >> The pgsql RA includes the several confusing logs as follows
> >>> >> >> and I propose 3 patches to solve these problems.
> >>> >> >>
> >>> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> >>> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> >>> >> >> ? though the start of pgsql RA has succeeded.
> >>> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
> >>> >> >>
> >>> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
> >>> >> >>
> >>> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
> >>> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
> >>> >> >> ? with pgsql_monitor().
> >>> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
> >>> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> >>> >> >> ? the ha-debug though PostgreSQL has been stopped.
> >>> >> >>
> >>> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
> >>> >> >>
> >>> >> >> 4. When failing in the execution of the psql command and
> >>> >> >> ? the pg_ctl command, the execution result of the command is not
> >>> >> >> ? recorded in the log file.
> >>> >> >>
> >>> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
> >>> >> >>
> >>> >> >> Best regards,
> >>> >> >> NAKAHIRA Kazutomo
> >>> >> >>
> >>> >> >> --
> >>> >> >> ----------------------------------------
> >>> >> >> NAKAHIRA Kazutomo
> >>> >> >> NTT DATA INTELLILINK CORPORATION
> >>> >> >> Open Source Business Unit
> >>> >> >> Software Services Integration Business Division
> >>> >> >>
> >>> >> >> _______________________________________________________
> >>> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>> >> >> Home Page: http://linux-ha.org/
> >>> >> >>
> >>> >> >>
> >>> >> >
> >>> >> >
> >>> >> > --
> >>> >> > Serge Dubrouski.
> >>> >> >
> >>> >>
> >>> >>
> >>> >>
> >>> >> --
> >>> >> Serge Dubrouski.
> >>> >
> >>> >
> >>> >> _______________________________________________________
> >>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>> >> Home Page: http://linux-ha.org/
> >>> >
> >>> > _______________________________________________________
> >>> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>> > Home Page: http://linux-ha.org/
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Serge Dubrouski.
> >>> _______________________________________________________
> >>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>> Home Page: http://linux-ha.org/
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >>
> >
> >
> >
> > --
> > Serge Dubrouski.
> >
>
>
>
> --
> Serge Dubrouski.

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

sergeyfd at gmail

Jun 22, 2009, 3:04 PM

Post #11 of 14 (1178 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Here is the one with applied patch.

On Mon, Jun 22, 2009 at 3:54 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> Hi Serge,
>
> On Mon, Jun 22, 2009 at 02:04:30PM -0600, Serge Dubrouski wrote:
>> Dejan -
>>
>> Please try this one.
>
> No luck:
>
> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> patching file resources/OCF/pgsql
> Hunk #1 FAILED at 194.
> Hunk #3 FAILED at 253.
> Hunk #4 succeeded at 297 with fuzz 1.
> Hunk #5 FAILED at 308.
> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>
> If you're absolutely sure that your copy of pgsql is good, post
> it and we'll see how does it differ from the current version in
> the hg repository.
>
> Thanks,
>
> Dejan
>
>> On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com> wrote:
>> > heartbeat-resources-2.99.2-8.1.i386
>> >
>> > And this is the right one. I used it to create that patch and just
>> > applied my patch against it without any problems:
>> >
>> > [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
>> > patching file resources/OCF/pgsql
>> > [root[at]fc-node1 pgsql]#
>> >
>> > But the one that I see here:
>> > http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
>> > is the wrong one.
>> >
>> > On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>> >> Hi Serge,
>> >>
>> >> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
>> >>> Dejan -
>> >>>
>> >>> Something is wrong with your repository. The patch is against the file
>> >>> that comes with heartbeat-resources package and that file is
>> >>> absolutely different from what you have in the repository. The file in
>> >>> repository looks incorrect.
>> >>
>> >> Just checked and what I have in my repository equals this:
>> >>
>> >> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
>> >>
>> >> Hmm, odd indeed. Which heartbeat-resources package do you have?
>> >>
>> >> Thanks,
>> >>
>> >> Dejan
>> >>
>> >>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>> >>> > Hi Serge,
>> >>> >
>> >>> > On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>> >>> >> And here is the patch.
>> >>> >
>> >>> > Looks like you were using a different version than what we have
>> >>> > in the hg repository:
>> >>> >
>> >>> > [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>> >>> > patching file resources/OCF/pgsql
>> >>> > Hunk #1 FAILED at 194.
>> >>> > Hunk #3 FAILED at 253.
>> >>> > Hunk #4 succeeded at 297 with fuzz 1.
>> >>> > Hunk #5 FAILED at 308.
>> >>> > 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>> >>> >
>> >>> > Or maybe I missed some patch. What I have as the last changeset
>> >>> > is this:
>> >>> >
>> >>> > changeset: ? 11977:1cbc4c8c571f
>> >>> > user: ? ? ? ?Serge
>> >>> > date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
>> >>> > summary: ? ? Low: pgsql RA: check for the non-supported action
>> >>> >
>> >>> > Can you please see what's up.
>> >>> >
>> >>> > Thanks,
>> >>> >
>> >>> > Dejan
>> >>> >
>> >>> >>
>> >>> >> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>> >>> >>
>> >>> >> > All these patches are OK with one exception. Construction $(command) isn't
>> >>> >> > supported by native Bourne shell so I'd propose changing it to `command`.
>> >>> >> > Attached is a patch that combines all 3 patches and fixes that
>> >>> >> > incompatibility issue.
>> >>> >> >
>> >>> >> > Thanks for the patches.
>> >>> >> >
>> >>> >> > 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>> >>> >> >
>> >>> >> >> Hello,
>> >>> >> >>
>> >>> >> >> The pgsql RA includes the several confusing logs as follows
>> >>> >> >> and I propose 3 patches to solve these problems.
>> >>> >> >>
>> >>> >> >> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>> >>> >> >> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>> >>> >> >> ? though the start of pgsql RA has succeeded.
>> >>> >> >> ? It seems that "WARN" level is more appropriate than "ERROR".
>> >>> >> >>
>> >>> >> >> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>> >>> >> >>
>> >>> >> >> 2. In the start confirmation processing of pgsql RA, An unnecessary
>> >>> >> >> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
>> >>> >> >> ? with pgsql_monitor().
>> >>> >> >> 3. In the stop processing of pgsql RA, An unnecessary log message
>> >>> >> >> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>> >>> >> >> ? the ha-debug though PostgreSQL has been stopped.
>> >>> >> >>
>> >>> >> >> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>> >>> >> >>
>> >>> >> >> 4. When failing in the execution of the psql command and
>> >>> >> >> ? the pg_ctl command, the execution result of the command is not
>> >>> >> >> ? recorded in the log file.
>> >>> >> >>
>> >>> >> >> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>> >>> >> >>
>> >>> >> >> Best regards,
>> >>> >> >> NAKAHIRA Kazutomo
>> >>> >> >>
>> >>> >> >> --
>> >>> >> >> ----------------------------------------
>> >>> >> >> NAKAHIRA Kazutomo
>> >>> >> >> NTT DATA INTELLILINK CORPORATION
>> >>> >> >> Open Source Business Unit
>> >>> >> >> Software Services Integration Business Division
>> >>> >> >>
>> >>> >> >> _______________________________________________________
>> >>> >> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >>> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >>> >> >> Home Page: http://linux-ha.org/
>> >>> >> >>
>> >>> >> >>
>> >>> >> >
>> >>> >> >
>> >>> >> > --
>> >>> >> > Serge Dubrouski.
>> >>> >> >
>> >>> >>
>> >>> >>
>> >>> >>
>> >>> >> --
>> >>> >> Serge Dubrouski.
>> >>> >
>> >>> >
>> >>> >> _______________________________________________________
>> >>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >>> >> Home Page: http://linux-ha.org/
>> >>> >
>> >>> > _______________________________________________________
>> >>> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >>> > Home Page: http://linux-ha.org/
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Serge Dubrouski.
>> >>> _______________________________________________________
>> >>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >>> Home Page: http://linux-ha.org/
>> >> _______________________________________________________
>> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> Home Page: http://linux-ha.org/
>> >>
>> >
>> >
>> >
>> > --
>> > Serge Dubrouski.
>> >
>>
>>
>>
>> --
>> Serge Dubrouski.
>
>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

--
Serge Dubrouski.

Attachments:

pgsql (11.4 KB)

nakahira at intellilink

Jun 22, 2009, 11:36 PM

Post #12 of 14 (1168 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi, Serge and Dejan

Thank you for being interested in my patches.

I remade the patch that based on the latest Linux-HA-Dev.
(http://hg.linux-ha.org/dev/rev/f9f9567ee692)

Best regards,
NAKAHIRA Kazutomo

Serge Dubrouski wrote:
> Here is the one with applied patch.
>
> On Mon, Jun 22, 2009 at 3:54 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>> Hi Serge,
>>
>> On Mon, Jun 22, 2009 at 02:04:30PM -0600, Serge Dubrouski wrote:
>>> Dejan -
>>>
>>> Please try this one.
>> No luck:
>>
>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>> patching file resources/OCF/pgsql
>> Hunk #1 FAILED at 194.
>> Hunk #3 FAILED at 253.
>> Hunk #4 succeeded at 297 with fuzz 1.
>> Hunk #5 FAILED at 308.
>> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>>
>> If you're absolutely sure that your copy of pgsql is good, post
>> it and we'll see how does it differ from the current version in
>> the hg repository.
>>
>> Thanks,
>>
>> Dejan
>>
>>> On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com> wrote:
>>>> heartbeat-resources-2.99.2-8.1.i386
>>>>
>>>> And this is the right one. I used it to create that patch and just
>>>> applied my patch against it without any problems:
>>>>
>>>> [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
>>>> patching file resources/OCF/pgsql
>>>> [root[at]fc-node1 pgsql]#
>>>>
>>>> But the one that I see here:
>>>> http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
>>>> is the wrong one.
>>>>
>>>> On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>>>>> Hi Serge,
>>>>>
>>>>> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
>>>>>> Dejan -
>>>>>>
>>>>>> Something is wrong with your repository. The patch is against the file
>>>>>> that comes with heartbeat-resources package and that file is
>>>>>> absolutely different from what you have in the repository. The file in
>>>>>> repository looks incorrect.
>>>>> Just checked and what I have in my repository equals this:
>>>>>
>>>>> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
>>>>>
>>>>> Hmm, odd indeed. Which heartbeat-resources package do you have?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Dejan
>>>>>
>>>>>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>>>>>>> Hi Serge,
>>>>>>>
>>>>>>> On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>>>>>>>> And here is the patch.
>>>>>>> Looks like you were using a different version than what we have
>>>>>>> in the hg repository:
>>>>>>>
>>>>>>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>>>>>>> patching file resources/OCF/pgsql
>>>>>>> Hunk #1 FAILED at 194.
>>>>>>> Hunk #3 FAILED at 253.
>>>>>>> Hunk #4 succeeded at 297 with fuzz 1.
>>>>>>> Hunk #5 FAILED at 308.
>>>>>>> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>>>>>>>
>>>>>>> Or maybe I missed some patch. What I have as the last changeset
>>>>>>> is this:
>>>>>>>
>>>>>>> changeset: ? 11977:1cbc4c8c571f
>>>>>>> user: ? ? ? ?Serge
>>>>>>> date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
>>>>>>> summary: ? ? Low: pgsql RA: check for the non-supported action
>>>>>>>
>>>>>>> Can you please see what's up.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Dejan
>>>>>>>
>>>>>>>> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski <sergeyfd[at]gmail.com>wrote:
>>>>>>>>
>>>>>>>>> All these patches are OK with one exception. Construction $(command) isn't
>>>>>>>>> supported by native Bourne shell so I'd propose changing it to `command`.
>>>>>>>>> Attached is a patch that combines all 3 patches and fixes that
>>>>>>>>> incompatibility issue.
>>>>>>>>>
>>>>>>>>> Thanks for the patches.
>>>>>>>>>
>>>>>>>>> 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> The pgsql RA includes the several confusing logs as follows
>>>>>>>>>> and I propose 3 patches to solve these problems.
>>>>>>>>>>
>>>>>>>>>> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>>>>>>>>>> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>>>>>>>>>> ? though the start of pgsql RA has succeeded.
>>>>>>>>>> ? It seems that "WARN" level is more appropriate than "ERROR".
>>>>>>>>>>
>>>>>>>>>> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>>>>>>>>>>
>>>>>>>>>> 2. In the start confirmation processing of pgsql RA, An unnecessary
>>>>>>>>>> ? "sleep 1" is executed though the start of PostgreSQL is confirmed
>>>>>>>>>> ? with pgsql_monitor().
>>>>>>>>>> 3. In the stop processing of pgsql RA, An unnecessary log message
>>>>>>>>>> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>>>>>>>>>> ? the ha-debug though PostgreSQL has been stopped.
>>>>>>>>>>
>>>>>>>>>> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem.
>>>>>>>>>>
>>>>>>>>>> 4. When failing in the execution of the psql command and
>>>>>>>>>> ? the pg_ctl command, the execution result of the command is not
>>>>>>>>>> ? recorded in the log file.
>>>>>>>>>>
>>>>>>>>>> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>>>>>>>>>>
>>>>>>>>>> Best regards,
>>>>>>>>>> NAKAHIRA Kazutomo
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> ----------------------------------------
>>>>>>>>>> NAKAHIRA Kazutomo
>>>>>>>>>> NTT DATA INTELLILINK CORPORATION
>>>>>>>>>> Open Source Business Unit
>>>>>>>>>> Software Services Integration Business Division
>>>>>>>>>>
>>>>>>>>>> _______________________________________________________
>>>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>>>>> Home Page: http://linux-ha.org/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Serge Dubrouski.
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Serge Dubrouski.
>>>>>>>
>>>>>>>> _______________________________________________________
>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>>> Home Page: http://linux-ha.org/
>>>>>>> _______________________________________________________
>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>> Home Page: http://linux-ha.org/
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Serge Dubrouski.
>>>>>> _______________________________________________________
>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>> Home Page: http://linux-ha.org/
>>>>> _______________________________________________________
>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>> Home Page: http://linux-ha.org/
>>>>>
>>>>
>>>>
>>>> --
>>>> Serge Dubrouski.
>>>>
>>>
>>>
>>> --
>>> Serge Dubrouski.
>>
>>> _______________________________________________________
>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> Home Page: http://linux-ha.org/
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>>
>
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

--
----------------------------------------
NAKAHIRA Kazutomo
NTT DATA INTELLILINK CORPORATION
Open Source Business Unit
Software Services Integration Business Division

Attachments:

pgsql.patch (4.34 KB)

sergeyfd at gmail

Jun 29, 2009, 10:15 AM

Post #13 of 14 (968 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Dejan -

Were you able to commit it?

On Tue, Jun 23, 2009 at 12:36 AM, NAKAHIRA
Kazutomo<nakahira[at]intellilink.co.jp> wrote:
> Hi, Serge and Dejan
>
> Thank you for being interested in my patches.
>
> I remade the patch that based on the latest Linux-HA-Dev.
> (http://hg.linux-ha.org/dev/rev/f9f9567ee692)
>
> Best regards,
> NAKAHIRA Kazutomo
>
> Serge Dubrouski wrote:
>>
>> Here is the one with applied patch.
>>
>> On Mon, Jun 22, 2009 at 3:54 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm>
>> wrote:
>>>
>>> Hi Serge,
>>>
>>> On Mon, Jun 22, 2009 at 02:04:30PM -0600, Serge Dubrouski wrote:
>>>>
>>>> Dejan -
>>>>
>>>> Please try this one.
>>>
>>> No luck:
>>>
>>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>>> patching file resources/OCF/pgsql
>>> Hunk #1 FAILED at 194.
>>> Hunk #3 FAILED at 253.
>>> Hunk #4 succeeded at 297 with fuzz 1.
>>> Hunk #5 FAILED at 308.
>>> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
>>>
>>> If you're absolutely sure that your copy of pgsql is good, post
>>> it and we'll see how does it differ from the current version in
>>> the hg repository.
>>>
>>> Thanks,
>>>
>>> Dejan
>>>
>>>> On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com>
>>>> wrote:
>>>>>
>>>>> heartbeat-resources-2.99.2-8.1.i386
>>>>>
>>>>> And this is the right one. I used it to create that patch and just
>>>>> applied my patch against it without any problems:
>>>>>
>>>>> [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
>>>>> patching file resources/OCF/pgsql
>>>>> [root[at]fc-node1 pgsql]#
>>>>>
>>>>> But the one that I see here:
>>>>>
>>>>> http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
>>>>> is the wrong one.
>>>>>
>>>>> On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm>
>>>>> wrote:
>>>>>>
>>>>>> Hi Serge,
>>>>>>
>>>>>> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
>>>>>>>
>>>>>>> Dejan -
>>>>>>>
>>>>>>> Something is wrong with your repository. The patch is against the
>>>>>>> file
>>>>>>> that comes with heartbeat-resources package and that file is
>>>>>>> absolutely different from what you have in the repository. The file
>>>>>>> in
>>>>>>> repository looks incorrect.
>>>>>>
>>>>>> Just checked and what I have in my repository equals this:
>>>>>>
>>>>>> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
>>>>>>
>>>>>> Hmm, odd indeed. Which heartbeat-resources package do you have?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Dejan
>>>>>>
>>>>>>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan
>>>>>>> Muhamedagic<dejanmm[at]fastmail.fm> wrote:
>>>>>>>>
>>>>>>>> Hi Serge,
>>>>>>>>
>>>>>>>> On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
>>>>>>>>>
>>>>>>>>> And here is the patch.
>>>>>>>>
>>>>>>>> Looks like you were using a different version than what we have
>>>>>>>> in the hg repository:
>>>>>>>>
>>>>>>>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
>>>>>>>> patching file resources/OCF/pgsql
>>>>>>>> Hunk #1 FAILED at 194.
>>>>>>>> Hunk #3 FAILED at 253.
>>>>>>>> Hunk #4 succeeded at 297 with fuzz 1.
>>>>>>>> Hunk #5 FAILED at 308.
>>>>>>>> 3 out of 5 hunks FAILED -- saving rejects to file
>>>>>>>> resources/OCF/pgsql.rej
>>>>>>>>
>>>>>>>> Or maybe I missed some patch. What I have as the last changeset
>>>>>>>> is this:
>>>>>>>>
>>>>>>>> changeset: ? 11977:1cbc4c8c571f
>>>>>>>> user: ? ? ? ?Serge
>>>>>>>> date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
>>>>>>>> summary: ? ? Low: pgsql RA: check for the non-supported action
>>>>>>>>
>>>>>>>> Can you please see what's up.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Dejan
>>>>>>>>
>>>>>>>>> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski
>>>>>>>>> <sergeyfd[at]gmail.com>wrote:
>>>>>>>>>
>>>>>>>>>> All these patches are OK with one exception. Construction
>>>>>>>>>> $(command) isn't
>>>>>>>>>> supported by native Bourne shell so I'd propose changing it to
>>>>>>>>>> `command`.
>>>>>>>>>> Attached is a patch that combines all 3 patches and fixes that
>>>>>>>>>> incompatibility issue.
>>>>>>>>>>
>>>>>>>>>> Thanks for the patches.
>>>>>>>>>>
>>>>>>>>>> 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
>>>>>>>>>>
>>>>>>>>>>> Hello,
>>>>>>>>>>>
>>>>>>>>>>> The pgsql RA includes the several confusing logs as follows
>>>>>>>>>>> and I propose 3 patches to solve these problems.
>>>>>>>>>>>
>>>>>>>>>>> 1. When it takes time to start PostgreSQL, the "ERROR" level log
>>>>>>>>>>> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
>>>>>>>>>>> ? though the start of pgsql RA has succeeded.
>>>>>>>>>>> ? It seems that "WARN" level is more appropriate than "ERROR".
>>>>>>>>>>>
>>>>>>>>>>> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
>>>>>>>>>>>
>>>>>>>>>>> 2. In the start confirmation processing of pgsql RA, An
>>>>>>>>>>> unnecessary
>>>>>>>>>>> ? "sleep 1" is executed though the start of PostgreSQL is
>>>>>>>>>>> confirmed
>>>>>>>>>>> ? with pgsql_monitor().
>>>>>>>>>>> 3. In the stop processing of pgsql RA, An unnecessary log message
>>>>>>>>>>> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
>>>>>>>>>>> ? the ha-debug though PostgreSQL has been stopped.
>>>>>>>>>>>
>>>>>>>>>>> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3
>>>>>>>>>>> problem.
>>>>>>>>>>>
>>>>>>>>>>> 4. When failing in the execution of the psql command and
>>>>>>>>>>> ? the pg_ctl command, the execution result of the command is not
>>>>>>>>>>> ? recorded in the log file.
>>>>>>>>>>>
>>>>>>>>>>> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
>>>>>>>>>>>
>>>>>>>>>>> Best regards,
>>>>>>>>>>> NAKAHIRA Kazutomo
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> ----------------------------------------
>>>>>>>>>>> NAKAHIRA Kazutomo
>>>>>>>>>>> NTT DATA INTELLILINK CORPORATION
>>>>>>>>>>> Open Source Business Unit
>>>>>>>>>>> Software Services Integration Business Division
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________________
>>>>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>>>>>> Home Page: http://linux-ha.org/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Serge Dubrouski.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Serge Dubrouski.
>>>>>>>>
>>>>>>>>> _______________________________________________________
>>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>>>> Home Page: http://linux-ha.org/
>>>>>>>>
>>>>>>>> _______________________________________________________
>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>>> Home Page: http://linux-ha.org/
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Serge Dubrouski.
>>>>>>> _______________________________________________________
>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>>> Home Page: http://linux-ha.org/
>>>>>>
>>>>>> _______________________________________________________
>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>>>> Home Page: http://linux-ha.org/
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Serge Dubrouski.
>>>>>
>>>>
>>>>
>>>> --
>>>> Serge Dubrouski.
>>>
>>>> _______________________________________________________
>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>>> Home Page: http://linux-ha.org/
>>>
>>> _______________________________________________________
>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>>> Home Page: http://linux-ha.org/
>>>
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
>
> --
> ----------------------------------------
> NAKAHIRA Kazutomo
> NTT DATA INTELLILINK CORPORATION
> Open Source Business Unit
> Software Services Integration Business Division
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
>

--
Serge Dubrouski.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

dejanmm at fastmail

Jun 30, 2009, 3:03 AM

Post #14 of 14 (950 views)
Permalink

Re: [patch] Improvement of log of pgsql RA [In reply to]

Hi Serge,

On Mon, Jun 29, 2009 at 11:15:47AM -0600, Serge Dubrouski wrote:
> Dejan -
>
> Were you able to commit it?

Yes, applied now.

Cheers,

Dejan

>
> On Tue, Jun 23, 2009 at 12:36 AM, NAKAHIRA
> Kazutomo<nakahira[at]intellilink.co.jp> wrote:
> > Hi, Serge and Dejan
> >
> > Thank you for being interested in my patches.
> >
> > I remade the patch that based on the latest Linux-HA-Dev.
> > (http://hg.linux-ha.org/dev/rev/f9f9567ee692)
> >
> > Best regards,
> > NAKAHIRA Kazutomo
> >
> > Serge Dubrouski wrote:
> >>
> >> Here is the one with applied patch.
> >>
> >> On Mon, Jun 22, 2009 at 3:54 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm>
> >> wrote:
> >>>
> >>> Hi Serge,
> >>>
> >>> On Mon, Jun 22, 2009 at 02:04:30PM -0600, Serge Dubrouski wrote:
> >>>>
> >>>> Dejan -
> >>>>
> >>>> Please try this one.
> >>>
> >>> No luck:
> >>>
> >>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> >>> patching file resources/OCF/pgsql
> >>> Hunk #1 FAILED at 194.
> >>> Hunk #3 FAILED at 253.
> >>> Hunk #4 succeeded at 297 with fuzz 1.
> >>> Hunk #5 FAILED at 308.
> >>> 3 out of 5 hunks FAILED -- saving rejects to file resources/OCF/pgsql.rej
> >>>
> >>> If you're absolutely sure that your copy of pgsql is good, post
> >>> it and we'll see how does it differ from the current version in
> >>> the hg repository.
> >>>
> >>> Thanks,
> >>>
> >>> Dejan
> >>>
> >>>> On Mon, Jun 22, 2009 at 1:54 PM, Serge Dubrouski<sergeyfd[at]gmail.com>
> >>>> wrote:
> >>>>>
> >>>>> heartbeat-resources-2.99.2-8.1.i386
> >>>>>
> >>>>> And this is the right one. I used it to create that patch and just
> >>>>> applied my patch against it without any problems:
> >>>>>
> >>>>> [root[at]fc-node1 pgsql]# patch resources/OCF/pgsql pgsql.patch
> >>>>> patching file resources/OCF/pgsql
> >>>>> [root[at]fc-node1 pgsql]#
> >>>>>
> >>>>> But the one that I see here:
> >>>>>
> >>>>> http://hg.clusterlabs.org/pacemaker/stable-1.0/file/e5c2b1d937ac/resources/OCF/pgsql
> >>>>> is the wrong one.
> >>>>>
> >>>>> On Mon, Jun 22, 2009 at 1:36 PM, Dejan Muhamedagic<dejanmm[at]fastmail.fm>
> >>>>> wrote:
> >>>>>>
> >>>>>> Hi Serge,
> >>>>>>
> >>>>>> On Mon, Jun 22, 2009 at 01:04:23PM -0600, Serge Dubrouski wrote:
> >>>>>>>
> >>>>>>> Dejan -
> >>>>>>>
> >>>>>>> Something is wrong with your repository. The patch is against the
> >>>>>>> file
> >>>>>>> that comes with heartbeat-resources package and that file is
> >>>>>>> absolutely different from what you have in the repository. The file
> >>>>>>> in
> >>>>>>> repository looks incorrect.
> >>>>>>
> >>>>>> Just checked and what I have in my repository equals this:
> >>>>>>
> >>>>>> http://hg.linux-ha.org/dev/raw-file/tip/resources/OCF/pgsql
> >>>>>>
> >>>>>> Hmm, odd indeed. Which heartbeat-resources package do you have?
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> Dejan
> >>>>>>
> >>>>>>> On Mon, Jun 22, 2009 at 12:33 PM, Dejan
> >>>>>>> Muhamedagic<dejanmm[at]fastmail.fm> wrote:
> >>>>>>>>
> >>>>>>>> Hi Serge,
> >>>>>>>>
> >>>>>>>> On Mon, Jun 22, 2009 at 12:24:44PM -0600, Serge Dubrouski wrote:
> >>>>>>>>>
> >>>>>>>>> And here is the patch.
> >>>>>>>>
> >>>>>>>> Looks like you were using a different version than what we have
> >>>>>>>> in the hg repository:
> >>>>>>>>
> >>>>>>>> [0]rondo:work > patch -p0 --dry-run < /tmp/pgsql.patch
> >>>>>>>> patching file resources/OCF/pgsql
> >>>>>>>> Hunk #1 FAILED at 194.
> >>>>>>>> Hunk #3 FAILED at 253.
> >>>>>>>> Hunk #4 succeeded at 297 with fuzz 1.
> >>>>>>>> Hunk #5 FAILED at 308.
> >>>>>>>> 3 out of 5 hunks FAILED -- saving rejects to file
> >>>>>>>> resources/OCF/pgsql.rej
> >>>>>>>>
> >>>>>>>> Or maybe I missed some patch. What I have as the last changeset
> >>>>>>>> is this:
> >>>>>>>>
> >>>>>>>> changeset: ? 11977:1cbc4c8c571f
> >>>>>>>> user: ? ? ? ?Serge
> >>>>>>>> date: ? ? ? ?Thu Jun 26 01:51:05 2008 +0200
> >>>>>>>> summary: ? ? Low: pgsql RA: check for the non-supported action
> >>>>>>>>
> >>>>>>>> Can you please see what's up.
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>>
> >>>>>>>> Dejan
> >>>>>>>>
> >>>>>>>>> On Mon, Jun 22, 2009 at 12:00 PM, Serge Dubrouski
> >>>>>>>>> <sergeyfd[at]gmail.com>wrote:
> >>>>>>>>>
> >>>>>>>>>> All these patches are OK with one exception. Construction
> >>>>>>>>>> $(command) isn't
> >>>>>>>>>> supported by native Bourne shell so I'd propose changing it to
> >>>>>>>>>> `command`.
> >>>>>>>>>> Attached is a patch that combines all 3 patches and fixes that
> >>>>>>>>>> incompatibility issue.
> >>>>>>>>>>
> >>>>>>>>>> Thanks for the patches.
> >>>>>>>>>>
> >>>>>>>>>> 2009/6/18 NAKAHIRA Kazutomo <nakahira[at]intellilink.co.jp>
> >>>>>>>>>>
> >>>>>>>>>>> Hello,
> >>>>>>>>>>>
> >>>>>>>>>>> The pgsql RA includes the several confusing logs as follows
> >>>>>>>>>>> and I propose 3 patches to solve these problems.
> >>>>>>>>>>>
> >>>>>>>>>>> 1. When it takes time to start PostgreSQL, the "ERROR" level log
> >>>>>>>>>>> ? "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output
> >>>>>>>>>>> ? though the start of pgsql RA has succeeded.
> >>>>>>>>>>> ? It seems that "WARN" level is more appropriate than "ERROR".
> >>>>>>>>>>>
> >>>>>>>>>>> pgsql-ra-logging-1.patch is a patch that corrects No.1 problem.
> >>>>>>>>>>>
> >>>>>>>>>>> 2. In the start confirmation processing of pgsql RA, An
> >>>>>>>>>>> unnecessary
> >>>>>>>>>>> ? "sleep 1" is executed though the start of PostgreSQL is
> >>>>>>>>>>> confirmed
> >>>>>>>>>>> ? with pgsql_monitor().
> >>>>>>>>>>> 3. In the stop processing of pgsql RA, An unnecessary log message
> >>>>>>>>>>> ? "PostgreSQL still hasn't stopped yet. Waiting..." is output to
> >>>>>>>>>>> ? the ha-debug though PostgreSQL has been stopped.
> >>>>>>>>>>>
> >>>>>>>>>>> pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3
> >>>>>>>>>>> problem.
> >>>>>>>>>>>
> >>>>>>>>>>> 4. When failing in the execution of the psql command and
> >>>>>>>>>>> ? the pg_ctl command, the execution result of the command is not
> >>>>>>>>>>> ? recorded in the log file.
> >>>>>>>>>>>
> >>>>>>>>>>> pgsql-ra-logging-3.patch is a patch that corrects No.4 problem.
> >>>>>>>>>>>
> >>>>>>>>>>> Best regards,
> >>>>>>>>>>> NAKAHIRA Kazutomo
> >>>>>>>>>>>
> >>>>>>>>>>> --
> >>>>>>>>>>> ----------------------------------------
> >>>>>>>>>>> NAKAHIRA Kazutomo
> >>>>>>>>>>> NTT DATA INTELLILINK CORPORATION
> >>>>>>>>>>> Open Source Business Unit
> >>>>>>>>>>> Software Services Integration Business Division
> >>>>>>>>>>>
> >>>>>>>>>>> _______________________________________________________
> >>>>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>>>>>>>>> Home Page: http://linux-ha.org/
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Serge Dubrouski.
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Serge Dubrouski.
> >>>>>>>>
> >>>>>>>>> _______________________________________________________
> >>>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>>>>>>> Home Page: http://linux-ha.org/
> >>>>>>>>
> >>>>>>>> _______________________________________________________
> >>>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>>>>>> Home Page: http://linux-ha.org/
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Serge Dubrouski.
> >>>>>>> _______________________________________________________
> >>>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>>>>> Home Page: http://linux-ha.org/
> >>>>>>
> >>>>>> _______________________________________________________
> >>>>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>>>> Home Page: http://linux-ha.org/
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Serge Dubrouski.
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Serge Dubrouski.
> >>>
> >>>> _______________________________________________________
> >>>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>>> Home Page: http://linux-ha.org/
> >>>
> >>> _______________________________________________________
> >>> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>> Home Page: http://linux-ha.org/
> >>>
> >>
> >>
> >>
> >>
> >> ------------------------------------------------------------------------
> >>
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >
> >
> > --
> > ----------------------------------------
> > NAKAHIRA Kazutomo
> > NTT DATA INTELLILINK CORPORATION
> > Open Source Business Unit
> > Software Services Integration Business Division
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
> >
>
>
>
> --
> Serge Dubrouski.
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com