taniguchis at intellilink
Sep 12, 2008, 1:25 AM
Post #4 of 5
(1227 views)
Permalink
|
|
Re: crm_get_msec() should return signed long long?
[In reply to]
|
|
Hi Andrew,
I got these ERROR messages with the latest pacemaker-dev.
pengine[27131]: 2008/09/12_15:44:15 ERROR: crm_int_helper: Characters left over
after parsing '120s': 's'
crmd[27128]: 2008/09/12_15:44:15 ERROR: crm_int_helper: Characters left over
after parsing '60s': 's'
Maybe the 2nd argument of crm_int_helper() should not be NULL
in new crm_get_msec().
As a trial, I applied the attached patch, no ERROR messages appeared.
(Please change the length of end_text to suitable one.)
Best Regards,
Satomi TANIGUCHI
Andrew Beekhof wrote:
> Thanks!
>
> Applied as:
> http://hg.clusterlabs.org/pacemaker/dev/rev/c6326dbb9fac
>
> 2008/9/9 Satomi Taniguchi <taniguchis [at] intellilink>:
>> Hi,
>>
>> I found that crm_get_msec() is declared to return _unsigned_ long long,
>> but it tries to return a minus value in the following cases.
>> i) input strings consists of only character string.
>> ii) input strings means minus value.
>> In these cases, the return value is unexpected one like 1271310319.
>>
>> I think this function should be declared to return _signed_ value,
>> but it is used in so many places without minus value check.
>> I tentatively created a patch , but I could'nt clarify its influence...
>>
>> Anyway, I just want to use crm_get_msec()'s function safely.
>> If it is possible as it is, please let me know.
>>
>> Regards,
>> Satomi Taniguchi
>>
>>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev [at] lists
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>>
>>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev [at] lists
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
|
crm_get_msec.patch
