Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux-HA: Dev

crm_mon doesn't exit immediately

 

 

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded


taniguchis at intellilink

Jul 17, 2008, 7:58 PM

Post #1 of 7 (554 views)
Permalink
crm_mon doesn't exit immediately

Hi,

I noticed that crm_mon doesn't exit immediately
when it receive SIGINT in mainloop.
It seems that SIGINT only kills sleep() function...
(Is this caused by something in G_main_add_SignalHandler()?
Or anything else?)

So, I modified it to exit wait function
when it is interrupted by a signal.
This patch is for Heartbeat STABLE 2.1 (aae8d51d84ec).
I hope it isn't too late for Heartbeat2.1.4...


Regards,
Satomi Taniguchi
Attachments: interrupted_by_a_signal.patch (0.57 KB)


ikedaj at intellilink

Jul 28, 2008, 11:33 PM

Post #2 of 7 (490 views)
Permalink
RE: crm_mon doesn't exit immediately [In reply to]

Hi,

Can somebody handle this issue?
She said that, she couldn't quit crm_mon command with Ctrl+C.
I usually use crm_mon with -i option, so I couldn't notice this behavior,
but it sure is that crm_mon running with no option wouldn't be stopped by
SIGINT.
It's odd, right?
I think almost all people would expect that Ctrl + C can stop this command.
See attached her patch.

Thanks,
Junko


> I noticed that crm_mon doesn't exit immediately
> when it receive SIGINT in mainloop.
> It seems that SIGINT only kills sleep() function...
> (Is this caused by something in G_main_add_SignalHandler()?
> Or anything else?)
>
> So, I modified it to exit wait function
> when it is interrupted by a signal.
> This patch is for Heartbeat STABLE 2.1 (aae8d51d84ec).
> I hope it isn't too late for Heartbeat2.1.4...
>
>
> Regards,
> Satomi Taniguchi
Attachments: interrupted_by_a_signal.patch (0.57 KB)


ikedaj at intellilink

Jul 29, 2008, 2:49 AM

Post #3 of 7 (490 views)
Permalink
RE: crm_mon doesn't exit immediately [In reply to]

Hi,

I found that crm_mon which is included in Pacemaker-dev(2f2343008186) can be
quitted by Ctrl + C.
If a back port from Pacemaker to Heartbeat 2.1.4 is better than applying the
patch,
We don't care about how to fix this.

Thanks,
Junko


> Can somebody handle this issue?
> She said that, she couldn't quit crm_mon command with Ctrl+C.
> I usually use crm_mon with -i option, so I couldn't notice this behavior,
> but it sure is that crm_mon running with no option wouldn't be stopped by
> SIGINT.
> It's odd, right?
> I think almost all people would expect that Ctrl + C can stop this
command.
> See attached her patch.
>
> Thanks,
> Junko
>
>
> > I noticed that crm_mon doesn't exit immediately
> > when it receive SIGINT in mainloop.
> > It seems that SIGINT only kills sleep() function...
> > (Is this caused by something in G_main_add_SignalHandler()?
> > Or anything else?)
> >
> > So, I modified it to exit wait function
> > when it is interrupted by a signal.
> > This patch is for Heartbeat STABLE 2.1 (aae8d51d84ec).
> > I hope it isn't too late for Heartbeat2.1.4...
> >
> >
> > Regards,
> > Satomi Taniguchi

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


kskmori at intellilink

Aug 11, 2008, 12:46 AM

Post #4 of 7 (424 views)
Permalink
Re: crm_mon doesn't exit immediately [In reply to]

Andrew,

If there's no objection I would like to push this patch into
the lha-2.1 repository, but any problem on that?

It seems that the latest pacemaker also presents the same behavior
so I think the both needs to be fixed as well.

Thanks,


"Junko IKEDA" <ikedaj[at]intellilink.co.jp> writes:

> Hi,
>
> I found that crm_mon which is included in Pacemaker-dev(2f2343008186) can be
> quitted by Ctrl + C.
> If a back port from Pacemaker to Heartbeat 2.1.4 is better than applying the
> patch,
> We don't care about how to fix this.
>
> Thanks,
> Junko
>
>
>> Can somebody handle this issue?
>> She said that, she couldn't quit crm_mon command with Ctrl+C.
>> I usually use crm_mon with -i option, so I couldn't notice this behavior,
>> but it sure is that crm_mon running with no option wouldn't be stopped by
>> SIGINT.
>> It's odd, right?
>> I think almost all people would expect that Ctrl + C can stop this
> command.
>> See attached her patch.
>>
>> Thanks,
>> Junko
>>
>>
>> > I noticed that crm_mon doesn't exit immediately
>> > when it receive SIGINT in mainloop.
>> > It seems that SIGINT only kills sleep() function...
>> > (Is this caused by something in G_main_add_SignalHandler()?
>> > Or anything else?)
>> >
>> > So, I modified it to exit wait function
>> > when it is interrupted by a signal.
>> > This patch is for Heartbeat STABLE 2.1 (aae8d51d84ec).
>> > I hope it isn't too late for Heartbeat2.1.4...
>> >
>> >
>> > Regards,
>> > Satomi Taniguchi
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

--
Keisuke MORI
NTT DATA Intellilink Corporation

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


beekhof at gmail

Aug 11, 2008, 1:20 AM

Post #5 of 7 (421 views)
Permalink
Re: crm_mon doesn't exit immediately [In reply to]

On Mon, Aug 11, 2008 at 09:46, Keisuke MORI <kskmori[at]intellilink.co.jp> wrote:
> Andrew,
>
> If there's no objection I would like to push this patch into
> the lha-2.1 repository, but any problem on that?

sure

>
> It seems that the latest pacemaker also presents the same behavior
> so I think the both needs to be fixed as well.

I thought it was fine?

>> I found that crm_mon which is included in Pacemaker-dev(2f2343008186) can be
>> quitted by Ctrl + C.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


ikedaj at intellilink

Aug 11, 2008, 5:57 PM

Post #6 of 7 (415 views)
Permalink
RE: crm_mon doesn't exit immediately [In reply to]

> > If there's no objection I would like to push this patch into
> > the lha-2.1 repository, but any problem on that?
>
> sure
>
> >
> > It seems that the latest pacemaker also presents the same behavior
> > so I think the both needs to be fixed as well.
>
> I thought it was fine?

sorry, that might have been my misunderstanding.
It seems that the latest Pacemaker should work the same (doesn't exit with
Ctrl + C) in source codes.

Thanks,
Junko

>
> >> I found that crm_mon which is included in Pacemaker-dev(2f2343008186)
can
> be
> >> quitted by Ctrl + C.

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


beekhof at gmail

Aug 12, 2008, 12:38 AM

Post #7 of 7 (411 views)
Permalink
Re: crm_mon doesn't exit immediately [In reply to]

On Tue, Aug 12, 2008 at 02:57, Junko IKEDA <ikedaj[at]intellilink.co.jp> wrote:
>> > If there's no objection I would like to push this patch into
>> > the lha-2.1 repository, but any problem on that?
>>
>> sure
>>
>> >
>> > It seems that the latest pacemaker also presents the same behavior
>> > so I think the both needs to be fixed as well.
>>
>> I thought it was fine?
>
> sorry, that might have been my misunderstanding.
> It seems that the latest Pacemaker should work the same (doesn't exit with
> Ctrl + C) in source codes.

In that case... applied:
http://hg.clusterlabs.org/pacemaker/stable-0.6/rev/c00d628cad8d


>
> Thanks,
> Junko
>
>>
>> >> I found that crm_mon which is included in Pacemaker-dev(2f2343008186)
> can
>> be
>> >> quitted by Ctrl + C.
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Linux-HA dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.