dejanmm at fastmail
Jun 25, 2008, 8:38 AM
Post #3 of 12
(521 views)
Permalink
|
|
Re: [PATCH] RA Route (LF 1929): an OCF RA to manage network routes
[In reply to]
|
|
Hi Florian,
I'll review the RA and include it in the repository.
Many thanks.
Cheers,
Dejan
On Wed, Jun 25, 2008 at 05:06:14PM +0200, Florian Haas wrote:
> # HG changeset patch
> # User Florian Haas <florian[at]linbit.com>
> # Date 1214403554 -7200
> # Node ID 28c1f9e604576bc8681ddf36e88d62488a96adbb
> # Parent 1e014af9b3a7bfd138721e11ded274153c857713
> An OCF RA capable of enabling and disabling network routes (using "ip route"), named "Route".
> Please see http://developerbugs.linux-foundation.org/show_bug.cgi?id=1929 for rationale and example use case.
>
> diff -r 1e014af9b3a7 -r 28c1f9e60457 resources/OCF/Makefile.am
> --- a/resources/OCF/Makefile.am Tue Jun 24 14:07:40 2008 +0200
> +++ b/resources/OCF/Makefile.am Wed Jun 25 16:19:14 2008 +0200
> @@ -74,6 +74,7 @@ ocf_SCRIPTS = ClusterMon \
> pgsql \
> Pure-FTPd \
> Raid1 \
> + Route \
> rsyncd \
> SAPDatabase \
> SAPInstance \
> diff -r 1e014af9b3a7 -r 28c1f9e60457 resources/OCF/Route
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/resources/OCF/Route Wed Jun 25 16:19:14 2008 +0200
> @@ -0,0 +1,236 @@
> +#!/bin/sh
> +#
> +# Route OCF RA. Enables and disables network routes.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of version 2 of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful, but
> +# WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> +#
> +# Further, this software is distributed without any warranty that it is
> +# free of the rightful claim of any third person regarding infringement
> +# or the like. Any license provided herein, whether implied or
> +# otherwise, applies only to this software file. Patent licenses, if
> +# any, provided herein do not apply to combinations of this program with
> +# other software, or any other product whatsoever.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
> +#
> +
> +#######################################################################
> +# Initialization:
> +
> +. ${OCF_ROOT}/resource.d/heartbeat/.ocf-shellfuncs
> +
> +#######################################################################
> +
> +meta_data() {
> + cat <<END
> +<?xml version="1.0"?>
> +<!DOCTYPE resource-agent SYSTEM "ra-api-1.dtd">
> +<resource-agent name="Route" version="0.1">
> +<version>1.0</version>
> +
> +<longdesc lang="en">
> +Enables and disables network routes.
> +
> +Supports host and net routes, routes via a gateway address,
> +and routes using specific source addresses.
> +</longdesc>
> +<shortdesc lang="en">Manages network routes</shortdesc>
> +
> +<parameters>
> +
> +<parameter name="destination" unique="1" required="1">
> +<longdesc lang="en">
> +The destination network (or host) to be configured for the route.
> +Specify the netmask suffix in CIDR notation (e.g. "/24").
> +If no suffix is given, a host route will be created.
> +Specify "0.0.0.0/0" or "default" if you want this resource to set the system default route.
> +</longdesc>
> +<shortdesc lang="en">Destination network</shortdesc>
> +<content type="string" default="" />
> +</parameter>
> +
> +<parameter name="device" unique="1">
> +<longdesc lang="en">
> +The outgoing network device to use for this route.
> +</longdesc>
> +<shortdesc lang="en">Outgoing network device</shortdesc>
> +<content type="string" default="" />
> +</parameter>
> +
> +<parameter name="gateway" unique="1">
> +<longdesc lang="en">
> +The gateway IP address to use for this route.
> +</longdesc>
> +<shortdesc lang="en">Gateway IP address</shortdesc>
> +<content type="string" default="" />
> +</parameter>
> +
> +<parameter name="source" unique="1">
> +<longdesc lang="en">
> +The source IP address to be configured for the route.
> +</longdesc>
> +<shortdesc lang="en">Source IP address</shortdesc>
> +<content type="string" default="" />
> +</parameter>
> +
> +</parameters>
> +
> +<actions>
> +<action name="start" timeout="20" />
> +<action name="stop" timeout="20" />
> +<action name="monitor" timeout="20" interval="10" depth="0" start-delay="0"/>
> +<action name="reload" timeout="20" />
> +<action name="meta-data" timeout="5" />
> +<action name="verify-all" timeout="20" />
> +</actions>
> +</resource-agent>
> +END
> +}
> +
> +#######################################################################
> +
> +# Don't do anything if the necessary utilities aren't present
> +for binary in ip grep; do
> + check_binary $binary
> +done
> +
> +# don't exit on TERM, to test that lrmd makes sure that we do exit
> +trap sigterm_handler TERM
> +sigterm_handler() {
> + ocf_log info "They use TERM to bring us down. No such luck."
> + return
> +}
> +
> +create_route_spec() {
> + # Creates a route specification for use by "ip route (add|del|show)"
> + local route_spec="to ${OCF_RESKEY_destination}"
> + if [ "${OCF_RESKEY_device}" ]; then
> + route_spec="${route_spec} dev ${OCF_RESKEY_device}"
> + fi
> + if [ "${OCF_RESKEY_gateway}" ]; then
> + route_spec="${route_spec} via ${OCF_RESKEY_gateway}"
> + fi
> + if [ "${OCF_RESKEY_source}" ]; then
> + route_spec="${route_spec} src ${OCF_RESKEY_source}"
> + fi
> + echo "$route_spec"
> +}
> +
> +route_usage() {
> + cat <<END
> +usage: $0 {start|stop|status|monitor|validate-all|meta-data}
> +
> +Expects to have a fully populated OCF RA-compliant environment set.
> +END
> +}
> +
> +route_start() {
> + route_status
> + local status=$?
> + if [ $status = $OCF_SUCCESS ]; then
> + ocf_log debug "${OCF_RESOURCE_INSTANCE} $__OCF_ACTION : already started."
> + return $OCF_SUCCESS
> + fi
> + ip route add $(create_route_spec) && return $OCF_SUCCESS
> + return $OCF_ERR_GENERIC
> +}
> +
> +route_stop() {
> + route_status
> + local status=$?
> + case $status in
> + $OCF_SUCCESS)
> + ip route del $(create_route_spec) && return $OCF_SUCCESS
> + ;;
> + $OCF_NOT_RUNNING)
> + ocf_log debug "${OCF_RESOURCE_INSTANCE} $__OCF_ACTION : already stopped."
> + return $OCF_SUCCESS
> + ;;
> + esac
> + return $OCF_ERR_GENERIC
> +}
> +
> +route_status() {
> + show_output="$(ip route show $(create_route_spec) 2>/dev/null)"
> + if [ $? -eq 0 ]; then
> + if [ "$show_output" ]; then
> + # "ip route show" returned zero, and produced output on
> + # stdout. That is what we expect.
> + return $OCF_SUCCESS
> + else
> + # "ip route show" returned zero, but produced no
> + # output on stdout. Assume the route was cleanly
> + # unconfigured.
> + return $OCF_NOT_RUNNING
> + fi
> + else
> + # "ip route show" returned an error code. Assume something
> + # went wrong.
> + return $OCF_ERR_GENERIC
> + fi
> +}
> +
> +route_validate() {
> + # Did we get a destination?
> + if [ -z "${OCF_RESKEY_destination}" ]; then
> + ocf_log error "Missing required parameter \"destination\"."
> + return $OCF_ERR_ARGS
> + fi
> + # Did we get either a device or a gateway address?
> + if [ -z "${OCF_RESKEY_device}" -a -z "${OCF_RESKEY_gateway}" ]; then
> + ocf_log error "Must specifiy either \"device\", or \"gateway\", or both."
> + return $OCF_ERR_ARGS
> + fi
> + # If a device has been configured, is it available on this system?
> + if [ "${OCF_RESKEY_device}" ]; then
> + if ! ip link show ${OCF_RESKEY_device} >/dev/null 2>&1; then
> + ocf_log error "Network device ${OCF_RESKEY_device} appears not to be available on this system."
> + return $OCF_ERR_ARGS
> + fi
> + fi
> + # If a source address has been configured, is it available on this system?
> + if [ "${OCF_RESKEY_source}" ]; then
> + if ! ip address show | grep ${OCF_RESKEY_source} >/dev/null 2>&1; then
> + ocf_log error "Source address ${OCF_RESKEY_source} appears not to be available on this system."
> + return $OCF_ERR_ARGS
> + fi
> + fi
> + # If a gateway address has been configured, is it reachable?
> + if [ "${OCF_RESKEY_gateway}" ]; then
> + if ! ip route get ${OCF_RESKEY_gateway} >/dev/null 2>&1; then
> + ocf_log error "Gateway address ${OCF_RESKEY_gateway} is unreachable."
> + return $OCF_ERR_ARGS
> + fi
> + fi
> + return $OCF_SUCCESS
> +}
> +
> +case $__OCF_ACTION in
> +meta-data) meta_data
> + exit $OCF_SUCCESS
> + ;;
> +start) route_validate && route_start;;
> +stop) route_stop;;
> +status|monitor) route_status;;
> +reload) ocf_log err "Reloading..."
> + route_start
> + ;;
> +validate-all) route_validate;;
> +usage|help) route_usage
> + exit $OCF_SUCCESS
> + ;;
> +*) route_usage
> + exit $OCF_ERR_UNIMPLEMENTED
> + ;;
> +esac
> +rc=$?
> +ocf_log debug "${OCF_RESOURCE_INSTANCE} $__OCF_ACTION : $rc"
> +exit $rc
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev[at]lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
|
Route.patch
Route.patch-2.gz
