Mailing List Archive: Linux: Kernel

linux-next build error (PNP/IXJ)

Index | Next | Previous | View Threaded

randy.dunlap at oracle

Jul 22, 2008, 10:27 AM

Post #1 of 7 (20 views)
Permalink

linux-next build error (PNP/IXJ)

Hi,

I'm seeing several build errors in linux-next-20080722 that I haven't
seen previously, although I don't know what changed to cause this.

They are all basically the same, in ixj (drivers/telephony/ixj*), when
CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
varies depending on IXJ=y or =m):

IXJ=y:
ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
or IXJ=m:
ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!

Suggestions?

Thanks,
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

bunk at kernel

Jul 22, 2008, 10:39 AM

Post #2 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tue, Jul 22, 2008 at 10:27:39AM -0700, Randy Dunlap wrote:
> Hi,
>
> I'm seeing several build errors in linux-next-20080722 that I haven't
> seen previously, although I don't know what changed to cause this.
>
> They are all basically the same, in ixj (drivers/telephony/ixj*), when
> CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> varies depending on IXJ=y or =m):
>
> IXJ=y:
> ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> or IXJ=m:
> ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
>
>
> Suggestions?

Please send a .config

> Thanks,

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

bjorn.helgaas at hp

Jul 22, 2008, 10:57 AM

Post #3 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tuesday 22 July 2008 11:27:39 am Randy Dunlap wrote:
> I'm seeing several build errors in linux-next-20080722 that I haven't
> seen previously, although I don't know what changed to cause this.
>
> They are all basically the same, in ixj (drivers/telephony/ixj*), when
> CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> varies depending on IXJ=y or =m):
>
> IXJ=y:
> ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> or IXJ=m:
> ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
>
>
> Suggestions?

I'd use something like the attached. I don't have a build environment
where CONFIG_PNP=n (all I have is x86 and ia64), so I haven't tested
this.

ixj: don't use PNP interfaces when CONFIG_PNP=n

This patch fixes a build problem when CONFIG_PNP=n.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas[at]hp.com>

diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
index 49cd979..51b7fb4 100644
--- a/drivers/telephony/ixj.c
+++ b/drivers/telephony/ixj.c
@@ -7588,6 +7588,7 @@ static IXJ *new_ixj(unsigned long port)

static int __init ixj_probe_isapnp(int *cnt)
{
+#ifdef CONFIG_PNP
int probe = 0;
int func = 0x110;
struct pnp_dev *dev = NULL, *old_dev = NULL;
@@ -7664,6 +7665,9 @@ static int __init ixj_probe_isapnp(int *cnt)
dev = NULL;
}
return probe;
+#else
+ return 0;
+#endif
}

static int __init ixj_probe_isa(int *cnt)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

rdunlap at xenotime

Jul 22, 2008, 12:41 PM

Post #4 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tue, 22 Jul 2008 20:39:57 +0300 Adrian Bunk wrote:

> On Tue, Jul 22, 2008 at 10:27:39AM -0700, Randy Dunlap wrote:
> > Hi,
> >
> > I'm seeing several build errors in linux-next-20080722 that I haven't
> > seen previously, although I don't know what changed to cause this.
> >
> > They are all basically the same, in ixj (drivers/telephony/ixj*), when
> > CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> > varies depending on IXJ=y or =m):
> >
> > IXJ=y:
> > ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> > or IXJ=m:
> > ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
> >
> >
> > Suggestions?
>
> Please send a .config

attached. (IXJ=m)

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Attachments:

config-r3125 (48.2 KB)

randy.dunlap at oracle

Jul 22, 2008, 12:52 PM

Post #5 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tue, 22 Jul 2008 11:57:13 -0600 Bjorn Helgaas wrote:

> On Tuesday 22 July 2008 11:27:39 am Randy Dunlap wrote:
> > I'm seeing several build errors in linux-next-20080722 that I haven't
> > seen previously, although I don't know what changed to cause this.
> >
> > They are all basically the same, in ixj (drivers/telephony/ixj*), when
> > CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> > varies depending on IXJ=y or =m):
> >
> > IXJ=y:
> > ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> > or IXJ=m:
> > ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
> >
> >
> > Suggestions?
>
> I'd use something like the attached. I don't have a build environment
> where CONFIG_PNP=n (all I have is x86 and ia64), so I haven't tested
> this.
>
> ixj: don't use PNP interfaces when CONFIG_PNP=n
>
> This patch fixes a build problem when CONFIG_PNP=n.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas[at]hp.com>
>
> diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
> index 49cd979..51b7fb4 100644
> --- a/drivers/telephony/ixj.c
> +++ b/drivers/telephony/ixj.c
> @@ -7588,6 +7588,7 @@ static IXJ *new_ixj(unsigned long port)
>
> static int __init ixj_probe_isapnp(int *cnt)
> {
> +#ifdef CONFIG_PNP
> int probe = 0;
> int func = 0x110;
> struct pnp_dev *dev = NULL, *old_dev = NULL;
> @@ -7664,6 +7665,9 @@ static int __init ixj_probe_isapnp(int *cnt)
> dev = NULL;
> }
> return probe;
> +#else
> + return 0;
> +#endif
> }
>
> static int __init ixj_probe_isa(int *cnt)
> --

Thanks.

Acked-by: Randy Dunlap <randy.dunlap[at]oracle.com>

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

bunk at kernel

Jul 22, 2008, 1:19 PM

Post #6 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tue, Jul 22, 2008 at 12:41:52PM -0700, Randy Dunlap wrote:
> On Tue, 22 Jul 2008 20:39:57 +0300 Adrian Bunk wrote:
>
> > On Tue, Jul 22, 2008 at 10:27:39AM -0700, Randy Dunlap wrote:
> > > Hi,
> > >
> > > I'm seeing several build errors in linux-next-20080722 that I haven't
> > > seen previously, although I don't know what changed to cause this.
> > >
> > > They are all basically the same, in ixj (drivers/telephony/ixj*), when
> > > CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> > > varies depending on IXJ=y or =m):
> > >
> > > IXJ=y:
> > > ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> > > or IXJ=m:
> > > ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
> > >
> > >
> > > Suggestions?
> >
> > Please send a .config
>
> attached. (IXJ=m)

Works for me with gcc 4.3.1.
Which gcc version are you using?

Does disabling CONFIG_OPTIMIZE_INLINING fix it for you?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

rdunlap at xenotime

Jul 22, 2008, 1:32 PM

Post #7 of 7 (19 views)
Permalink

Re: linux-next build error (PNP/IXJ) [In reply to]

On Tue, 22 Jul 2008 23:19:30 +0300 Adrian Bunk wrote:

> On Tue, Jul 22, 2008 at 12:41:52PM -0700, Randy Dunlap wrote:
> > On Tue, 22 Jul 2008 20:39:57 +0300 Adrian Bunk wrote:
> >
> > > On Tue, Jul 22, 2008 at 10:27:39AM -0700, Randy Dunlap wrote:
> > > > Hi,
> > > >
> > > > I'm seeing several build errors in linux-next-20080722 that I haven't
> > > > seen previously, although I don't know what changed to cause this.
> > > >
> > > > They are all basically the same, in ixj (drivers/telephony/ixj*), when
> > > > CONFIG_PNP=n, and CONFIG_PHONE_IXJ=y or =m (so the actual error message
> > > > varies depending on IXJ=y or =m):
> > > >
> > > > IXJ=y:
> > > > ixj.c:(.text+0x329d98): undefined reference to `pnp_get_resource'
> > > > or IXJ=m:
> > > > ERROR: "pnp_get_resource" [drivers/telephony/ixj.ko] undefined!
> > > >
> > > >
> > > > Suggestions?
> > >
> > > Please send a .config
> >
> > attached. (IXJ=m)
>
> Works for me with gcc 4.3.1.
> Which gcc version are you using?

gcc (GCC) 4.2.1 (SUSE Linux)

> Does disabling CONFIG_OPTIMIZE_INLINING fix it for you?

Hmpf. Yes, it sure does.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com