Mailing List Archive: Linux: Kernel

Fix serial_txx9 compile.

Index | Next | Previous | View Threaded

davej at redhat

Jul 21, 2008, 2:16 PM

Post #1 of 12 (644 views)
Permalink

Fix serial_txx9 compile.

drivers/serial/serial_txx9.c: In function 'receive_chars':
drivers/serial/serial_txx9.c:275: error: 'struct uart_info' has no member named 'tty'

Signed-off-by: Dave Jones <davej [at] redhat>

--- linux-2.6.26.noarch/drivers/serial/serial_txx9.c~ 2008-07-21 17:13:21.000000000 -0400
+++ linux-2.6.26.noarch/drivers/serial/serial_txx9.c 2008-07-21 17:13:37.000000000 -0400
@@ -272,7 +272,7 @@ static void serial_txx9_initialize(struc
static inline void
receive_chars(struct uart_txx9_port *up, unsigned int *status)
{
- struct tty_struct *tty = up->port.info->tty;
+ struct tty_struct *tty = up->port.info->port.tty;
unsigned char ch;
unsigned int disr = *status;
int max_count = 256;

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 21, 2008, 3:00 PM

Post #2 of 12 (626 views)
Permalink

Re: Fix serial_txx9 compile. [In reply to]

On Mon, 21 Jul 2008 17:16:59 -0400
Dave Jones <davej [at] redhat> wrote:

> drivers/serial/serial_txx9.c: In function 'receive_chars':
> drivers/serial/serial_txx9.c:275: error: 'struct uart_info' has no member named 'tty'

Already fixed ages ago. Its in a patch that didn't get to Linus yet - see
the linux-next tree for the stuff pending.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 21, 2008, 3:07 PM

Post #3 of 12 (620 views)
Permalink

Re: Fix icom serial compile. [In reply to]

On Mon, 21 Jul 2008 18:13:55 -0400
Dave Jones <davej [at] redhat> wrote:

> drivers/serial/icom.c: In function 'recv_interrupt':
> drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'
>
> Signed-off-by: Dave Jones <davej [at] redhat>

NAK. Already in the ttydev tree but not yet gone to Linus

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

davej at redhat

Jul 21, 2008, 3:13 PM

Post #4 of 12 (608 views)
Permalink

Re: Fix icom serial compile. [In reply to]

drivers/serial/icom.c: In function 'recv_interrupt':
drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'

Signed-off-by: Dave Jones <davej [at] redhat>

--- linux-2.6.26.noarch/drivers/serial/icom.c~ 2008-07-21 18:08:30.000000000 -0400
+++ linux-2.6.26.noarch/drivers/serial/icom.c 2008-07-21 18:13:00.000000000 -0400
@@ -730,7 +730,7 @@ static void xmit_interrupt(u16 port_int_
static void recv_interrupt(u16 port_int_reg, struct icom_port *icom_port)
{
short int count, rcv_buff;
- struct tty_struct *tty = icom_port->uart_port.info->tty;
+ struct tty_struct *tty = icom_port->uart_port.info->port.tty;
unsigned short int status;
struct uart_icount *icount;
unsigned long offset;

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

davej at redhat

Jul 21, 2008, 3:27 PM

Post #5 of 12 (617 views)
Permalink

Re: Fix serial_txx9 compile. [In reply to]

On Mon, Jul 21, 2008 at 11:00:28PM +0100, Alan Cox wrote:
> On Mon, 21 Jul 2008 17:16:59 -0400
> Dave Jones <davej [at] redhat> wrote:
>
> > drivers/serial/serial_txx9.c: In function 'receive_chars':
> > drivers/serial/serial_txx9.c:275: error: 'struct uart_info' has no member named 'tty'
>
> Already fixed ages ago. Its in a patch that didn't get to Linus yet - see
> the linux-next tree for the stuff pending.

Odd. This breakage happened with the merge in -git8
Why didn't the associated fixes go along with that merge ?
If it was fixed ages ago, that implies we knowingly merged broken code,
which seems suboptimal. If nothing else, we're breaking bisectability
by merging in two batches.

Dave

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 21, 2008, 3:34 PM

Post #6 of 12 (605 views)
Permalink

Re: Fix serial_txx9 compile. [In reply to]

> Odd. This breakage happened with the merge in -git8
> Why didn't the associated fixes go along with that merge ?

Because they weren't fully tested against the clashing changes between
the tty tree, firmware and some other cleanups of unidentified origin.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

sfr at canb

Jul 21, 2008, 6:25 PM

Post #7 of 12 (599 views)
Permalink

Re: Fix icom serial compile. [In reply to]

Hi Alan,

On Mon, 21 Jul 2008 23:07:42 +0100 Alan Cox <alan [at] lxorguk> wrote:
>
> On Mon, 21 Jul 2008 18:13:55 -0400
> Dave Jones <davej [at] redhat> wrote:
>
> > drivers/serial/icom.c: In function 'recv_interrupt':
> > drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'
> >
> > Signed-off-by: Dave Jones <davej [at] redhat>
>
> NAK. Already in the ttydev tree but not yet gone to Linus

I have just sent a similar patch. I have to ask why you sent only some
of these patches since they were known to break some builds and you had
the fix patches already ...

--
Cheers,
Stephen Rothwell sfr [at] canb
http://www.canb.auug.org.au/~sfr/

paulus at samba

Jul 21, 2008, 6:56 PM

Post #8 of 12 (597 views)
Permalink

Re: Fix icom serial compile. [In reply to]

Alan Cox writes:

> On Mon, 21 Jul 2008 18:13:55 -0400
> Dave Jones <davej [at] redhat> wrote:
>
> > drivers/serial/icom.c: In function 'recv_interrupt':
> > drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'
> >
> > Signed-off-by: Dave Jones <davej [at] redhat>
>
> NAK. Already in the ttydev tree but not yet gone to Linus

Well then why on earth did you send Linus the patch that broke stuff
in the first place? That seems like a pretty unfriendly act to me.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 21, 2008, 7:05 PM

Post #9 of 12 (599 views)
Permalink

Re: Fix icom serial compile. [In reply to]

> > NAK. Already in the ttydev tree but not yet gone to Linus
>
> I have just sent a similar patch. I have to ask why you sent only some
> of these patches since they were known to break some builds and you had
> the fix patches already ...

I sent the first batch only because some later stuff didnt apply and I
happen to believe in testing patches before sending them (something I
note certain other people clearly do after shitting the lot at Linus)

I spent the past two days travelling, and all the net time I could get
trying to get the patches merged and tested. Everyone and their
grandmother keep patching the tty code again and again. I just had
another go before bed - its now six pulls in a row someone has broken the
patches.

Quite frankly if you want to moan about the fact I've been working till
4am trying to sort this mess out you can go see figure 1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 21, 2008, 7:06 PM

Post #10 of 12 (594 views)
Permalink

Re: Fix icom serial compile. [In reply to]

On Tue, 22 Jul 2008 11:56:46 +1000
Paul Mackerras <paulus [at] samba> wrote:

> Alan Cox writes:
>
> > On Mon, 21 Jul 2008 18:13:55 -0400
> > Dave Jones <davej [at] redhat> wrote:
> >
> > > drivers/serial/icom.c: In function 'recv_interrupt':
> > > drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'
> > >
> > > Signed-off-by: Dave Jones <davej [at] redhat>
> >
> > NAK. Already in the ttydev tree but not yet gone to Linus
>
> Well then why on earth did you send Linus the patch that broke stuff
> in the first place? That seems like a pretty unfriendly act to me.

See previous replies, apologies to this address.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

davej at redhat

Jul 21, 2008, 7:41 PM

Post #11 of 12 (602 views)
Permalink

Re: Fix icom serial compile. [In reply to]

On Tue, Jul 22, 2008 at 03:05:19AM +0100, Alan Cox wrote:
> > > NAK. Already in the ttydev tree but not yet gone to Linus
> >
> > I have just sent a similar patch. I have to ask why you sent only some
> > of these patches since they were known to break some builds and you had
> > the fix patches already ...
>
> I sent the first batch only because some later stuff didnt apply and I
> happen to believe in testing patches before sending them (something I
> note certain other people clearly do after shitting the lot at Linus)

So what stopped you from just sending the two diffs already posted here
twice today ? They're not dependant upon anything else, and the files
in questions haven't changed in months.

Leaving the tree broken, and NACKing attempts to fix it don't seem to be
particularly productive for anyone.

> I spent the past two days travelling, and all the net time I could get
> trying to get the patches merged and tested. Everyone and their
> grandmother keep patching the tty code again and again. I just had
> another go before bed - its now six pulls in a row someone has broken the
> patches.
>
> Quite frankly if you want to moan about the fact I've been working till
> 4am trying to sort this mess out you can go see figure 1.

Please, less drama, more fixing.

Dave

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Jul 22, 2008, 3:46 AM

Post #12 of 12 (606 views)
Permalink

Re: Fix icom serial compile. [In reply to]

> Leaving the tree broken, and NACKing attempts to fix it don't seem to be
> particularly productive for anyone.

I NAKKed the fix because it would have broken the merge *AGAIN* which
would have messed up the merging for everything else all for the matter
of what four hours ?

> Please, less drama, more fixing.

Go see figure 1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads