Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


ben.collins at canonical

Jul 20, 2008, 6:45 PM

Post #1 of 5 (3823 views)
Permalink
[PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices

When the Dell 370 and 410 BT adapters are put into BT radio mode, they
need to be prepared like many other Broadcom adapters.

Also, add quirk Broadcom 2046 devices with HCI_RESET.

CC: linux-bluetooth [at] vger
Signed-off-by: Michael Frey <michael.frey [at] canonical>
Signed-off-by: Mario Limonciello <Mario_Limonciello [at] Dell>
Signed-off-by: Tim Gardner <tim.gardner [at] canonical>
Signed-off-by: Ben Collins <ben.collins [at] canonical>
---
drivers/bluetooth/hci_usb.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
index 192522e..0254a6b 100644
--- a/drivers/bluetooth/hci_usb.c
+++ b/drivers/bluetooth/hci_usb.c
@@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = {

/* Dell laptop with Broadcom chip */
{ USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+ /* Dell Wireless 370 */
+ { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+ /* Dell Wireless 410 */
+ { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+
+ /* Broadcom 2046 */
+ { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET },

/* Microsoft Wireless Transceiver for Bluetooth 2.0 */
{ USB_DEVICE(0x045e, 0x009c), .driver_info = HCI_RESET },
--
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


marcel at holtmann

Jul 20, 2008, 10:08 PM

Post #2 of 5 (3730 views)
Permalink
Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices [In reply to]

Hi Ben,

> When the Dell 370 and 410 BT adapters are put into BT radio mode, they
> need to be prepared like many other Broadcom adapters.
>
> Also, add quirk Broadcom 2046 devices with HCI_RESET.
>
> CC: linux-bluetooth [at] vger
> Signed-off-by: Michael Frey <michael.frey [at] canonical>
> Signed-off-by: Mario Limonciello <Mario_Limonciello [at] Dell>
> Signed-off-by: Tim Gardner <tim.gardner [at] canonical>
> Signed-off-by: Ben Collins <ben.collins [at] canonical>
> ---
> drivers/bluetooth/hci_usb.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
> index 192522e..0254a6b 100644
> --- a/drivers/bluetooth/hci_usb.c
> +++ b/drivers/bluetooth/hci_usb.c
> @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = {
>
> /* Dell laptop with Broadcom chip */
> { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> + /* Dell Wireless 370 */
> + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> + /* Dell Wireless 410 */
> + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> +
> + /* Broadcom 2046 */
> + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET },

do me a favor and use tabs and not whitespaces here. And is this the
latest Apple machine that has a Broadcom instead of a CSR chip in it. If
so, then let the comment reflect this.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


ben.collins at canonical

Jul 20, 2008, 10:54 PM

Post #3 of 5 (3723 views)
Permalink
Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices [In reply to]

On Mon, 2008-07-21 at 07:08 +0200, Marcel Holtmann wrote:
> Hi Ben,
>
> > When the Dell 370 and 410 BT adapters are put into BT radio mode, they
> > need to be prepared like many other Broadcom adapters.
> >
> > Also, add quirk Broadcom 2046 devices with HCI_RESET.
> >
> > CC: linux-bluetooth [at] vger
> > Signed-off-by: Michael Frey <michael.frey [at] canonical>
> > Signed-off-by: Mario Limonciello <Mario_Limonciello [at] Dell>
> > Signed-off-by: Tim Gardner <tim.gardner [at] canonical>
> > Signed-off-by: Ben Collins <ben.collins [at] canonical>
> > ---
> > drivers/bluetooth/hci_usb.c | 7 +++++++
> > 1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
> > index 192522e..0254a6b 100644
> > --- a/drivers/bluetooth/hci_usb.c
> > +++ b/drivers/bluetooth/hci_usb.c
> > @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = {
> >
> > /* Dell laptop with Broadcom chip */
> > { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> > + /* Dell Wireless 370 */
> > + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> > + /* Dell Wireless 410 */
> > + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> > +
> > + /* Broadcom 2046 */
> > + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET },
>
> do me a favor and use tabs and not whitespaces here. And is this the
> latest Apple machine that has a Broadcom instead of a CSR chip in it. If
> so, then let the comment reflect this.

Whoops. That slipped through. I've no idea what system that device
actually came from. I'd have to ask Michael, since he was the one who
reported it. I'll resend a corrected patch in the morning.

Thanks Marcel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


ben.collins at canonical

Jul 21, 2008, 9:00 AM

Post #4 of 5 (3715 views)
Permalink
Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices [In reply to]

Preface: The "Broadcom" device is on unreleased hardware, so I can't
disclose the actual model.

When the Dell 370 and 410 BT adapters are put into BT radio mode, they
need to be prepared like many other Broadcom adapters.

Also, add quirk Broadcom 2046 devices with HCI_RESET. Reference for this
bug: https://launchpad.net/bugs/249448

CC: linux-bluetooth [at] vger
Signed-off-by: Michael Frey <michael.frey [at] canonical>
Signed-off-by: Mario Limonciello <Mario_Limonciello [at] Dell>
Signed-off-by: Tim Gardner <tim.gardner [at] canonical>
Signed-off-by: Ben Collins <ben.collins [at] canonical>

diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
index 192522e..c33bb59 100644
--- a/drivers/bluetooth/hci_usb.c
+++ b/drivers/bluetooth/hci_usb.c
@@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = {

/* Dell laptop with Broadcom chip */
{ USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+ /* Dell Wireless 370 */
+ { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+ /* Dell Wireless 410 */
+ { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+
+ /* Broadcom 2046 */
+ { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET },

/* Microsoft Wireless Transceiver for Bluetooth 2.0 */
{ USB_DEVICE(0x045e, 0x009c), .driver_info = HCI_RESET },


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


marcel at holtmann

Jul 21, 2008, 4:30 PM

Post #5 of 5 (3707 views)
Permalink
Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices [In reply to]

Hi Ben,

> Preface: The "Broadcom" device is on unreleased hardware, so I can't
> disclose the actual model.

then put on your todo list to update this entry once you can.

> When the Dell 370 and 410 BT adapters are put into BT radio mode, they
> need to be prepared like many other Broadcom adapters.
>
> Also, add quirk Broadcom 2046 devices with HCI_RESET. Reference for
> this
> bug: https://launchpad.net/bugs/249448
>
> CC: linux-bluetooth [at] vger
> Signed-off-by: Michael Frey <michael.frey [at] canonical>
> Signed-off-by: Mario Limonciello <Mario_Limonciello [at] Dell>
> Signed-off-by: Tim Gardner <tim.gardner [at] canonical>
> Signed-off-by: Ben Collins <ben.collins [at] canonical>

Acked-by: Marcel Holtmann <marcel [at] holtmann>

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.