Mailing List Archive: Linux: Kernel

[PATCH] x86 setup.c: cleanup includes

Index | Next | Previous | View Threaded

a.beregalov at gmail

Jul 6, 2008, 9:13 AM

Post #1 of 4 (90 views)
Permalink

[PATCH] x86 setup.c: cleanup includes

From: Alexander Beregalov <a.beregalov[at]gmail.com>

The patch applies to the linux-next tree.

x86: remove double includes in setup.c

Signed-off-by: Alexander Beregalov <a.beregalov[at]gmail.com>
---

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 3c98693..f4c9b58 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -57,12 +57,8 @@
#include <linux/slab.h>
#include <linux/user.h>
#include <linux/delay.h>
-#include <linux/highmem.h>

#include <linux/kallsyms.h>
-#include <linux/edd.h>
-#include <linux/iscsi_ibft.h>
-#include <linux/kexec.h>
#include <linux/cpufreq.h>
#include <linux/dma-mapping.h>
#include <linux/ctype.h>
@@ -104,7 +100,6 @@
#include <asm/paravirt.h>

#include <asm/percpu.h>
-#include <asm/sections.h>
#include <asm/topology.h>
#include <asm/apicdef.h>
#ifdef CONFIG_X86_64
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

randy.dunlap at oracle

Jul 6, 2008, 10:58 AM

Post #2 of 4 (79 views)
Permalink

Re: [PATCH] x86 setup.c: cleanup includes [In reply to]

On Sun, 6 Jul 2008 20:13:49 +0400 Alexander Beregalov wrote:

> From: Alexander Beregalov <a.beregalov[at]gmail.com>
>
> The patch applies to the linux-next tree.
>
>
> x86: remove double includes in setup.c

Hi,

Did you do these manually (by personal inspection) or by some tool?
If a tool, what tool/where is it? Thanks.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

a.beregalov at gmail

Jul 6, 2008, 1:29 PM

Post #3 of 4 (78 views)
Permalink

Re: [PATCH] x86 setup.c: cleanup includes [In reply to]

2008/7/6 Randy Dunlap <randy.dunlap[at]oracle.com>:
> Did you do these manually (by personal inspection) or by some tool?
> If a tool, what tool/where is it? Thanks.

It is a simple script like this:

find . -name "*.h" -exec grep.sh {} \;
find . -name "*.c" -exec grep.sh {} \;

grep.sh:
#!/bin/sh
grep -H "^#include" $1|sed "s,/\*.\+,,"|grep -v ":$"|sort|uniq -c|grep
-v "^ \+1:"

I have found about 70-80 double inclusions, but most of them have
reason for that and can not be removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Jul 18, 2008, 9:21 AM

Post #4 of 4 (51 views)
Permalink

Re: [PATCH] x86 setup.c: cleanup includes [In reply to]

* Alexander Beregalov <a.beregalov[at]gmail.com> wrote:

> From: Alexander Beregalov <a.beregalov[at]gmail.com>
>
> The patch applies to the linux-next tree.
>
> x86: remove double includes in setup.c

applied to tip/x86/cleanups - thanks Alexander.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com