Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] sched: Kill off dead cfs_rq_set_shares().

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


lethal at linux-sh

Jun 9, 2008, 1:12 AM

Post #1 of 2 (187 views)
Permalink
[PATCH] sched: Kill off dead cfs_rq_set_shares().

Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused
cfs_rq_set_shares() reference. As nothing is using this dummy function
in the first place, just kill it off.

Against current git, but still seems to be relevant to 'sched-devel' in
-tip.

Signed-off-by: Paul Mundt <lethal [at] linux-sh>

---

kernel/sched.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index bfb8ad8..25de9ef 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1471,16 +1471,8 @@ static unsigned long source_load(int cpu, int type);
static unsigned long target_load(int cpu, int type);
static unsigned long cpu_avg_load_per_task(int cpu);
static int task_hot(struct task_struct *p, u64 now, struct sched_domain *sd);
-#else /* CONFIG_SMP */
-
-#ifdef CONFIG_FAIR_GROUP_SCHED
-static void cfs_rq_set_shares(struct cfs_rq *cfs_rq, unsigned long shares)
-{
-}
#endif

-#endif /* CONFIG_SMP */
-
#include "sched_stats.h"
#include "sched_idletask.c"
#include "sched_fair.c"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


mingo at elte

Jun 10, 2008, 5:51 AM

Post #2 of 2 (159 views)
Permalink
Re: [PATCH] sched: Kill off dead cfs_rq_set_shares(). [In reply to]

* Paul Mundt <lethal [at] linux-sh> wrote:

> Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused
> cfs_rq_set_shares() reference. As nothing is using this dummy function
> in the first place, just kill it off.
>
> Against current git, but still seems to be relevant to 'sched-devel'
> in -tip.

applied, thanks Paul.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.