mkrufky at linuxtv
May 20, 2008, 9:16 AM
Post #2 of 3
(751 views)
Permalink
|
|
Re: [patch] fix build error in drivers/media/video/cx23885/cx2388 5-dvb.c
[In reply to]
|
|
Please see below, proper patch attached...
Ingo Molnar wrote:
> testing of the -tip tree found the following module build failure on
> latest -git:
>
> Building modules, stage 2.
> MODPOST 421 modules
> ERROR: "dib7000p_attach" [drivers/media/video/cx23885/cx23885.ko]
undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> with the following config:
>
> http://redhat.com/~mingo/misc/config-Tue_May_20_17_13_32_CEST_2008.bad
>
> the problem is caused that ./drivers/media/video/cx23885/cx23885-dvb.c
> depends on a DVB_DIB7000P symbol (dib7000p_attach), but its Kconfig rule
> only selects it if DVB_FE_CUSTOMISE is enabled:
>
> select DVB_DIB7000P if !DVB_FE_CUSTOMISE
>
> the minimal fix found is to select the DVB frontend driver
unconditionally.
>
> Signed-off-by: Ingo Molnar <mingo [at] elte>
> ---
> drivers/media/video/cx23885/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/media/video/cx23885/Kconfig
> ===================================================================
> --- linux.orig/drivers/media/video/cx23885/Kconfig
> +++ linux/drivers/media/video/cx23885/Kconfig
> @@ -11,7 +11,7 @@ config VIDEO_CX23885
> select VIDEOBUF_DVB
> select VIDEO_CX25840
> select VIDEO_CX2341X
> - select DVB_DIB7000P if !DVB_FE_CUSTOMISE
> + select DVB_DIB7000P
> select MEDIA_TUNER_MT2131 if !DVB_FE_CUSTOMISE
> select DVB_S5H1409 if !DVB_FE_CUSTOMISE
> select DVB_LGDT330X if !DVB_FE_CUSTOMISE
>
>
Ingo,
Your patch will work around a symptom of the problem, but this is not
the proper fix.
Please see the attached patch, which should be applied, instead.
Thanks for pointing this out.
Regards,
Mike Krufky
|
dib7000p-attach.patch
