macro at linux-mips
May 9, 2008, 3:12 PM
Post #1 of 1
(47 views)
Permalink
|
|
[PATCH] RTC/watchdog: M41T80: Fix a potential use of unitialized data
|
|
Watchdog handlers within the driver make use of "save_client" -- make
sure it has been initalized before the handlers are registered.
Signed-off-by: Maciej W. Rozycki <macro[at]linux-mips.org>
---
It should be obvious. Please apply.
Maciej
patch-2.6.26-rc1-20080505-m41t80-save_client-14
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c
--- linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c 2008-05-05 02:55:40.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c 2008-05-09 22:00:13.000000000 +0000
@@ -803,6 +803,7 @@ static int m41t80_probe(struct i2c_clien
#ifdef CONFIG_RTC_DRV_M41T80_WDT
if (clientdata->features & M41T80_FEATURE_HT) {
+ save_client = client;
rc = misc_register(&wdt_dev);
if (rc)
goto exit;
@@ -811,7 +812,6 @@ static int m41t80_probe(struct i2c_clien
misc_deregister(&wdt_dev);
goto exit;
}
- save_client = client;
}
#endif
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
