Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

USB: serial: ti_usb_3410_5052: Correct TUSB3410 endpoint requirements.

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


chrisw at sous-sol

Apr 16, 2008, 6:01 PM

Post #1 of 3 (1990 views)
Permalink
USB: serial: ti_usb_3410_5052: Correct TUSB3410 endpoint requirements.

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Robert Spanton <rspanton [at] zepler>

upstream commit: 1bfd6693cd66f1e79abce62d3e8c3647e1f59a55

The changes introduced in commit
063a2da8f01806906f7d7b1a1424b9afddebc443 changed the semantics of the
num_interrupt_in, num_interrupt_out, num_bulk_in and num_bulk_out
entries of the usb_serial_driver struct to be the number of endpoints
the device has when probed.

This patch changes the ti_1port_device usb_serial_driver struct to
reflect this change. The single port devices only have 1
bulk_out endpoint in their initial configuration, and so this patch
changes the number of other types to NUM_DONT_CARE.

The same change probably needs doing to the ti_2port_device struct,
but I don't have a two port device at hand.

Signed-off-by: Robert Spanton <rspanton [at] zepler>
Cc: stable <stable [at] kernel>
Signed-off-by: Greg Kroah-Hartman <gregkh [at] suse>
Signed-off-by: Chris Wright <chrisw [at] sous-sol>
---
drivers/usb/serial/ti_usb_3410_5052.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -264,8 +264,8 @@ static struct usb_serial_driver ti_1port
.description = "TI USB 3410 1 port adapter",
.usb_driver = &ti_usb_driver,
.id_table = ti_id_table_3410,
- .num_interrupt_in = 1,
- .num_bulk_in = 1,
+ .num_interrupt_in = NUM_DONT_CARE,
+ .num_bulk_in = NUM_DONT_CARE,
.num_bulk_out = 1,
.num_ports = 1,
.attach = ti_startup,

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


oliver at neukum

Apr 17, 2008, 1:01 AM

Post #2 of 3 (1807 views)
Permalink
Re: USB: serial: ti_usb_3410_5052: Correct TUSB3410 endpoint requirements. [In reply to]

Am Donnerstag, 17. April 2008 03:01:46 schrieb Chris Wright:
> -stable review patch. If anyone has any objections, please let us know.
> ---------------------
>
> From: Robert Spanton <rspanton [at] zepler>
>
> upstream commit: 1bfd6693cd66f1e79abce62d3e8c3647e1f59a55
>
> The changes introduced in commit
> 063a2da8f01806906f7d7b1a1424b9afddebc443 changed the semantics of the
> num_interrupt_in, num_interrupt_out, num_bulk_in and num_bulk_out
> entries of the usb_serial_driver struct to be the number of endpoints
> the device has when probed.

Greg, your last patch to 2.6.25-rc9 should have obsoleted this patch.
Should your patch be included instead of this patch and
"USB: serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24" ?

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


gregkh at suse

Apr 17, 2008, 10:02 AM

Post #3 of 3 (1802 views)
Permalink
Re: USB: serial: ti_usb_3410_5052: Correct TUSB3410 endpoint requirements. [In reply to]

On Thu, Apr 17, 2008 at 10:01:57AM +0200, Oliver Neukum wrote:
> Am Donnerstag, 17. April 2008 03:01:46 schrieb Chris Wright:
> > -stable review patch. If anyone has any objections, please let us know.
> > ---------------------
> >
> > From: Robert Spanton <rspanton [at] zepler>
> >
> > upstream commit: 1bfd6693cd66f1e79abce62d3e8c3647e1f59a55
> >
> > The changes introduced in commit
> > 063a2da8f01806906f7d7b1a1424b9afddebc443 changed the semantics of the
> > num_interrupt_in, num_interrupt_out, num_bulk_in and num_bulk_out
> > entries of the usb_serial_driver struct to be the number of endpoints
> > the device has when probed.
>
> Greg, your last patch to 2.6.25-rc9 should have obsoleted this patch.

Yes, but it came in too late :(

> Should your patch be included instead of this patch and
> "USB: serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24" ?

This one is safe enough for now, the other patch has already been sent
to stable@ so it will go into the next 2.6.24 kernel release.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.