Mailing List Archive: Linux: Kernel

[PATCH -mm] Blackfin arch: cleanup cache header file

Index | Next | Previous | View Threaded

bryan.wu at analog

Mar 26, 2007, 3:11 AM

Post #1 of 2 (438 views)
Permalink

[PATCH -mm] Blackfin arch: cleanup cache header file

Hi folks,

According to Paul's review, this patch cleanup the
include/asm-blackfin/cache.h comments.

Signed-off-by: Bryan Wu <bryan.wu [at] analog>
---

include/asm-blackfin/cache.h | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)

Index: linux-2.6/include/asm-blackfin/cache.h
===================================================================
--- linux-2.6.orig/include/asm-blackfin/cache.h
+++ linux-2.6/include/asm-blackfin/cache.h
@@ -1,13 +1,21 @@
+/*
+ * include/asm-blackfin/cache.h
+ */
#ifndef __ARCH_BLACKFIN_CACHE_H
#define __ARCH_BLACKFIN_CACHE_H

-/* bytes per L1 cache line */
-#define L1_CACHE_SHIFT 5 /* BlackFin loads 32 bytes for cache */
-#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
+/*
+ * Bytes per L1 cache line
+ * Blackfin loads 32 bytes for cache
+ */
+#define L1_CACHE_SHIFT 5
+#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)

-/* For speed we do need to align these ...MaTed---*/
-/* But include/linux/cache.h does this for us if we DO not define ...MaTed---*/
-#define __cacheline_aligned /***** maybe no need this Tony *****/
+/*
+ * Don't make __cacheline_aligned and
+ * ____cacheline_aligned defined in include/linux/cache.h
+ */
+#define __cacheline_aligned
#define ____cacheline_aligned

/*
_

Thanks
-Bryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

lethal at linux-sh

Mar 26, 2007, 4:28 AM

Post #2 of 2 (370 views)
Permalink

Re: [PATCH -mm] Blackfin arch: cleanup cache header file [In reply to]

On Mon, Mar 26, 2007 at 06:11:42PM +0800, Wu, Bryan wrote:
> +#define L1_CACHE_SHIFT 5
> +#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
>
> -/* For speed we do need to align these ...MaTed---*/
> -/* But include/linux/cache.h does this for us if we DO not define ...MaTed---*/
> -#define __cacheline_aligned /***** maybe no need this Tony *****/
> +/*
> + * Don't make __cacheline_aligned and
> + * ____cacheline_aligned defined in include/linux/cache.h
> + */
> +#define __cacheline_aligned
> #define ____cacheline_aligned
>
You still don't need this. Ancient versions of gcc had problems with the
attribute, but it's not even possible to build the kernel with those
anymore. Please remove these and try again. You can simply alias
SMP_CACHE_BYTES to L1_CACHE_BYTES if you've left this in due to the
resulting build failure.

m68knommu seems to be another user that never got cleaned up, perhaps
it's a good time to kill that off too..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads