Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] pstore: fix printk format warning

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


rdunlap at xenotime

Aug 3, 2012, 5:02 PM

Post #1 of 5 (107 views)
Permalink
[PATCH] pstore: fix printk format warning

From: Randy Dunlap <rdunlap [at] xenotime>

Fix printk format warning (on i386) in pstore:

fs/pstore/ram.c:409:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'

Signed-off-by: Randy Dunlap <rdunlap [at] xenotime>
Acked-by: Kees Cook <keescook [at] chromium>
Cc: Anton Vorontsov <anton.vorontsov [at] linaro>
---
I posted this patch on June 15 and July 23 but it has not been
merged anywhere afaict, so I'm sending it directly to the man.

fs/pstore/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-36-rc1.orig/fs/pstore/ram.c
+++ lnx-36-rc1/fs/pstore/ram.c
@@ -406,7 +406,7 @@ static int __devinit ramoops_probe(struc
goto fail_init_fprz;

if (!cxt->przs && !cxt->cprz && !cxt->fprz) {
- pr_err("memory size too small, minimum is %lu\n",
+ pr_err("memory size too small, minimum is %zu\n",
cxt->console_size + cxt->record_size +
cxt->ftrace_size);
goto fail_cnt;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


cbouatmailru at gmail

Aug 3, 2012, 6:15 PM

Post #2 of 5 (101 views)
Permalink
Re: [PATCH] pstore: fix printk format warning [In reply to]

On Fri, Aug 03, 2012 at 05:02:48PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap [at] xenotime>
>
> Fix printk format warning (on i386) in pstore:
>
> fs/pstore/ram.c:409:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
>
> Signed-off-by: Randy Dunlap <rdunlap [at] xenotime>
> Acked-by: Kees Cook <keescook [at] chromium>
> Cc: Anton Vorontsov <anton.vorontsov [at] linaro>
> ---
> I posted this patch on June 15 and July 23 but it has not been
> merged anywhere afaict, so I'm sending it directly to the man.

(I believe it's the first time I see that patch.)

Btw, I see no maintainers for the pstore, and it surely no longer
belongs to staging. Tony, I can send patches to you, or I can create
a git tree (actually, I already had it for my own convenience).. So
how about the following patch?

Kees, Colin, as you're also pstore authors, I assume you're interested
in reviewing/[n]acking any possible changes, so I also added you to
the M: entries, is that OK?

- - - -
From: Anton Vorontsov <cbouatmailru [at] gmail>
Subject: [PATCH] MAINTAINERS: Add pstore maintainers


Signed-off-by: Anton Vorontsov <cbouatmailru [at] gmail>
---
MAINTAINERS | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 94b823f..9aa40c1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5496,6 +5496,18 @@ L: cbe-oss-dev [at] lists
S: Maintained
F: drivers/block/ps3vram.c

+PSTORE FILESYSTEM
+M: Anton Vorontsov <cbouatmailru [at] gmail>
+M: Colin Cross <ccross [at] android>
+M: Kees Cook <keescook [at] chromium>
+M: Tony Luck <tony.luck [at] intel>
+S: Maintained
+T: git git://git.infradead.org/users/cbou/linux-pstore.git
+F: fs/pstore/
+F: include/linux/pstore*
+F: drivers/firmware/efivars.c
+F: drivers/acpi/apei/erst.c
+
PTP HARDWARE CLOCK SUPPORT
M: Richard Cochran <richardcochran [at] gmail>
S: Maintained
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


rdunlap at xenotime

Aug 3, 2012, 6:32 PM

Post #3 of 5 (98 views)
Permalink
Re: [PATCH] pstore: fix printk format warning [In reply to]

On 08/03/2012 06:15 PM, Anton Vorontsov wrote:

> On Fri, Aug 03, 2012 at 05:02:48PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap [at] xenotime>
>>
>> Fix printk format warning (on i386) in pstore:
>>
>> fs/pstore/ram.c:409:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
>>
>> Signed-off-by: Randy Dunlap <rdunlap [at] xenotime>
>> Acked-by: Kees Cook <keescook [at] chromium>
>> Cc: Anton Vorontsov <anton.vorontsov [at] linaro>
>> ---
>> I posted this patch on June 15 and July 23 but it has not been
>> merged anywhere afaict, so I'm sending it directly to the man.
>
> (I believe it's the first time I see that patch.)

That's quite possible. When Kees acked it, he advised
me to send it to GregKH, which I did, to no avail.


> Btw, I see no maintainers for the pstore, and it surely no longer
> belongs to staging. Tony, I can send patches to you, or I can create
> a git tree (actually, I already had it for my own convenience).. So
> how about the following patch?

Thanks for adding a MAINTAINERS entry for it.

> Kees, Colin, as you're also pstore authors, I assume you're interested
> in reviewing/[n]acking any possible changes, so I also added you to
> the M: entries, is that OK?
>
> - - - -
> From: Anton Vorontsov <cbouatmailru [at] gmail>
> Subject: [PATCH] MAINTAINERS: Add pstore maintainers
>
>
> Signed-off-by: Anton Vorontsov <cbouatmailru [at] gmail>
> ---
> MAINTAINERS | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 94b823f..9aa40c1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5496,6 +5496,18 @@ L: cbe-oss-dev [at] lists
> S: Maintained
> F: drivers/block/ps3vram.c
>
> +PSTORE FILESYSTEM
> +M: Anton Vorontsov <cbouatmailru [at] gmail>
> +M: Colin Cross <ccross [at] android>
> +M: Kees Cook <keescook [at] chromium>
> +M: Tony Luck <tony.luck [at] intel>
> +S: Maintained
> +T: git git://git.infradead.org/users/cbou/linux-pstore.git
> +F: fs/pstore/
> +F: include/linux/pstore*
> +F: drivers/firmware/efivars.c
> +F: drivers/acpi/apei/erst.c
> +
> PTP HARDWARE CLOCK SUPPORT
> M: Richard Cochran <richardcochran [at] gmail>
> S: Maintained



--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


keescook at chromium

Aug 3, 2012, 6:35 PM

Post #4 of 5 (98 views)
Permalink
Re: [PATCH] pstore: fix printk format warning [In reply to]

On Fri, Aug 3, 2012 at 6:32 PM, Randy Dunlap <rdunlap [at] xenotime> wrote:
> On 08/03/2012 06:15 PM, Anton Vorontsov wrote:
>
>> On Fri, Aug 03, 2012 at 05:02:48PM -0700, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap [at] xenotime>
>>>
>>> Fix printk format warning (on i386) in pstore:
>>>
>>> fs/pstore/ram.c:409:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap [at] xenotime>
>>> Acked-by: Kees Cook <keescook [at] chromium>
>>> Cc: Anton Vorontsov <anton.vorontsov [at] linaro>
>>> ---
>>> I posted this patch on June 15 and July 23 but it has not been
>>> merged anywhere afaict, so I'm sending it directly to the man.
>>
>> (I believe it's the first time I see that patch.)
>
> That's quite possible. When Kees acked it, he advised
> me to send it to GregKH, which I did, to no avail.
>
>
>> Btw, I see no maintainers for the pstore, and it surely no longer
>> belongs to staging. Tony, I can send patches to you, or I can create
>> a git tree (actually, I already had it for my own convenience).. So
>> how about the following patch?
>
> Thanks for adding a MAINTAINERS entry for it.
>
>> Kees, Colin, as you're also pstore authors, I assume you're interested
>> in reviewing/[n]acking any possible changes, so I also added you to
>> the M: entries, is that OK?

Cool with me; thanks!

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


tony.luck at intel

Aug 6, 2012, 9:07 AM

Post #5 of 5 (94 views)
Permalink
RE: [PATCH] pstore: fix printk format warning [In reply to]

> Btw, I see no maintainers for the pstore, and it surely no longer
> belongs to staging. Tony, I can send patches to you, or I can create
> a git tree (actually, I already had it for my own convenience).. So
> how about the following patch?

Acked-by: Tony Luck <tony.luck [at] intel>
NrybXǧv^)޺{.n+{zXܨ}Ơz&j:+vzZ++zfh~izw?&)ߢf^jǫym@Aa 0hi

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.