Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 8/8] release memory resources if hotadd_new_pgdat() failed

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


wency at cn

Jun 26, 2012, 2:20 AM

Post #1 of 2 (48 views)
Permalink
[PATCH 8/8] release memory resources if hotadd_new_pgdat() failed

We should goto error to release memory resource if hotadd_new_pgdat() failed.

Signed-off-by: Wen Congyang <wency [at] cn>
---
mm/memory_hotplug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 2a14d35..3796690 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size)
pgdat = hotadd_new_pgdat(nid, start);
ret = -ENOMEM;
if (!pgdat)
- goto out;
+ goto error;
new_pgdat = 1;
}

--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


rientjes at google

Jun 26, 2012, 9:29 PM

Post #2 of 2 (38 views)
Permalink
Re: [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed [In reply to]

On Tue, 26 Jun 2012, Wen Congyang wrote:

> We should goto error to release memory resource if hotadd_new_pgdat() failed.
>
> Signed-off-by: Wen Congyang <wency [at] cn>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a14d35..3796690 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size)
> pgdat = hotadd_new_pgdat(nid, start);
> ret = -ENOMEM;
> if (!pgdat)
> - goto out;
> + goto error;
> new_pgdat = 1;
> }
>

This is a generic memory hotplug patch and doesn't rely on the rest of the
series, so let's cc the maintainer, Andrew Morton
<akpm [at] linux-foundation>.

Acked-by: David Rientjes <rientjes [at] google>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.