Mailing List Archive: Linux: Kernel

[ATTEND or not ATTEND] That's the question!

1 2

View All

Index | Next | Previous | View Threaded

srivatsa.bhat at linux

Jul 6, 2012, 3:36 AM

Post #26 of 29 (28 views)
Permalink

Re: [Ksummit-2012-discuss] [ATTEND or not ATTEND] That's the question! [In reply to]

On 07/06/2012 03:41 PM, Richard Cochran wrote:
> On Fri, Jul 06, 2012 at 11:54:52AM +0200, Frederic Weisbecker wrote:
>> On Fri, Jul 06, 2012 at 01:43:06PM +0400, Glauber Costa wrote:
>>> The same way we have checkpatch, we can have something automated that
>>> will attempt to rule out some trivial patches in the counting process.
>>> We can scan a patch, and easily determine if each part of it is:
>>>
>>> * pure whitespace
>>> * pure Documentation change
>>> * comment fix
>>>
>>> And if a patch is 100 % comprised by those, we simply don't count it.
>>> People that just want to increase their numbers - they will always
>>> exist, will tend to stop doing that. Simply because doing it will not
>>> help them at all.
>>
>> OTOH, documentation changes or comment fixes, and even sometimes pure whitespace
>> fixes, can be very valuable contributions. This can be a useful and ungrateful
>> work and that deserve credit.
>>
>> We just can't find an automated and right way to evaluate a contribution.
>
> Well what about submitters and maintainers labeling patches below the
> SOB with tags like the following?
>
> Signed-off-by: Richard Cochran <richardcochran [at] gmail>
> Tags: docu whitespace trivial
>
> Part of the review would be making sure the labels fit.
>

Please no!
I don't see why we should clutter the changelog with tags for reasons as
unimportant as measuring some patch's value!

Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

glommer at parallels

Jul 6, 2012, 3:43 AM

Post #27 of 29 (28 views)
Permalink

Re: [Ksummit-2012-discuss] [ATTEND or not ATTEND] That's the question! [In reply to]

On 07/06/2012 02:36 PM, Srivatsa S. Bhat wrote:
> On 07/06/2012 03:41 PM, Richard Cochran wrote:
>> On Fri, Jul 06, 2012 at 11:54:52AM +0200, Frederic Weisbecker wrote:
>>> On Fri, Jul 06, 2012 at 01:43:06PM +0400, Glauber Costa wrote:
>>>> The same way we have checkpatch, we can have something automated that
>>>> will attempt to rule out some trivial patches in the counting process.
>>>> We can scan a patch, and easily determine if each part of it is:
>>>>
>>>> * pure whitespace
>>>> * pure Documentation change
>>>> * comment fix
>>>>
>>>> And if a patch is 100 % comprised by those, we simply don't count it.
>>>> People that just want to increase their numbers - they will always
>>>> exist, will tend to stop doing that. Simply because doing it will not
>>>> help them at all.
>>>
>>> OTOH, documentation changes or comment fixes, and even sometimes pure whitespace
>>> fixes, can be very valuable contributions. This can be a useful and ungrateful
>>> work and that deserve credit.
>>>
>>> We just can't find an automated and right way to evaluate a contribution.
>>
>> Well what about submitters and maintainers labeling patches below the
>> SOB with tags like the following?
>>
>> Signed-off-by: Richard Cochran <richardcochran [at] gmail>
>> Tags: docu whitespace trivial
>>
>> Part of the review would be making sure the labels fit.
>>
>
> Please no!
> I don't see why we should clutter the changelog with tags for reasons as
> unimportant as measuring some patch's value!
>
Stronger: Having the maintainer to do more work is hardly a way to decrease
the amount of work he does. (Well, it could be in some cases, but not in
this)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

rostedt at goodmis

Jul 6, 2012, 5:42 AM

Post #28 of 29 (28 views)
Permalink

Re: [Ksummit-2012-discuss] [ATTEND or not ATTEND] That's the question! [In reply to]

On Fri, 2012-07-06 at 14:43 +0400, Glauber Costa wrote:

> > Please no!
> > I don't see why we should clutter the changelog with tags for reasons as
> > unimportant as measuring some patch's value!
> >
> Stronger: Having the maintainer to do more work is hardly a way to decrease
> the amount of work he does. (Well, it could be in some cases, but not in
> this)

Strongest: We actually implemented this. It was called 'Impact' tags
(search the git logs). Linus *hated* them. He got really upset and
flamed us for doing it.

https://lkml.org/lkml/2009/4/15/296

Basically it's duplicating the subject line. The subject line should
have the impact (worth) of the patch. Heck, we should just add
'/trivial' to the subject. Like "x86/trivial: clean white space in x.c".

Or /doc or /comment or whatever. That should not be a problem, searches
are nicer on git log --pretty=oneline, and we should push to have all
non functional changes have such a tag in the subject. Then we can split
these changes out from functional changes.

There, solved ;)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

david at lang

Jul 17, 2012, 3:17 PM

Post #29 of 29 (26 views)
Permalink

Re: [Ksummit-2012-discuss] [ATTEND or not ATTEND] That's the question! [In reply to]

apologies for the late response

On Fri, 6 Jul 2012, Glauber Costa wrote:

> The same way we have checkpatch, we can have something automated that
> will attempt to rule out some trivial patches in the counting process.
> We can scan a patch, and easily determine if each part of it is:
>
> * pure whitespace
> * pure Documentation change
> * comment fix
>
> And if a patch is 100 % comprised by those, we simply don't count it.
> People that just want to increase their numbers - they will always
> exist, will tend to stop doing that. Simply because doing it will not
> help them at all.

I would look at things a bit differently.

strip out whitespace changes (they can be valuable, but usually only in
combination with other work)

added comments or documetnation count double (we always need better
documentation.

if the number of lines removed is more than a delata larger than the
number added, the patch is probably a reorginization/cleanup and should
get a boost in the metrics.

David Lang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

1 2

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads