Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


jj at chaosbits

Jun 9, 2012, 5:59 PM

Post #1 of 3 (81 views)
Permalink
[PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h

Signed-off-by: Jesper Juhl <jj [at] chaosbits>
---
drivers/scsi/qla2xxx/qla_target.c | 1 -
drivers/scsi/qla2xxx/qla_target.h | 2 --
2 files changed, 3 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 04f80eb..f7a49e4 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -26,7 +26,6 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
-#include <linux/version.h>
#include <linux/blkdev.h>
#include <linux/interrupt.h>
#include <linux/pci.h>
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index 9ec19bc..7df4df5 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -919,8 +919,6 @@ struct qla_tgt_srr_ctio {
#define QLA_TGT_XMIT_STATUS 2
#define QLA_TGT_XMIT_ALL (QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA)

-#include <linux/version.h>
-
extern struct qla_tgt_data qla_target;
/*
* Internal function prototypes
--
1.7.10.4


--
Jesper Juhl <jj [at] chaosbits> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


sachin.kamat at linaro

Jun 10, 2012, 12:18 AM

Post #2 of 3 (77 views)
Permalink
Re: [PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h [In reply to]

Hi Jesper,

I have already submitted a similar patch for this:

http://www.spinics.net/lists/linux-scsi/msg59815.html



On 10 June 2012 06:29, Jesper Juhl <jj [at] chaosbits> wrote:
> Signed-off-by: Jesper Juhl <jj [at] chaosbits>
> ---
>  drivers/scsi/qla2xxx/qla_target.c |    1 -
>  drivers/scsi/qla2xxx/qla_target.h |    2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 04f80eb..f7a49e4 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -26,7 +26,6 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <linux/blkdev.h>
>  #include <linux/interrupt.h>
>  #include <linux/pci.h>
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index 9ec19bc..7df4df5 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -919,8 +919,6 @@ struct qla_tgt_srr_ctio {
>  #define QLA_TGT_XMIT_STATUS            2
>  #define QLA_TGT_XMIT_ALL               (QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA)
>
> -#include <linux/version.h>
> -
>  extern struct qla_tgt_data qla_target;
>  /*
>  * Internal function prototypes
> --
> 1.7.10.4
>
>
> --
> Jesper Juhl <jj [at] chaosbits>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo [at] vger
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


jj at chaosbits

Jun 11, 2012, 1:39 PM

Post #3 of 3 (79 views)
Permalink
Re: [PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h [In reply to]

On Sun, 10 Jun 2012, Sachin Kamat wrote:

> Hi Jesper,
>
> I have already submitted a similar patch for this:
>
> http://www.spinics.net/lists/linux-scsi/msg59815.html
>
Ok. Cool.

Please consider my patch an ACK of yours then :-)


--
Jesper Juhl <jj [at] chaosbits> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.