heiko at sntech
Jun 3, 2012, 12:29 PM
During the porting of my machine to 3.5-rc1 some glitches in the
[PATCH 0/3] regulator: gpio-regulator: Fixes for problems that turned up with 3.5-rc1
gpio-regulator from different changes popped up.
This series fixes these.
While doing this, I noticed a possible uninitialized use of "selector" in
_regulator_do_set_voltage, where I'm not sure what the correct fix would be.
To summarize, before
best_val = rdev->desc->ops->list_voltage(rdev, selector);
best_val = -1;
selector is set in the set_voltage callback or if the new map_voltage returns
a non-error value. If it returns an error value or the else clause is reached
selector is used uninitialized in the list_voltage and set_voltage_time_sel
As written above, I'm not sure what the correct fix would be here.
Heiko Stuebner (3):
regulator: gpio-regulator: do not pass drvdata pointer as reference
regulator: gpio-regulator: Fix finding of smallest value
regulator: gpio-regulator: populate selector from set_voltage
drivers/regulator/gpio-regulator.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/