Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

Re: [linux-pm] [PATCH 0/2] bug fixes for coupled cpuidle

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


lenb at kernel

Jun 1, 2012, 10:50 PM

Post #1 of 2 (38 views)
Permalink
Re: [linux-pm] [PATCH 0/2] bug fixes for coupled cpuidle

On 05/18/2012 02:05 PM, Colin Cross wrote:

> The last modifications made to the coupled cpuidle patches introduced
> two bugs that I missed during testing. The online count was never
> initialized, causing coupled idle to always wait and never enter the
> ready loop. That hid the second bug, the ready count could never be
> decremented after exiting idle.
>
> Len, these two patches could be squashed into patch 3 of the original
> set. If you do squash them, you could also add Rafael's tags to the
> set (Reviewed-by on 1 and 2, acked-by on 3).


squash & tags update done.

> Or I can reupload the
> whole stack as v5 if you prefer.


no need.

thanks,
-Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


khilman at ti

Jun 5, 2012, 11:12 AM

Post #2 of 2 (31 views)
Permalink
Re: [linux-pm] [PATCH 0/2] bug fixes for coupled cpuidle [In reply to]

Hi Len,

Len Brown <lenb [at] kernel> writes:

> On 05/18/2012 02:05 PM, Colin Cross wrote:
>
>> The last modifications made to the coupled cpuidle patches introduced
>> two bugs that I missed during testing. The online count was never
>> initialized, causing coupled idle to always wait and never enter the
>> ready loop. That hid the second bug, the ready count could never be
>> decremented after exiting idle.
>>
>> Len, these two patches could be squashed into patch 3 of the original
>> set. If you do squash them, you could also add Rafael's tags to the
>> set (Reviewed-by on 1 and 2, acked-by on 3).
>
>
> squash & tags update done.
>
>> Or I can reupload the
>> whole stack as v5 if you prefer.
>
>
> no need.

Hmm, after the problems with the pull request, it looks like you dropped
the coupled CPUidle series completely. It's a shame that this has been
reviewed, tested and queued for so long only to see it dropped at the
last minute.

Instead of the squash, could you just queue the original series (that
has been in linux-next for some time) and then submit the fixes in
$SUBJECT series for v3.5-rc? That way we could still get this support
in for 3.5, which many of us are waiting for.

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.