Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 14/15] perf: Remove duplicate invocation on perf_event_for_each

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


acme at infradead

Jun 1, 2012, 3:16 PM

Post #1 of 1 (61 views)
Permalink
[PATCH 14/15] perf: Remove duplicate invocation on perf_event_for_each

From: Namhyung Kim <namhyung.kim [at] lge>

The @func callback was invoked twice for group leader when
perf_event_for_each() called. It seems the commit 75f937f24bd9
("perf_counter: Fix ctx->mutex vs counter ->mutex inversion") made the
mistake during the change.

Signed-off-by: Namhyung Kim <namhyung.kim [at] lge>
Acked-by: Peter Zijlstra <a.p.zijlstra [at] chello>
Cc: Namhyung Kim <namhyung [at] gmail>
Cc: Paul Mackerras <paulus [at] samba>
Cc: Peter Zijlstra <a.p.zijlstra [at] chello>
Link: http://lkml.kernel.org/r/1338443506-25009-1-git-send-email-namhyung.kim [at] lge
Signed-off-by: Arnaldo Carvalho de Melo <acme [at] redhat>
---
kernel/events/core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5b06cbb..f85c015 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -3181,7 +3181,6 @@ static void perf_event_for_each(struct perf_event *event,
event = event->group_leader;

perf_event_for_each_child(event, func);
- func(event);
list_for_each_entry(sibling, &event->sibling_list, group_entry)
perf_event_for_each_child(sibling, func);
mutex_unlock(&ctx->mutex);
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.