Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel
[PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &
 

Index | Next | Previous | View Flat


joe at perches

May 30, 2012, 1:25 PM


Views: 46
Permalink
[PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &

Using | with a constant is always true.
Likely this should have be &.

Signed-off-by: Joe Perches <joe [at] perches>
---
drivers/usb/gadget/pch_udc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index 1cfcc9e..f4fb71c 100644
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -2208,7 +2208,7 @@ static void pch_udc_complete_receiver(struct pch_udc_ep *ep)
return;
}
if ((td->status & PCH_UDC_BUFF_STS) == PCH_UDC_BS_DMA_DONE)
- if (td->status | PCH_UDC_DMA_LAST) {
+ if (td->status & PCH_UDC_DMA_LAST) {
count = td->status & PCH_UDC_RXTX_BYTES;
break;
}
--
1.7.8.111.gad25c.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Subject User Time
[PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for & joe at perches May 30, 2012, 1:25 PM
    Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for & balbi at ti May 31, 2012, 12:25 AM
        Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for & joe at perches May 31, 2012, 12:44 PM
            Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for & balbi at ti Jun 1, 2012, 2:50 AM

  Index | Next | Previous | View Flat
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.