devendra.aaru at gmail
May 27, 2012, 9:23 PM
Views: 93
Permalink
|
|
Re: [PATCH] [staging] bcm: Fix codingstyle problems
[In reply to]
|
|
Hello Joe,
On Mon, May 28, 2012 at 8:08 AM, Joe Perches <joe [at] perches> wrote:
> On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote:
>> Hi Devendra,
>>
>> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru [at] gmail> wrote:
>> > Signed-off-by: Devendra Naga <devendra.aaru [at] gmail>
>> > ---
>> > drivers/staging/bcm/Debug.h | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> I understand this is a simple change, but please add a descriptive
>> change log to your patch for consistency.
>
> Hello as well.
>
> Devendra, sometimes the simpler change isn't the best change.
> Consider converting some of these macros into functions.
>
So How about converting BCM_DEBUG_PRINT, BCM_DEBUG_PRINT_BUFFER,
BCM_SHOW_DEBUG_BITMAP into a single function? and using a type to
print the corresponding values?
>
Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
