namhyung.kim at lge
May 16, 2012, 2:45 AM
Views: 41
Permalink
|
|
[PATCH 2/3] Revert 'perf evlist: Fix creation of cpu map'
|
|
The commit 55261f46702c ("perf evlist: Fix creation of cpu
map") changed to create a per-task event when no cpu target
is specified. However it caused a problem since perf-task do
not allow event inheritance due to scalability issues so
that the result will contain samples only from parent, not
from its children.
So we should use perf-task-per-cpu events anyway to get the
right result. Revert it.
Reported-by: Linus Torvalds <torvalds [at] linux-foundation>
Analysed-by: Ingo Molnar <mingo [at] kernel>
Acked-and-tested-by: Peter Zijlstra <a.p.zijlstra [at] chello>
Signed-off-by: Namhyung Kim <namhyung.kim [at] lge>
---
tools/perf/util/evlist.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 80bef281eee0..87889f325678 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -609,10 +609,10 @@ int perf_evlist__create_maps(struct perf_evlist *evlist,
if (evlist->threads == NULL)
return -1;
- if (perf_target__has_cpu(target))
- evlist->cpus = cpu_map__new(target->cpu_list);
- else
+ if (perf_target__has_task(target))
evlist->cpus = cpu_map__dummy_new();
+ else
+ evlist->cpus = cpu_map__new(target->cpu_list);
if (evlist->cpus == NULL)
goto out_delete_threads;
--
1.7.10.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
[PATCH 2/3] Revert 'perf evlist: Fix creation of cpu map'
