vbyravarasu at nvidia
Apr 24, 2012, 10:28 PM
Post #2 of 3
(48 views)
Permalink
|
|
RE: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c fails
[In reply to]
|
|
Thanks for the patch.
Acked by: Venu Byravarasu<vbyravarasu [at] nvidia>
> -----Original Message-----
> From: Axel Lin [mailto:axel.lin [at] gmail]
> Sent: Wednesday, April 25, 2012 7:01 AM
> To: linux-kernel [at] vger
> Cc: Samuel Ortiz; Venu Byravarasu
> Subject: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c fails
>
> Return proper error instead of 0 if regmap_init_i2c fails.
>
> Signed-off-by: Axel Lin <axel.lin [at] gmail>
> ---
> drivers/mfd/tps65090.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index 47f802b..da821d9 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -286,10 +286,10 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
> tps65090->rmap = regmap_init_i2c(tps65090->client,
> &tps65090_regmap_config);
> if (IS_ERR(tps65090->rmap)) {
> - dev_err(&client->dev, "regmap_init failed with err: %ld\n",
> - PTR_ERR(tps65090->rmap));
> + ret = PTR_ERR(tps65090->rmap);
> + dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
> goto err_irq_exit;
> - };
> + }
>
> ret = mfd_add_devices(tps65090->dev, -1, tps65090s,
> ARRAY_SIZE(tps65090s), NULL, 0);
> --
> 1.7.5.4
>
>
{.n++%lzwmb맲rzX w{ay ʇڙ,jfhz w j:+vwjmzZ+ݢj"!iOzv^m nƊY&
|
