Login | Register For Free | Help	Search this list this category for: (Advanced)

Mailing List Archive: Linux: Kernel Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer   Index | Next | Previous | View Flat

torvalds at linux-foundation May 8, 2012, 8:52 PM Views: 172 Permalink Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer [In reply to] On Tue, May 8, 2012 at 4:14 AM, Kay Sievers <kay [at] vrfy> wrote: > > Yeah, we need to make sure, we never merge the (always racy) > continuation printk() users with (non-racy) non-continuation users. > Therefore KERN_CONT is required to suppress the newline and to merge the > content with the earlier non-newline-terminated printk() line. Why? I really think this is just a bug in the new code. KERN_CONT should not be needed if the previous printk didn't have a final "\n". We made it easier to use printk for a reason a few months ago. The new rules are: - If you have a KERN_<loglevel>, it *always* starts a new line, the obvious exception being KERN_CONT - the loglevels *only* matter at the start of the printk - so if you have '\n' embedded in a single printk, that changes nothing what-so-ever. It's not line-based. - if you didn't have a '\n', and don't have a loglevel, KERN_CONT is implied. Quite frankly, those three rules (a) make sense and (b) make things easy. Breaking them now is a bug. Please don't go adding ugly KERN_CONT when there really isn't any reason for it. Just fix the printk code you broke. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo [at] vger More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Subject User Time [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 2, 2012, 5:29 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer peterz at infradead May 3, 2012, 12:48 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 3, 2012, 12:54 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 3, 2012, 12:56 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer peterz at infradead May 3, 2012, 12:55 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer peterz at infradead May 3, 2012, 1:02 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 3, 2012, 1:09 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer peterz at infradead May 3, 2012, 1:11 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer greg at kroah May 3, 2012, 1:18 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 8, 2012, 1:48 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 8, 2012, 4:14 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 8, 2012, 6:33 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 8, 2012, 8:52 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 8, 2012, 7:29 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 8, 2012, 8:33 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 8, 2012, 8:57 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 8, 2012, 9:27 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer greg at kroah May 8, 2012, 3:57 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 8, 2012, 9:06 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 8, 2012, 9:11 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 8, 2012, 9:27 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 8, 2012, 9:36 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mingo at kernel May 9, 2012, 12:07 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 6:21 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 6:29 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 2:38 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 9, 2012, 6:50 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 7:37 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer yinghai at kernel May 9, 2012, 4:02 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer greg at kroah May 9, 2012, 4:06 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 7:30 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 11, 2012, 3:35 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 5:54 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 9, 2012, 6:18 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 9, 2012, 7:32 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 9, 2012, 7:46 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 9:39 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 10, 2012, 9:47 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer tony.luck at gmail May 10, 2012, 11:49 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 12:09 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer tytso at mit May 10, 2012, 1:14 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 10, 2012, 1:37 PM                 Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 1:39 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 1:38 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 10, 2012, 1:46 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 10, 2012, 1:52 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 2:01 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 10, 2012, 2:11 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 2:15 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 10, 2012, 2:58 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 10, 2012, 5:13 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 5:38 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 10, 2012, 6:23 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 14, 2012, 11:46 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer gregkh at linuxfoundation May 11, 2012, 8:19 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 11, 2012, 8:22 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 11, 2012, 8:35 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 11, 2012, 8:40 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 11, 2012, 8:47 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kernel at teksavvy May 11, 2012, 12:51 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 11, 2012, 1:02 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer levinsasha928 at gmail May 12, 2012, 12:43 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kernel at teksavvy May 12, 2012, 11:04 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 12, 2012, 11:35 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 13, 2012, 4:08 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kernel at teksavvy May 13, 2012, 6:22 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation May 13, 2012, 11:01 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer valdis.kletnieks at vt May 14, 2012, 9:40 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 13, 2012, 2:30 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 13, 2012, 2:48 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kernel at teksavvy May 13, 2012, 3:19 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer hpa at kernel May 16, 2012, 8:44 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer anton.vorontsov at linaro May 26, 2012, 4:11 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 27, 2012, 7:23 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 29, 2012, 9:07 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 29, 2012, 9:14 AM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 29, 2012, 9:34 AM         RE: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer tony.luck at intel May 29, 2012, 10:11 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer greg at kroah Jun 5, 2012, 11:33 PM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer gregkh at linuxfoundation Jun 14, 2012, 5:04 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer cbouatmailru at gmail Jun 14, 2012, 6:31 PM             Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Jun 15, 2012, 5:07 AM                 Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mingo at kernel Jun 15, 2012, 5:23 AM                     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer gregkh at linuxfoundation Jun 15, 2012, 2:53 PM                 Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer anton.vorontsov at linaro Jun 15, 2012, 5:23 AM                 Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer tony.luck at gmail Jun 15, 2012, 1:54 PM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer joe at perches May 29, 2012, 9:51 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 29, 2012, 10:22 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy May 30, 2012, 4:29 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mtk.manpages at gmail Nov 28, 2012, 5:33 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 28, 2012, 8:22 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer torvalds at linux-foundation Nov 28, 2012, 8:37 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 28, 2012, 8:49 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 28, 2012, 9:51 AM         Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mtk.manpages at gmail Nov 29, 2012, 5:18 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 29, 2012, 5:28 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mtk.manpages at gmail Nov 29, 2012, 5:37 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 29, 2012, 6:08 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer mtk.manpages at gmail Nov 29, 2012, 6:18 AM     Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer kay at vrfy Nov 29, 2012, 6:31 AM

Index | Next | Previous | View Flat   Linux     Kernel

Interested in having your list archived? Contact Gossamer Threads
 

Web Applications & Managed Hosting Powered by Gossamer Threads Inc.