Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[ 73/75] iwlwifi: use correct released ucode version

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


gregkh at linuxfoundation

May 4, 2012, 1:43 PM

Post #1 of 4 (53 views)
Permalink
[ 73/75] iwlwifi: use correct released ucode version

3.3-stable review patch. If anyone has any objections, please let me know.

------------------

From: Meenakshi Venkataraman <meenakshi.venkataraman [at] intel>

commit 78cbcf2b9dbe0565820dc7721316f9c401000a68 upstream.

Report correctly the latest released version
of the iwlwifi firmware for all
iwlwifi-supported devices.

Signed-off-by: Meenakshi Venkataraman <meenakshi.venkataraman [at] intel>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy [at] intel>
Signed-off-by: John W. Linville <linville [at] tuxdriver>
Signed-off-by: Greg Kroah-Hartman <gregkh [at] linuxfoundation>

---
drivers/net/wireless/iwlwifi/iwl-1000.c | 8 ++++----
drivers/net/wireless/iwlwifi/iwl-2000.c | 16 ++++++++--------
drivers/net/wireless/iwlwifi/iwl-5000.c | 11 +++++++++--
drivers/net/wireless/iwlwifi/iwl-6000.c | 10 ++++++----
4 files changed, 27 insertions(+), 18 deletions(-)

--- a/drivers/net/wireless/iwlwifi/iwl-1000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-1000.c
@@ -45,8 +45,8 @@
#include "iwl-cfg.h"

/* Highest firmware API version supported */
-#define IWL1000_UCODE_API_MAX 6
-#define IWL100_UCODE_API_MAX 6
+#define IWL1000_UCODE_API_MAX 5
+#define IWL100_UCODE_API_MAX 5

/* Oldest version we won't warn about */
#define IWL1000_UCODE_API_OK 5
@@ -235,5 +235,5 @@ struct iwl_cfg iwl100_bg_cfg = {
IWL_DEVICE_100,
};

-MODULE_FIRMWARE(IWL1000_MODULE_FIRMWARE(IWL1000_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL100_MODULE_FIRMWARE(IWL100_UCODE_API_MAX));
+MODULE_FIRMWARE(IWL1000_MODULE_FIRMWARE(IWL1000_UCODE_API_OK));
+MODULE_FIRMWARE(IWL100_MODULE_FIRMWARE(IWL100_UCODE_API_OK));
--- a/drivers/net/wireless/iwlwifi/iwl-2000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-2000.c
@@ -51,10 +51,10 @@
#define IWL135_UCODE_API_MAX 6

/* Oldest version we won't warn about */
-#define IWL2030_UCODE_API_OK 5
-#define IWL2000_UCODE_API_OK 5
-#define IWL105_UCODE_API_OK 5
-#define IWL135_UCODE_API_OK 5
+#define IWL2030_UCODE_API_OK 6
+#define IWL2000_UCODE_API_OK 6
+#define IWL105_UCODE_API_OK 6
+#define IWL135_UCODE_API_OK 6

/* Lowest firmware API version supported */
#define IWL2030_UCODE_API_MIN 5
@@ -338,7 +338,7 @@ struct iwl_cfg iwl135_bgn_cfg = {
.ht_params = &iwl2000_ht_params,
};

-MODULE_FIRMWARE(IWL2000_MODULE_FIRMWARE(IWL2000_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL2030_MODULE_FIRMWARE(IWL2030_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL105_MODULE_FIRMWARE(IWL105_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL135_MODULE_FIRMWARE(IWL135_UCODE_API_MAX));
+MODULE_FIRMWARE(IWL2000_MODULE_FIRMWARE(IWL2000_UCODE_API_OK));
+MODULE_FIRMWARE(IWL2030_MODULE_FIRMWARE(IWL2030_UCODE_API_OK));
+MODULE_FIRMWARE(IWL105_MODULE_FIRMWARE(IWL105_UCODE_API_OK));
+MODULE_FIRMWARE(IWL135_MODULE_FIRMWARE(IWL135_UCODE_API_OK));
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -50,6 +50,10 @@
#define IWL5000_UCODE_API_MAX 5
#define IWL5150_UCODE_API_MAX 2

+/* Oldest version we won't warn about */
+#define IWL5000_UCODE_API_OK 5
+#define IWL5150_UCODE_API_OK 2
+
/* Lowest firmware API version supported */
#define IWL5000_UCODE_API_MIN 1
#define IWL5150_UCODE_API_MIN 1
@@ -359,6 +363,7 @@ static struct iwl_ht_params iwl5000_ht_p
#define IWL_DEVICE_5000 \
.fw_name_pre = IWL5000_FW_PRE, \
.ucode_api_max = IWL5000_UCODE_API_MAX, \
+ .ucode_api_ok = IWL5000_UCODE_API_OK, \
.ucode_api_min = IWL5000_UCODE_API_MIN, \
.eeprom_ver = EEPROM_5000_EEPROM_VERSION, \
.eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION, \
@@ -402,6 +407,7 @@ struct iwl_cfg iwl5350_agn_cfg = {
.name = "Intel(R) WiMAX/WiFi Link 5350 AGN",
.fw_name_pre = IWL5000_FW_PRE,
.ucode_api_max = IWL5000_UCODE_API_MAX,
+ .ucode_api_ok = IWL5000_UCODE_API_OK,
.ucode_api_min = IWL5000_UCODE_API_MIN,
.eeprom_ver = EEPROM_5050_EEPROM_VERSION,
.eeprom_calib_ver = EEPROM_5050_TX_POWER_VERSION,
@@ -415,6 +421,7 @@ struct iwl_cfg iwl5350_agn_cfg = {
#define IWL_DEVICE_5150 \
.fw_name_pre = IWL5150_FW_PRE, \
.ucode_api_max = IWL5150_UCODE_API_MAX, \
+ .ucode_api_ok = IWL5150_UCODE_API_OK, \
.ucode_api_min = IWL5150_UCODE_API_MIN, \
.eeprom_ver = EEPROM_5050_EEPROM_VERSION, \
.eeprom_calib_ver = EEPROM_5050_TX_POWER_VERSION, \
@@ -436,5 +443,5 @@ struct iwl_cfg iwl5150_abg_cfg = {
IWL_DEVICE_5150,
};

-MODULE_FIRMWARE(IWL5000_MODULE_FIRMWARE(IWL5000_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL5150_MODULE_FIRMWARE(IWL5150_UCODE_API_MAX));
+MODULE_FIRMWARE(IWL5000_MODULE_FIRMWARE(IWL5000_UCODE_API_OK));
+MODULE_FIRMWARE(IWL5150_MODULE_FIRMWARE(IWL5150_UCODE_API_OK));
--- a/drivers/net/wireless/iwlwifi/iwl-6000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-6000.c
@@ -53,6 +53,8 @@
/* Oldest version we won't warn about */
#define IWL6000_UCODE_API_OK 4
#define IWL6000G2_UCODE_API_OK 5
+#define IWL6050_UCODE_API_OK 5
+#define IWL6000G2B_UCODE_API_OK 6

/* Lowest firmware API version supported */
#define IWL6000_UCODE_API_MIN 4
@@ -349,7 +351,7 @@ static struct iwl_bt_params iwl6000_bt_p
#define IWL_DEVICE_6005 \
.fw_name_pre = IWL6005_FW_PRE, \
.ucode_api_max = IWL6000G2_UCODE_API_MAX, \
- .ucode_api_ok = IWL6000G2_UCODE_API_OK, \
+ .ucode_api_ok = IWL6000G2B_UCODE_API_OK, \
.ucode_api_min = IWL6000G2_UCODE_API_MIN, \
.eeprom_ver = EEPROM_6005_EEPROM_VERSION, \
.eeprom_calib_ver = EEPROM_6005_TX_POWER_VERSION, \
@@ -548,6 +550,6 @@ struct iwl_cfg iwl6000_3agn_cfg = {
};

MODULE_FIRMWARE(IWL6000_MODULE_FIRMWARE(IWL6000_UCODE_API_OK));
-MODULE_FIRMWARE(IWL6050_MODULE_FIRMWARE(IWL6050_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL6005_MODULE_FIRMWARE(IWL6000G2_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL6030_MODULE_FIRMWARE(IWL6000G2_UCODE_API_MAX));
+MODULE_FIRMWARE(IWL6050_MODULE_FIRMWARE(IWL6050_UCODE_API_OK));
+MODULE_FIRMWARE(IWL6005_MODULE_FIRMWARE(IWL6000G2_UCODE_API_OK));
+MODULE_FIRMWARE(IWL6030_MODULE_FIRMWARE(IWL6000G2B_UCODE_API_OK));


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


ben at decadent

May 7, 2012, 7:41 AM

Post #2 of 4 (49 views)
Permalink
Re: [ 73/75] iwlwifi: use correct released ucode version [In reply to]

On Fri, 2012-05-04 at 13:43 -0700, Greg KH wrote:
> 3.3-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Meenakshi Venkataraman <meenakshi.venkataraman [at] intel>
>
> commit 78cbcf2b9dbe0565820dc7721316f9c401000a68 upstream.
>
> Report correctly the latest released version
> of the iwlwifi firmware for all
> iwlwifi-supported devices.
[...]

Isn't this also applicable to 3.2.y?

Ben.

--
Ben Hutchings
Hoare's Law of Large Problems:
Inside every large problem is a small problem struggling to get out.
Attachments: signature.asc (0.81 KB)


meenakshi.venkataraman at intel

May 7, 2012, 12:24 PM

Post #3 of 4 (48 views)
Permalink
RE: [ 73/75] iwlwifi: use correct released ucode version [In reply to]

Hi Ben,

>On Fri, 2012-05-04 at 13:43 -0700, Greg KH wrote:
>> 3.3-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Meenakshi Venkataraman <meenakshi.venkataraman [at] intel>
>>
>> commit 78cbcf2b9dbe0565820dc7721316f9c401000a68 upstream.
>>
>> Report correctly the latest released version of the iwlwifi firmware
>> for all iwlwifi-supported devices.
>[...]
>
>Isn't this also applicable to 3.2.y?

[MV] Just checked -- it is indeed applicable to 3.2 stable kernels as well. Do I need to modify the patch to get it into 3.2 as well?

Thanks,
Meenakshi
{.n++%lzwmb맲rzXw{ayʇڙ,jfhzw j:+vwjmzZ+ݢj"!iOzv^m nƊY&


ben at decadent

May 8, 2012, 8:03 PM

Post #4 of 4 (49 views)
Permalink
RE: [ 73/75] iwlwifi: use correct released ucode version [In reply to]

On Mon, 2012-05-07 at 19:24 +0000, Venkataraman, Meenakshi wrote:
> Hi Ben,
>
> >On Fri, 2012-05-04 at 13:43 -0700, Greg KH wrote:
> >> 3.3-stable review patch. If anyone has any objections, please let me know.
> >>
> >> ------------------
> >>
> >> From: Meenakshi Venkataraman <meenakshi.venkataraman [at] intel>
> >>
> >> commit 78cbcf2b9dbe0565820dc7721316f9c401000a68 upstream.
> >>
> >> Report correctly the latest released version of the iwlwifi firmware
> >> for all iwlwifi-supported devices.
> >[...]
> >
> >Isn't this also applicable to 3.2.y?
>
> [MV] Just checked -- it is indeed applicable to 3.2 stable kernels as
> well. Do I need to modify the patch to get it into 3.2 as well?

No, it was easy enough to fix up the context. I have now queued up:

b914811524fbe9e91fe50845f5d7bd4316b8a6ee iwlagn: allow up to uCode API 6 for 6000 devices
78cbcf2b9dbe0565820dc7721316f9c401000a68 iwlwifi: use correct released ucode version
1ed2ec37b44e86eaa8e0a03b908a39c80f65ee45 iwlwifi: use 6000G2B for 6030 device series

Ben.

--
Ben Hutchings
Life is what happens to you while you're busy making other plans.
- John Lennon
Attachments: signature.asc (0.81 KB)

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.