gregkh at linuxfoundation
May 4, 2012, 1:43 PM
Post #1 of 1
(26 views)
Permalink
|
|
[ 46/47] wl1251: fix crash on remove due to leftover work item
|
|
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Grazvydas Ignotas <notasas [at] gmail>
commit 4c1bcdb5a3354b250b82a67549f57ac27a3bb85f upstream.
This driver currently leaves elp_work behind when stopping, which
occasionally results in data corruption because work function ends
up accessing freed memory, typical symptoms of this are various
worker_thread crashes. Fix it by cancelling elp_work.
Signed-off-by: Grazvydas Ignotas <notasas [at] gmail>
Signed-off-by: John W. Linville <linville [at] tuxdriver>
Signed-off-by: Greg Kroah-Hartman <gregkh [at] linuxfoundation>
---
drivers/net/wireless/wl1251/main.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/wireless/wl1251/main.c
+++ b/drivers/net/wireless/wl1251/main.c
@@ -479,6 +479,7 @@ static void wl1251_op_stop(struct ieee80
cancel_work_sync(&wl->irq_work);
cancel_work_sync(&wl->tx_work);
cancel_work_sync(&wl->filter_work);
+ cancel_delayed_work_sync(&wl->elp_work);
mutex_lock(&wl->mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
