Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 1/3] devres: Clarify documentation for devres_destroy()

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


broonie at opensource

May 3, 2012, 10:15 AM

Post #1 of 2 (87 views)
Permalink
[PATCH 1/3] devres: Clarify documentation for devres_destroy()

It's not massively obvious (at least to me) that removing and freeing a
resource does not involve calling the release function for the resource
but rather only removes the management of it. Make the documentation more
explicit.

Signed-off-by: Mark Brown <broonie [at] opensource>
---
drivers/base/devres.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index 524bf96..1741a60 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -309,6 +309,10 @@ EXPORT_SYMBOL_GPL(devres_remove);
* which @match returns 1. If @match is NULL, it's considered to
* match all. If found, the resource is removed atomically and freed.
*
+ * Note that the release function for the resource will not be called,
+ * only the devres-allocated data will be freed. The caller becomes
+ * responsible for freeing any other data.
+ *
* RETURNS:
* 0 if devres is found and freed, -ENOENT if not found.
*/
--
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


grant.likely at secretlab

May 11, 2012, 5:41 PM

Post #2 of 2 (74 views)
Permalink
Re: [PATCH 1/3] devres: Clarify documentation for devres_destroy() [In reply to]

On Thu, 3 May 2012 18:15:12 +0100, Mark Brown <broonie [at] opensource> wrote:
> It's not massively obvious (at least to me) that removing and freeing a
> resource does not involve calling the release function for the resource
> but rather only removes the management of it. Make the documentation more
> explicit.
>
> Signed-off-by: Mark Brown <broonie [at] opensource>

This series looks appropriate to me. FWIW:

Acked-by: Grant Likely <grant.likely [at] secretlab>

> ---
> drivers/base/devres.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 524bf96..1741a60 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -309,6 +309,10 @@ EXPORT_SYMBOL_GPL(devres_remove);
> * which @match returns 1. If @match is NULL, it's considered to
> * match all. If found, the resource is removed atomically and freed.
> *
> + * Note that the release function for the resource will not be called,
> + * only the devres-allocated data will be freed. The caller becomes
> + * responsible for freeing any other data.
> + *
> * RETURNS:
> * 0 if devres is found and freed, -ENOENT if not found.
> */
> --
> 1.7.10
>

--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.