Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 2/3] usb: cp210x: Added in support to get and store part number

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


pffick at gmail

Apr 30, 2012, 9:06 PM

Post #1 of 3 (92 views)
Permalink
[PATCH 2/3] usb: cp210x: Added in support to get and store part number

This change gets the part number of the device when the driver is loaded and
stores it in the private portion of the port structure. This addition will
allow for part specific functionality to be added to the driver if needed.

Signed-off-by: Preston Fick <preston.fick [at] silabs>
---
drivers/usb/serial/cp210x.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index e67ccf3..b3646b8 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -154,6 +154,7 @@ MODULE_DEVICE_TABLE(usb, id_table);

struct cp210x_port_private {
__u8 bInterfaceNumber;
+ __u8 bPartNumber;
};

static struct usb_driver cp210x_driver = {
@@ -187,6 +188,13 @@ static struct usb_serial_driver * const serial_drivers[] = {
&cp210x_device, NULL
};

+/* Part number definitions */
+#define CP2101_PARTNUM 0x01
+#define CP2102_PARTNUM 0x02
+#define CP2103_PARTNUM 0x03
+#define CP2104_PARTNUM 0x04
+#define CP2105_PARTNUM 0x05
+
/* Config request types */
#define REQTYPE_HOST_TO_INTERFACE 0x41
#define REQTYPE_INTERFACE_TO_HOST 0xc1
@@ -220,11 +228,15 @@ static struct usb_serial_driver * const serial_drivers[] = {
#define CP210X_SET_CHARS 0x19
#define CP210X_GET_BAUDRATE 0x1D
#define CP210X_SET_BAUDRATE 0x1E
+#define CP210X_VENDOR_SPECIFIC 0xFF

/* CP210X_IFC_ENABLE */
#define UART_ENABLE 0x0001
#define UART_DISABLE 0x0000

+/* CP210X_VENDOR_SPECIFIC */
+#define CP210X_GET_PARTNUM 0x370B
+
/* CP210X_(SET|GET)_BAUDDIV */
#define BAUD_RATE_GEN_FREQ 0x384000

@@ -862,6 +874,7 @@ static int cp210x_startup(struct usb_serial *serial)
{
struct cp210x_port_private *port_priv;
int i;
+ unsigned int partNum;

/* cp210x buffers behave strangely unless device is reset */
usb_reset_device(serial->dev);
@@ -876,6 +889,17 @@ static int cp210x_startup(struct usb_serial *serial)
serial->interface->cur_altsetting->desc.bInterfaceNumber;

usb_set_serial_port_data(serial->port[i], port_priv);
+
+ /* Get the 1-byte part number of the cp210x device */
+ usb_control_msg(serial->dev,
+ usb_rcvctrlpipe(serial->dev, 0),
+ CP210X_VENDOR_SPECIFIC,
+ REQTYPE_DEVICE_TO_HOST,
+ CP210X_GET_PARTNUM,
+ port_priv->bInterfaceNumber,
+ &partNum, 1,
+ USB_CTRL_GET_TIMEOUT);
+ port_priv->bPartNumber = partNum & 0xFF;
}

return 0;
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


sshtylyov at mvista

May 1, 2012, 9:16 AM

Post #2 of 3 (90 views)
Permalink
Re: [PATCH 2/3] usb: cp210x: Added in support to get and store part number [In reply to]

Hello.

On 01-05-2012 8:06, Preston Fick wrote:

> This change gets the part number of the device when the driver is loaded and
> stores it in the private portion of the port structure. This addition will
> allow for part specific functionality to be added to the driver if needed.

> Signed-off-by: Preston Fick<preston.fick [at] silabs>
> ---
> drivers/usb/serial/cp210x.c | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)

> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e67ccf3..b3646b8 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
[...]
> @@ -862,6 +874,7 @@ static int cp210x_startup(struct usb_serial *serial)
> {
> struct cp210x_port_private *port_priv;
> int i;
> + unsigned int partNum;
>
> /* cp210x buffers behave strangely unless device is reset */
> usb_reset_device(serial->dev);
> @@ -876,6 +889,17 @@ static int cp210x_startup(struct usb_serial *serial)
> serial->interface->cur_altsetting->desc.bInterfaceNumber;
>
> usb_set_serial_port_data(serial->port[i], port_priv);
> +
> + /* Get the 1-byte part number of the cp210x device */
> + usb_control_msg(serial->dev,

This may involve DMA...

> + usb_rcvctrlpipe(serial->dev, 0),
> + CP210X_VENDOR_SPECIFIC,
> + REQTYPE_DEVICE_TO_HOST,
> + CP210X_GET_PARTNUM,
> + port_priv->bInterfaceNumber,
> + &partNum, 1,

You can't do DMA to a buffer situated on stack. You should kmalloc() the
buffer.

> + USB_CTRL_GET_TIMEOUT);
> + port_priv->bPartNumber = partNum& 0xFF;
> }
>
> return 0;

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


gregkh at linuxfoundation

May 2, 2012, 1:04 PM

Post #3 of 3 (89 views)
Permalink
Re: [PATCH 2/3] usb: cp210x: Added in support to get and store part number [In reply to]

On Tue, May 01, 2012 at 08:16:09PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 01-05-2012 8:06, Preston Fick wrote:
>
> >This change gets the part number of the device when the driver is loaded and
> >stores it in the private portion of the port structure. This addition will
> >allow for part specific functionality to be added to the driver if needed.
>
> >Signed-off-by: Preston Fick<preston.fick [at] silabs>
> >---
> > drivers/usb/serial/cp210x.c | 24 ++++++++++++++++++++++++
> > 1 files changed, 24 insertions(+), 0 deletions(-)
>
> >diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> >index e67ccf3..b3646b8 100644
> >--- a/drivers/usb/serial/cp210x.c
> >+++ b/drivers/usb/serial/cp210x.c
> [...]
> >@@ -862,6 +874,7 @@ static int cp210x_startup(struct usb_serial *serial)
> > {
> > struct cp210x_port_private *port_priv;
> > int i;
> >+ unsigned int partNum;
> >
> > /* cp210x buffers behave strangely unless device is reset */
> > usb_reset_device(serial->dev);
> >@@ -876,6 +889,17 @@ static int cp210x_startup(struct usb_serial *serial)
> > serial->interface->cur_altsetting->desc.bInterfaceNumber;
> >
> > usb_set_serial_port_data(serial->port[i], port_priv);
> >+
> >+ /* Get the 1-byte part number of the cp210x device */
> >+ usb_control_msg(serial->dev,
>
> This may involve DMA...
>
> >+ usb_rcvctrlpipe(serial->dev, 0),
> >+ CP210X_VENDOR_SPECIFIC,
> >+ REQTYPE_DEVICE_TO_HOST,
> >+ CP210X_GET_PARTNUM,
> >+ port_priv->bInterfaceNumber,
> >+ &partNum, 1,
>
> You can't do DMA to a buffer situated on stack. You should
> kmalloc() the buffer.

You "must" kmalloc() the buffer, otherwise the driver will break on some
systems.

Sorry, I can't accept this patch because of this. Please redo it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.