Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] drivers: staging: zcache: fix Kconfig crypto dependency

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


sjenning at linux

Apr 23, 2012, 6:33 PM

Post #1 of 7 (137 views)
Permalink
[PATCH] drivers: staging: zcache: fix Kconfig crypto dependency

ZCACHE is a boolean in the Kconfig. When selected, it
should require that CRYPTO be builtin (=y).

Currently, ZCACHE=y and CRYPTO=m is a valid configuration
when it should not be.

This patch changes the zcache Kconfig to enforce this
dependency.

Signed-off-by: Seth Jennings <sjenning [at] linux>
---
drivers/staging/zcache/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 3ed2c8f..7048e01 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -2,7 +2,7 @@ config ZCACHE
bool "Dynamic compression of swap pages and clean pagecache pages"
# X86 dependency is because zsmalloc uses non-portable pte/tlb
# functions
- depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
+ depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
select ZSMALLOC
select CRYPTO_LZO
default n
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


konrad.wilk at oracle

Apr 23, 2012, 7:09 PM

Post #2 of 7 (140 views)
Permalink
Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).

Hey Greg,

Please push this to your tree at your convience. linux-next
folks found this combination breaks the build ..

>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning [at] linux>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk [at] oracle>
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> select ZSMALLOC
> select CRYPTO_LZO
> default n
> --
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


gregkh at linuxfoundation

Apr 23, 2012, 7:27 PM

Post #3 of 7 (141 views)
Permalink
Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).
>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning [at] linux>
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86

Ok, this fixes one of the build problems reported, what about the other
one?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


sjenning at linux

Apr 24, 2012, 6:30 AM

Post #4 of 7 (130 views)
Permalink
Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

On 04/23/2012 09:27 PM, Greg Kroah-Hartman wrote:
> Ok, this fixes one of the build problems reported, what about the other
> one?

Both problems that I heard about were caused by same issue;
the issue fixed in this patch.

ZSMALLOC=m was only allowed because CRYPTO=m was allowed.
This patch requires CRYPTO=y, which also requires ZSMALLOC=y
when ZCACHE=y.

https://lkml.org/lkml/2012/4/19/588

https://lkml.org/lkml/2012/4/23/481

Thanks,
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


gregkh at linuxfoundation

Apr 24, 2012, 7:35 AM

Post #5 of 7 (130 views)
Permalink
Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

On Tue, Apr 24, 2012 at 08:30:28AM -0500, Seth Jennings wrote:
> On 04/23/2012 09:27 PM, Greg Kroah-Hartman wrote:
> > Ok, this fixes one of the build problems reported, what about the other
> > one?
>
> Both problems that I heard about were caused by same issue;
> the issue fixed in this patch.
>
> ZSMALLOC=m was only allowed because CRYPTO=m was allowed.
> This patch requires CRYPTO=y, which also requires ZSMALLOC=y
> when ZCACHE=y.
>
> https://lkml.org/lkml/2012/4/19/588
>
> https://lkml.org/lkml/2012/4/23/481

Ah, ok, I didn't realize that, thanks for letting me know, I'll queue
this up later today.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


rdunlap at xenotime

Apr 27, 2012, 5:38 PM

Post #6 of 7 (128 views)
Permalink
Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

On 04/23/2012 06:33 PM, Seth Jennings wrote:

> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).
>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning [at] linux>


Acked-by: Randy Dunlap <rdunlap [at] xenotime>

Thanks.

> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> select ZSMALLOC
> select CRYPTO_LZO
> default n



--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


dan.magenheimer at oracle

May 3, 2012, 2:11 PM

Post #7 of 7 (125 views)
Permalink
RE: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency [In reply to]

> From: Randy Dunlap [mailto:rdunlap [at] xenotime]
> Sent: Friday, April 27, 2012 6:38 PM
> To: Seth Jennings
> Cc: Greg Kroah-Hartman; devel [at] driverdev; Dan Magenheimer; Autif Khan; Konrad Rzeszutek
> Wilk; linux-kernel [at] vger; linux-mm [at] kvack; Robert Jennings; Nitin Gupta
> Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
>
> On 04/23/2012 06:33 PM, Seth Jennings wrote:
>
> > ZCACHE is a boolean in the Kconfig. When selected, it
> > should require that CRYPTO be builtin (=y).
> >
> > Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> > when it should not be.
> >
> > This patch changes the zcache Kconfig to enforce this
> > dependency.
> >
> > Signed-off-by: Seth Jennings <sjenning [at] linux>
>
>
> Acked-by: Randy Dunlap <rdunlap [at] xenotime>

Not sure if you need my approval, but I just in case you are waiting
for it:

Acked-by: Dan Magenheimer <dan.magenheimer [at] oracle>

> > ---
> > drivers/staging/zcache/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> > index 3ed2c8f..7048e01 100644
> > --- a/drivers/staging/zcache/Kconfig
> > +++ b/drivers/staging/zcache/Kconfig
> > @@ -2,7 +2,7 @@ config ZCACHE
> > bool "Dynamic compression of swap pages and clean pagecache pages"
> > # X86 dependency is because zsmalloc uses non-portable pte/tlb
> > # functions
> > - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> > + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> > select ZSMALLOC
> > select CRYPTO_LZO
> > default n
>
>
>
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.